Code review comment for lp:~unity-api-team/indicator-network/connectivity-service-bindings

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

This branch has a bug which is not in trunk. I don't know at which point it was introduced but let's fix it here. In wwan-section.cpp there is this:

m_items.erase(iter);
--iter;

Erase invalidates the iterator it points to so this is undefined behaviour. What is probably meant here is this:

iter = m_items.erase(iter);
--iter;

One more thing in inline comments.

review: Needs Fixing

« Back to merge proposal