Code review comment for lp:~unity-api-team/indicator-network/connectity-api-beginnings

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Diff is sane, still seems functionality sound, plus test coverage is looking good too. +1

Just a note on test coverage:

692 + if (!d->m_systemConnection.registerObject(NM_DBUS_PATH_SECRET_AGENT, this)) {
693 throw logic_error(

Its tricky to recreate some of these failure conditions, but we should consider coming back some time to test things like this. I.e. check that the indicator doesn't completely fall apart when these exceptions are thrown.

review: Approve

« Back to merge proposal