Code review comment for lp:~unity-api-team/connectivity-api/connectivity-service-source-package-shuffle

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Antti asked to check the debian/ changes. Nothing wrong otherwise, but please use the qml-module-foo naming instead, so that it won't need to be renamed later again.

See bug #1342031.

So, it'd be qml-module-connectivity and referred to as module, not a plugin. Please also change the dependencies to point to the correct packages instead of the transtional ones:

qml-module-qtquick2,
qml-module-qttest,

review: Needs Fixing

« Back to merge proposal