Code review comment for lp:~unity-api-team/click/drop_packagekit

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

> To fix this, I would suggest
> restoring the build-dependency on libpackagekit-glib2-dev, but changing it to
> read "libpackagekit-glib2-dev (>= 0.8.10) | base-files, libpackagekit-
> glib2-dev (<< 1.0.0)" instead.

done.

> It would be simplest for it to just read:
>
> if dpkg --compare-versions "$packagekit_version" ge 0.8.10 && \
> dpkg --compare-versions "$packagekit_version" lt 1.0.0; then
> echo yes
> else
> echo no
> fi

done.

« Back to merge proposal