Code review comment for lp:~unity-2d-team/unity-2d/unity-2d-dash-fullscreen-via-dconf

Revision history for this message
Ugo Riboni (uriboni) wrote :

I ended up agreeing with pretty much all your comments, therefore the following changes were made:
- Put back the call to updateDashModeDependingOnScreenGeometry on dash activation, so it overrides whatever dconf key is set
- Added a test which verifies this overriding

« Back to merge proposal