Code review comment for lp:~unity-2d-team/unity-2d/unity-2d-dash-fullscreen-via-dconf

> Fixed the error, and pushed the tests.
> The commit that you say doesn't belong actually does belong: we need to remove
> the call to updateDashModeDependingOnScreenGeometry otherwise every time we
> activate the dash it will override whatever fullscreen value we read from
> dconf (via the binding in QML).

Yes but that was already the case in trunk wasn't it? Fixing that is really better done in [1] because in there you change the way monitoring the screen's resolution is done [2] which is completely related to the line of code in question.

[1] https://code.launchpad.net/~unity-2d-team/unity-2d/unity-2d-dash-always-fullscreen-by-resolution/+merge/89886
[2] + connect(QApplication::desktop(), SIGNAL(resized(int)), SLOT(updateAlwaysFullScreen()));