Code review comment for lp:~unity-2d-team/unity-2d/dash-not-dock

Revision history for this message
Olivier Tilloy (osomon) wrote :

- setGeometry(availableGeometry());
+ move(availableGeometry().topLeft());
+ setFixedSize(availableGeometry().size());

You’re calling availableGeometry() twice here, you should call it only once and assign the result to a local variable to re-use in the calls to move(…) and setFixedSize(…).

review: Needs Fixing

« Back to merge proposal