Merge lp:~unit193/ubiquity/xfdesktop_background into lp:ubiquity

Proposed by Unit 193
Status: Merged
Merged at revision: 6255
Proposed branch: lp:~unit193/ubiquity/xfdesktop_background
Merge into: lp:ubiquity
Diff against target: 45 lines (+18/-2)
2 files modified
bin/ubiquity-dm (+11/-2)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~unit193/ubiquity/xfdesktop_background
Reviewer Review Type Date Requested Status
Simon Steinbeiß (community) Approve
Sean Davis (community) Approve
Ubuntu Installer Team Pending
Review via email: mp+247076@code.launchpad.net

Description of the change

This fixes the black background for Xubuntu when choosing the "Install" option.

Side note, the xprop command fixes an error message from xfwm4.

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

Approve as the Xubuntu Technical Lead, this is a change we certainly want for Xubuntu.

review: Approve
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

I've previously tested the fix and approve it as Xubuntu Project Lead. Thanks in advance for merging this in for us!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/ubiquity-dm'
2--- bin/ubiquity-dm 2015-01-07 07:50:00 +0000
3+++ bin/ubiquity-dm 2015-01-20 23:42:21 +0000
4@@ -482,7 +482,7 @@
5 elif osextras.find_on_path('metacity'):
6 wm_cmd = ['metacity', '--sm-disable']
7 elif osextras.find_on_path('xfwm4'):
8- wm_cmd = ['xfwm4', '--compositor=off']
9+ wm_cmd = ['xfwm4', '--compositor=off', '--sm-client-disable']
10 elif osextras.find_on_path('matchbox-window-manager'):
11 wm_cmd = ['matchbox-window-manager']
12 elif osextras.find_on_path('openbox-lubuntu'):
13@@ -508,7 +508,16 @@
14 stdin=null, stdout=logfile, stderr=logfile,
15 preexec_fn=self.drop_privileges))
16 extras.append(subprocess.Popen(
17- ['xfsettingsd'],
18+ ['xprop', '-root', '-format', '_NET_NUMBER_OF_DESKTOPS',
19+ '32c', '-set', '_NET_NUMBER_OF_DESKTOPS', '1'],
20+ stdin=null, stdout=logfile, stderr=logfile,
21+ preexec_fn=self.drop_privileges))
22+ extras.append(subprocess.Popen(
23+ ['xfsettingsd', '--sm-client-disable'],
24+ stdin=null, stdout=logfile, stderr=logfile,
25+ preexec_fn=self.drop_privileges))
26+ extras.append(subprocess.Popen(
27+ ['xfdesktop', '--sm-client-disable'],
28 stdin=null, stdout=logfile, stderr=logfile,
29 preexec_fn=self.drop_privileges))
30
31
32=== modified file 'debian/changelog'
33--- debian/changelog 2015-01-20 10:43:37 +0000
34+++ debian/changelog 2015-01-20 23:42:21 +0000
35@@ -1,3 +1,10 @@
36+ubiquity (2.21.6) vivid; urgency=medium
37+
38+ * Start all Xfce components with --sm-client-disable.
39+ * Explicitly run `xfdesktop` to paint the background. (LP: #1375893)
40+
41+ -- Unit 193 <unit193@ubuntu.com> Tue, 20 Jan 2015 18:13:58 -0500
42+
43 ubiquity (2.21.5) vivid; urgency=medium
44
45 * kde: explicitly set the KDE_SESSION_VERSION env variable to 4

Subscribers

People subscribed via source and target branches

to status/vote changes: