Code review comment for lp:~unifield-team/unifield-server/us-1567

Revision history for this message
jftempo (jfb-tempo-consulting) wrote :

(diff not generated by launchpad ...)

Does not work if default_code contains a comma, please retrieve xmlid_code from ir.model.data only in sync context.

In update_existing_translations, could you test this to prevent the iteration on all fields ?
trans_ids = trans_obj.search(cr, uid, [
                            ('res_id', '=', 0),
                            ('xml_id', '=', xmlid),
                            ('type', '=', 'model'),
                            ('name', '=like', '%s,%%' % (model,)),
                        ], context=context)

« Back to merge proposal