Code review comment for lp:~udt-contributors/mago/test-suite-class

Revision history for this message
Javier Collado (javier.collado) wrote :

Hello,

This is the branch with the changes to separate Applications from TesSuites.

As you will see, the code has been refactored a little and now there are two new subpackages called application and test_suite containing the code for the Application and TestSuite classes. Each package includes the following modules:
- main: Main definitions with code that applies to both gnome and ubuntu
- gnome: Definitions for gnome applications
- ubuntu: Definitions for ubuntu applications

In the main module in the test_suite package two classes are defined: TestSuite and SingleApplicationTestSuite. When using the latter, the application object is created and stored as self.application in the test suite object so in test cases code almost every reference to self.xxxx had to be changed to self.application. Aside from that, the code should be working the same way as before this change.

For test suites that need multiple applications to be tested at the same time, no class has been defined at the moment, but it should be straightforward once some requirements are defined.

Please let me know you comments/suggestions about this change.

Best regards,
   Javier

« Back to merge proposal