Merge lp:~ubuntuone-client-engineering/ubuntuone-music-java-library/update-stream-paths into lp:ubuntuone-music-java-library

Proposed by Michał Karnicki
Status: Merged
Merged at revision: 27
Proposed branch: lp:~ubuntuone-client-engineering/ubuntuone-music-java-library/update-stream-paths
Merge into: lp:ubuntuone-music-java-library
Diff against target: 38 lines (+2/-4)
3 files modified
src/main/com/ubuntuone/api/music/U1MusicAPI.java (+0/-1)
src/main/com/ubuntuone/api/music/client/StreamingClient.java (+1/-2)
src/test/com/ubuntuone/api/music/GetSongStreamTest.java (+1/-1)
To merge this branch: bzr merge lp:~ubuntuone-client-engineering/ubuntuone-music-java-library/update-stream-paths
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
Brian Curtin (community) Approve
Review via email: mp+133512@code.launchpad.net

Description of the change

Update song stream path.

To post a comment you must log in.
Revision history for this message
Brian Curtin (brian.curtin) wrote :

Looks ok to me.

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/main/com/ubuntuone/api/music/U1MusicAPI.java'
--- src/main/com/ubuntuone/api/music/U1MusicAPI.java 2012-09-28 02:04:22 +0000
+++ src/main/com/ubuntuone/api/music/U1MusicAPI.java 2012-11-08 16:27:03 +0000
@@ -85,7 +85,6 @@
85 public static final String PLAYLISTS = "playlists";85 public static final String PLAYLISTS = "playlists";
8686
87 protected static final String RESOURCE_HOST = "one.ubuntu.com";87 protected static final String RESOURCE_HOST = "one.ubuntu.com";
88 // TODO karni: Set this to proper streaming host when streaming handler is ready.
89 protected static final String STREAMING_HOST = "streaming.one.ubuntu.com";88 protected static final String STREAMING_HOST = "streaming.one.ubuntu.com";
90 89
91 private final ResourceClient resourceClient;90 private final ResourceClient resourceClient;
9291
=== modified file 'src/main/com/ubuntuone/api/music/client/StreamingClient.java'
--- src/main/com/ubuntuone/api/music/client/StreamingClient.java 2012-09-28 02:04:22 +0000
+++ src/main/com/ubuntuone/api/music/client/StreamingClient.java 2012-11-08 16:27:03 +0000
@@ -52,8 +52,7 @@
52 52
53 @Override53 @Override
54 public String getPath(String songId) {54 public String getPath(String songId) {
55 // TODO karni: Set this to proper streaming path when streaming handler is ready.55 return String.format("%s/songs/%s", API_PATH, songId);
56 return String.format("/stream/%s/", songId);
57 }56 }
5857
59 public HttpResponse download(String path, long offset,58 public HttpResponse download(String path, long offset,
6059
=== modified file 'src/test/com/ubuntuone/api/music/GetSongStreamTest.java'
--- src/test/com/ubuntuone/api/music/GetSongStreamTest.java 2012-09-19 19:17:30 +0000
+++ src/test/com/ubuntuone/api/music/GetSongStreamTest.java 2012-11-08 16:27:03 +0000
@@ -106,7 +106,7 @@
106 final long offset = 0L;106 final long offset = 0L;
107 107
108 final HttpGet httpRequest =108 final HttpGet httpRequest =
109 new HttpGet("https://streaming.one.ubuntu.com/stream/" + song.getId() + "/");109 new HttpGet("https://streaming.one.ubuntu.com/api/music/v2/songs/" + song.getId());
110 110
111 String songContent = "song_content";111 String songContent = "song_content";
112 final InputStream instream = new ByteArrayInputStream(songContent.getBytes("UTF-8"));112 final InputStream instream = new ByteArrayInputStream(songContent.getBytes("UTF-8"));

Subscribers

People subscribed via source and target branches