Merge lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063 into lp:ubuntu/precise/synergy

Proposed by Dave Gilbert
Status: Merged
Merged at revision: 20
Proposed branch: lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063
Merge into: lp:ubuntu/precise/synergy
Diff against target: 79 lines (+61/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/FengYeIArchString-InitMutex.patch (+51/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+86872@code.launchpad.net

Description of the change

This is a fix for lp bug 908578, imported from upstream.
It corresponds to upstream bug 3063 (see http://synergy-foss.org/tracker/issues/3063);
and upstream bug 3043 (http://synergy-foss.org/tracker/issues/3043).

What's a little tricky is that the patch in 3063 is the one that's been applied upstream,
yet the original patch writer in bug 3063 agrees that that the fix in 3043 is better - so
that's the one I picked; it seems to work for me.

To post a comment you must log in.
21. By Dave Gilbert

Add Dep3 tags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-12-04 18:58:04 +0000
+++ debian/changelog 2011-12-25 23:49:24 +0000
@@ -1,3 +1,12 @@
1synergy (1.3.8-1ubuntu1) precise; urgency=low
2
3 * Import Feng Ye's patch from
4 http://synergy-foss.org/tracker/issues/3043 as a fix for upstream 3063
5 (original patcher in 3063 agreed 3043 fix was better, although the fix in
6 3063 is currently in upstream). LP: #908578
7
8 -- Dr. David Alan Gilbert <dave@treblig.org> Sun, 25 Dec 2011 19:54:36 +0000
9
1synergy (1.3.8-1) unstable; urgency=low10synergy (1.3.8-1) unstable; urgency=low
211
3 * New upstream version.12 * New upstream version.
413
=== added file 'debian/patches/FengYeIArchString-InitMutex.patch'
--- debian/patches/FengYeIArchString-InitMutex.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/FengYeIArchString-InitMutex.patch 2011-12-25 23:49:24 +0000
@@ -0,0 +1,51 @@
1Description: Initialise mutex to avoid seg on paste, picked the
2 fix from upstream issue 3043, although the one currently in upstream
3 vcs is from issue 3063 since the author of the patch in 3063 said
4 this one was better.
5Origin: http://synergy-foss.org/tracker/issues/3043
6Bug: http://synergy-foss.org/tracker/issues/3063
7
8Index: src/lib/arch/IArchString.h
9===================================================================
10--- old/src/lib/arch/IArchString.h (revision 1134)
11+++ new/src/lib/arch/IArchString.h (working copy)
12@@ -31,6 +31,8 @@
13 public:
14 virtual ~IArchString();
15
16+ void initMutex();
17+
18 //! Wide character encodings
19 /*!
20 The known wide character encodings
21Index: src/lib/arch/IArchString.cpp
22===================================================================
23--- old/src/lib/arch/IArchString.cpp (revision 1134)
24+++ new/src/lib/arch/IArchString.cpp (working copy)
25@@ -36,6 +36,13 @@
26 }
27 }
28
29+void IArchString::initMutex()
30+{
31+ if (s_mutex == NULL) {
32+ s_mutex = ARCH->newMutex();
33+ }
34+}
35+
36 int
37 IArchString::convStringWCToMB(char* dst,
38 const wchar_t* src, UInt32 n, bool* errors)
39Index: src/lib/arch/CArch.cpp
40===================================================================
41--- old/src/lib/arch/CArch.cpp (revision 1134)
42+++ new/src/lib/arch/CArch.cpp (working copy)
43@@ -129,6 +129,8 @@
44 m_daemon = new ARCH_DAEMON;
45 m_taskbar = new ARCH_TASKBAR(args);
46
47+ m_string->initMutex();
48+
49 #if SYSAPI_WIN32
50 CArchMiscWindows::init();
51 #endif
052
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-12-04 18:58:04 +0000
+++ debian/patches/series 2011-12-25 23:49:24 +0000
@@ -1,1 +1,2 @@
1gnome3.patch1gnome3.patch
2FengYeIArchString-InitMutex.patch

Subscribers

People subscribed via source and target branches

to all changes: