Merge lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063 into lp:ubuntu/precise/synergy

Proposed by Dave Gilbert
Status: Merged
Merged at revision: 20
Proposed branch: lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063
Merge into: lp:ubuntu/precise/synergy
Diff against target: 79 lines (+61/-0)
3 files modified
debian/changelog (+9/-0)
debian/patches/FengYeIArchString-InitMutex.patch (+51/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-treblig/ubuntu/precise/synergy/synergy-lp908578fix-ups3063
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+86872@code.launchpad.net

Description of the change

This is a fix for lp bug 908578, imported from upstream.
It corresponds to upstream bug 3063 (see http://synergy-foss.org/tracker/issues/3063);
and upstream bug 3043 (http://synergy-foss.org/tracker/issues/3043).

What's a little tricky is that the patch in 3063 is the one that's been applied upstream,
yet the original patch writer in bug 3063 agrees that that the fix in 3043 is better - so
that's the one I picked; it seems to work for me.

To post a comment you must log in.
21. By Dave Gilbert

Add Dep3 tags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-04 18:58:04 +0000
3+++ debian/changelog 2011-12-25 23:49:24 +0000
4@@ -1,3 +1,12 @@
5+synergy (1.3.8-1ubuntu1) precise; urgency=low
6+
7+ * Import Feng Ye's patch from
8+ http://synergy-foss.org/tracker/issues/3043 as a fix for upstream 3063
9+ (original patcher in 3063 agreed 3043 fix was better, although the fix in
10+ 3063 is currently in upstream). LP: #908578
11+
12+ -- Dr. David Alan Gilbert <dave@treblig.org> Sun, 25 Dec 2011 19:54:36 +0000
13+
14 synergy (1.3.8-1) unstable; urgency=low
15
16 * New upstream version.
17
18=== added file 'debian/patches/FengYeIArchString-InitMutex.patch'
19--- debian/patches/FengYeIArchString-InitMutex.patch 1970-01-01 00:00:00 +0000
20+++ debian/patches/FengYeIArchString-InitMutex.patch 2011-12-25 23:49:24 +0000
21@@ -0,0 +1,51 @@
22+Description: Initialise mutex to avoid seg on paste, picked the
23+ fix from upstream issue 3043, although the one currently in upstream
24+ vcs is from issue 3063 since the author of the patch in 3063 said
25+ this one was better.
26+Origin: http://synergy-foss.org/tracker/issues/3043
27+Bug: http://synergy-foss.org/tracker/issues/3063
28+
29+Index: src/lib/arch/IArchString.h
30+===================================================================
31+--- old/src/lib/arch/IArchString.h (revision 1134)
32++++ new/src/lib/arch/IArchString.h (working copy)
33+@@ -31,6 +31,8 @@
34+ public:
35+ virtual ~IArchString();
36+
37++ void initMutex();
38++
39+ //! Wide character encodings
40+ /*!
41+ The known wide character encodings
42+Index: src/lib/arch/IArchString.cpp
43+===================================================================
44+--- old/src/lib/arch/IArchString.cpp (revision 1134)
45++++ new/src/lib/arch/IArchString.cpp (working copy)
46+@@ -36,6 +36,13 @@
47+ }
48+ }
49+
50++void IArchString::initMutex()
51++{
52++ if (s_mutex == NULL) {
53++ s_mutex = ARCH->newMutex();
54++ }
55++}
56++
57+ int
58+ IArchString::convStringWCToMB(char* dst,
59+ const wchar_t* src, UInt32 n, bool* errors)
60+Index: src/lib/arch/CArch.cpp
61+===================================================================
62+--- old/src/lib/arch/CArch.cpp (revision 1134)
63++++ new/src/lib/arch/CArch.cpp (working copy)
64+@@ -129,6 +129,8 @@
65+ m_daemon = new ARCH_DAEMON;
66+ m_taskbar = new ARCH_TASKBAR(args);
67+
68++ m_string->initMutex();
69++
70+ #if SYSAPI_WIN32
71+ CArchMiscWindows::init();
72+ #endif
73
74=== modified file 'debian/patches/series'
75--- debian/patches/series 2011-12-04 18:58:04 +0000
76+++ debian/patches/series 2011-12-25 23:49:24 +0000
77@@ -1,1 +1,2 @@
78 gnome3.patch
79+FengYeIArchString-InitMutex.patch

Subscribers

People subscribed via source and target branches

to all changes: