Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unity-theme-icon-provider
Revision history for this message
| Antti Kaijanmäki (kaijanmaki) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
OK, I give up.
There seems to be no way of reliably test the theme icon provider under CI right now.
As all the tests are run with -platform minimal this prevents picking up an actual system theme (which probably is not set properly under Jenkins anyway) and thus preventing loading icons from a system theme (tried to pull in humanity-icon-theme as build-dep for this test).
I also tried to embed a theme as qrc file the same way upstream Qt tests the QIcon::fromTheme() but seems that quick test lib does not load app .qrc files properly so this was a dead end also.
I would either accept this MR as it is or somebody should instruct me how to test this. I'm out of ideas.
Anyone who is interested the test case is available in commit 689. It can be run manually on a standard desktop session and it passes, but as I said I'm unable to get it working with Jenkins environment.