Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unity-theme-icon-provider

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

OK, I have a test now, BUT.

The unit tests are run with -platform minimal and this breaks the QIcon::fromTheme().
The only option I see is to create a .qrc and embed an icon theme there and test with that (as :/ is always added to the search paths. this is actually not documented..)

I'm starting to wonder if it's really worth it to write these tests..

« Back to merge proposal