Ubuntu UI Toolkit

Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/unity-theme-icon-provider

  1. unity-theme-icon-provider
  2. Merge into trunk
Revision history for this message
Lars Karlitski (larsu) wrote :

> 69 + engine->addImageProvider(QLatin1String("theme"), new
> UnityThemeIconProvider);
>
> The same provider is registered in libqmenumodel, is that one going to be
> removed?
>
> Would be nice if someone could fix the conflict too.

I asked about this in #ubuntu-unity the other day and didn't get a clear answer. I think it's easiest if we just make libqmenumodel depend on ubuntu-ui-toolkit and remove its copy of the "theme" provider. I'll propose a merge for that later today.

« Back to merge proposal