Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/ucLabs into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Merged
Approved by: Cris Dywan
Approved revision: 2022
Merged at revision: 2020
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/ucLabs
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 255 lines (+162/-2)
10 files modified
debian/control (+29/-0)
debian/control.gles (+30/-0)
debian/qml-module-ubuntu-components-labs.install (+3/-0)
src/Ubuntu/Components/Components.pro (+2/-1)
src/Ubuntu/Components/Labs/Labs.pro (+10/-0)
src/Ubuntu/Components/Labs/plugin/plugin.cpp (+47/-0)
src/Ubuntu/Components/Labs/plugin/plugin.pri (+8/-0)
src/Ubuntu/Components/Labs/qmldir (+3/-0)
src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.cpp (+21/-1)
src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.h (+9/-0)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/ucLabs
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+298220@code.launchpad.net

Commit message

Separate plugin for Ubuntu.Components.Labs

Description of the change

Separate plugin for Ubuntu.Components.Labs

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks fine.

import Ubuntu.Components.Labs 1.0
ZiObject { }

This works, so I'll consider this acceptable since right now we have nothing useful to test.
I feel we might want to have an .api for it as well, even if we break the API, to track changes, but it seems to require work in apicheck I'd rather not block this on.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
2022. By Cris Dywan

Wrap and sort the control{,.gles} files

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2016-06-03 04:28:05 +0000
+++ debian/control 2016-06-24 13:11:14 +0000
@@ -94,6 +94,35 @@
94 .94 .
95 This package contains the Ubuntu Components QML plugin.95 This package contains the Ubuntu Components QML plugin.
9696
97Package: qml-module-ubuntu-components-labs
98Architecture: any
99Multi-Arch: same
100Pre-Depends: dpkg (>= 1.15.6~),
101 ${misc:Pre-Depends},
102Depends: libqt5svg5,
103 libubuntugestures5 (= ${binary:Version}),
104 libubuntutoolkit5 (= ${binary:Version}),
105 qml-module-qtfeedback,
106 qml-module-qtgraphicaleffects,
107 qml-module-qtquick-layouts,
108 qml-module-qtquick-window2,
109 qml-module-qtquick2,
110 qml-module-ubuntu-performancemetrics,
111 qtdeclarative5-unity-action-plugin (>= 1.1.0),
112 suru-icon-theme,
113 ttf-ubuntu-font-family,
114 ubuntu-ui-toolkit-theme (= ${binary:Version}),
115 ${misc:Depends},
116 ${shlibs:Depends},
117Conflicts: qt-components-ubuntu-labs,
118Replaces: qt-components-ubuntu-labs,
119Provides: qt-components-ubuntu-labs,
120Description: Qt Components Labs for Ubuntu - Components QML plugin
121 Qt Components Labs for Ubuntu offers a set of non-released and mostly
122 unstable user interface components for Qt Quick 2 / QML.
123 .
124 This package contains the Ubuntu Components Labs QML plugin.
125
97Package: qml-module-ubuntu-layouts126Package: qml-module-ubuntu-layouts
98Architecture: any127Architecture: any
99Multi-Arch: same128Multi-Arch: same
100129
=== modified file 'debian/control.gles'
--- debian/control.gles 2016-06-03 06:01:35 +0000
+++ debian/control.gles 2016-06-24 13:11:14 +0000
@@ -114,6 +114,36 @@
114 This package contains the Ubuntu Components QML plugin (built with114 This package contains the Ubuntu Components QML plugin (built with
115 the OpenGLES backend).115 the OpenGLES backend).
116116
117Package: qml-module-ubuntu-components-labs-gles
118Architecture: amd64 i386
119Breaks: qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (<< ${source:Version}),
120Conflicts: qml-module-ubuntu-components-labs,
121Replaces: qml-module-ubuntu-components-labs,
122Provides: qml-module-ubuntu-components-labs,
123Multi-Arch: same
124Pre-Depends: dpkg (>= 1.15.6~),
125 ${misc:Pre-Depends},
126Depends: libqt5svg5,
127 libubuntugestures5-gles (= ${binary:Version}),
128 libubuntutoolkit5-gles (= ${binary:Version}),
129 qml-module-qtfeedback,
130 qml-module-qtgraphicaleffects,
131 qml-module-qtquick-layouts,
132 qml-module-qtquick-window2,
133 qml-module-qtquick2,
134 qtdeclarative5-unity-action-plugin (>= 1.1.0),
135 suru-icon-theme,
136 ttf-ubuntu-font-family,
137 ubuntu-ui-toolkit-theme,
138 ${misc:Depends},
139 ${shlibs:Depends},
140Description: Qt Components Labs for Ubuntu - QML plugin - GLES
141 Qt Components Labs for Ubuntu offers a set of non-released and mostly
142 unstable user interface components for Qt Quick 2 / QML.
143 .
144 This package contains the Ubuntu Components Labs QML plugin (built with
145 the OpenGLES backend).
146
117Package: qml-module-ubuntu-performancemetrics-gles147Package: qml-module-ubuntu-performancemetrics-gles
118Architecture: amd64 i386148Architecture: amd64 i386
119Breaks: qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (<< ${source:Version}),149Breaks: qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (<< ${source:Version}),
120150
=== added file 'debian/qml-module-ubuntu-components-labs.install'
--- debian/qml-module-ubuntu-components-labs.install 1970-01-01 00:00:00 +0000
+++ debian/qml-module-ubuntu-components-labs.install 2016-06-24 13:11:14 +0000
@@ -0,0 +1,3 @@
1usr/lib/*/qt5/qml/Ubuntu/Components/Labs/libUbuntuComponentsLabs.so
2usr/lib/*/qt5/qml/Ubuntu/Components/Labs/plugins.qmltypes
3usr/lib/*/qt5/qml/Ubuntu/Components/Labs/qmldir
04
=== modified file 'src/Ubuntu/Components/Components.pro'
--- src/Ubuntu/Components/Components.pro 2015-05-18 09:53:55 +0000
+++ src/Ubuntu/Components/Components.pro 2016-06-24 13:11:14 +0000
@@ -5,4 +5,5 @@
5 Pickers \5 Pickers \
6 Popups \6 Popups \
7 Styles \7 Styles \
8 Themes8 Themes \
9 Labs
910
=== added directory 'src/Ubuntu/Components/Labs'
=== added file 'src/Ubuntu/Components/Labs/Labs.pro'
--- src/Ubuntu/Components/Labs/Labs.pro 1970-01-01 00:00:00 +0000
+++ src/Ubuntu/Components/Labs/Labs.pro 2016-06-24 13:11:14 +0000
@@ -0,0 +1,10 @@
1CXX_MODULE = qml
2TARGET = UbuntuComponentsLabs
3TARGETPATH = Ubuntu/Components/Labs
4IMPORT_VERSION = 1.0
5
6include(plugin/plugin.pri)
7
8load(ubuntu_qml_plugin)
9
10OTHER_FILES+=qmldir
011
=== added directory 'src/Ubuntu/Components/Labs/plugin'
=== added file 'src/Ubuntu/Components/Labs/plugin/plugin.cpp'
--- src/Ubuntu/Components/Labs/plugin/plugin.cpp 1970-01-01 00:00:00 +0000
+++ src/Ubuntu/Components/Labs/plugin/plugin.cpp 2016-06-24 13:11:14 +0000
@@ -0,0 +1,47 @@
1/*
2 * Copyright 2016 Canonical Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU Lesser General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 *
16 * Author: Zsombor Egri <zsombor.egri@canonical.com>
17 */
18
19#include <QtQml/QQmlExtensionPlugin>
20#include <ubuntutoolkitmodule.h>
21
22class UbuntuComponentsLabsPlugin : public QQmlExtensionPlugin
23{
24 Q_OBJECT
25 Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QQmlExtensionInterface/1.0")
26
27public:
28 void registerTypes(const char *uri) override
29 {
30 Q_ASSERT(uri == QLatin1String("Ubuntu.Components.Labs"));
31 UT_PREPEND_NAMESPACE(UbuntuLabsModule)::defineModule(uri);
32 }
33
34 void initializeEngine(QQmlEngine *engine, const char *uri) override
35 {
36 UT_PREPEND_NAMESPACE(UbuntuLabsModule)::initializeModule(engine, this);
37 QQmlExtensionPlugin::initializeEngine(engine, uri);
38 }
39
40 ~UbuntuComponentsLabsPlugin()
41 {
42 UT_PREPEND_NAMESPACE(UbuntuLabsModule)::undefineModule();
43 }
44};
45
46#include "plugin.moc"
47
048
=== added file 'src/Ubuntu/Components/Labs/plugin/plugin.pri'
--- src/Ubuntu/Components/Labs/plugin/plugin.pri 1970-01-01 00:00:00 +0000
+++ src/Ubuntu/Components/Labs/plugin/plugin.pri 2016-06-24 13:11:14 +0000
@@ -0,0 +1,8 @@
1QT *= qml quick UbuntuToolkit UbuntuToolkit_private
2
3CONFIG += no_keywords c++11
4
5INCLUDEPATH+=$$PWD
6
7SOURCES += \
8 $$PWD/plugin.cpp
09
=== added file 'src/Ubuntu/Components/Labs/qmldir'
--- src/Ubuntu/Components/Labs/qmldir 1970-01-01 00:00:00 +0000
+++ src/Ubuntu/Components/Labs/qmldir 2016-06-24 13:11:14 +0000
@@ -0,0 +1,3 @@
1module Ubuntu.Components.Labs
2plugin UbuntuComponentsLabs
3typeinfo plugins.qmltypes
04
=== modified file 'src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.cpp'
--- src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.cpp 2016-06-23 07:09:59 +0000
+++ src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.cpp 2016-06-24 13:11:14 +0000
@@ -19,6 +19,7 @@
19#include "ubuntutoolkitmodule.h"19#include "ubuntutoolkitmodule.h"
20#include <QtQml/QQmlEngine>20#include <QtQml/QQmlEngine>
21#include <QtQml/QQmlContext>21#include <QtQml/QQmlContext>
22#include <QtQml/QQmlExtensionPlugin>
22#include <QtQuick/private/qquickimagebase_p.h>23#include <QtQuick/private/qquickimagebase_p.h>
23#include <QDBusConnection>24#include <QDBusConnection>
24#include <QtGui/QGuiApplication>25#include <QtGui/QGuiApplication>
@@ -286,6 +287,25 @@
286 // nothing yet287 // nothing yet
287}288}
288289
289290/******************************************************************************
291 * Labs module
292 */
293void UbuntuLabsModule::initializeModule(QQmlEngine *engine, QQmlExtensionPlugin *plugin)
294{
295 Q_UNUSED(engine);
296 Q_UNUSED(plugin);
297}
298
299void UbuntuLabsModule::defineModule(const char *uri)
300{
301 Q_UNUSED(uri);
302 // a fake component so we can have the module types file created
303 qmlRegisterType<QObject>(uri, 1, 0, "ZiObject");
304}
305
306void UbuntuLabsModule::undefineModule()
307{
308 // nothing yet
309}
290310
291UT_NAMESPACE_END311UT_NAMESPACE_END
292312
=== modified file 'src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.h'
--- src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.h 2016-06-23 07:09:59 +0000
+++ src/Ubuntu/UbuntuToolkit/ubuntutoolkitmodule.h 2016-06-24 13:11:14 +0000
@@ -27,6 +27,7 @@
2727
28class QQmlEngine;28class QQmlEngine;
29class QWindow;29class QWindow;
30class QQmlExtensionPlugin;
30/*31/*
31 * Type registration functions.32 * Type registration functions.
32 */33 */
@@ -75,6 +76,14 @@
75 static void undefineModule();76 static void undefineModule();
76};77};
7778
79class UBUNTUTOOLKIT_EXPORT UbuntuLabsModule
80{
81public:
82 static void initializeModule(QQmlEngine *engine, QQmlExtensionPlugin *plugin);
83 static void defineModule(const char *uri);
84 static void undefineModule();
85};
86
78UT_NAMESPACE_END87UT_NAMESPACE_END
7988
80#endif // UBUNTUTOOLKITMODULE_H89#endif // UBUNTUTOOLKITMODULE_H

Subscribers

People subscribed via source and target branches