Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/strokeColor into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Tim Peeters
Approved revision: 1139
Merged at revision: 1168
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/strokeColor
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 534 lines (+223/-103)
14 files modified
components.api (+7/-0)
debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install (+2/-0)
documentation/docs.sh (+2/-2)
examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+10/-0)
modules/Ubuntu/Components/10/10.pro (+9/-0)
modules/Ubuntu/Components/10/Button.qml (+3/-87)
modules/Ubuntu/Components/11/11.pro (+9/-0)
modules/Ubuntu/Components/11/Button.qml (+125/-0)
modules/Ubuntu/Components/Components.pro (+1/-1)
modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml (+41/-8)
modules/Ubuntu/Components/qmldir (+3/-2)
push_to_phone.sh (+1/-1)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py (+2/-1)
tests/qmlapicheck.py (+8/-1)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/strokeColor
Reviewer Review Type Date Requested Status
Tim Peeters Approve
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+223944@code.launchpad.net

Commit message

Implement optional strokeColor in AbstractButton

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

FAIL! : components::TextAreaAPI::test_clear_selection_by_click_beside_selection() 'There is no text selected' returned FALSE. ()
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.47+14.10.20140618bzr1115pkg0utopic1109+autopilot0/tests/unit_x11/tst_components/tst_textarea.qml(718)]

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

FAIL! : components::TextAreaAPI::test_clear_selection_by_click_beside_selection() 'There is no text selected' returned FALSE. ()
   Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.47+14.10.20140618bzr1116pkg0utopic1114+autopilot0/tests/unit_x11/tst_components/tst_textarea.qml(718)]

Revision history for this message
Zsombor Egri (zsombi) wrote :

> FAIL! :
> components::TextAreaAPI::test_clear_selection_by_click_beside_selection()
> 'There is no text selected' returned FALSE. ()
> Loc: [/tmp/buildd/ubuntu-ui-toolkit-0.1.47+14.10.20140618bzr1116pkg0utopic1
> 114+autopilot0/tests/unit_x11/tst_components/tst_textarea.qml(718)]

This is weird... does not fail with staging...

Revision history for this message
Zsombor Egri (zsombi) wrote :

The strokeColor should only be applied to Button, and for version 1.1. ComboButton should also take the Button11 as base type.

review: Needs Fixing
Revision history for this message
Zsombor Egri (zsombi) wrote :

There's one more thing with this: this only configures the stroke colour. Meaning that whoever wants to set a button to be stroke button, must set a colour other than the default value. Do we expect apps to use the

Button {
    strokeColor: UbuntuColors.warmGray
}

setup whenever they want to have a default stroke button? Shouldn't we have a property which sets the defaults?
Button {
   stroke: true
}
This would set the strokeColor to the default one (preferably from Theme.palette than UbuntuColors), but the debs can then configure the strokeColor to whatever they'd like. What do you think?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

We don't really have a "default" as I understand it, the colors I've seen in designs are grey and green, I would assume developers to have a look at the guidelines and make a decision on what's appropriate. That's why there's no "semantic" API but just the color and style.

Revision history for this message
Zsombor Egri (zsombi) wrote :

> We don't really have a "default" as I understand it, the colors I've seen in
> designs are grey and green, I would assume developers to have a look at the
> guidelines and make a decision on what's appropriate. That's why there's no
> "semantic" API but just the color and style.

Completely makes sense!

Implementation looks nice, merge with staging and then we can approve.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

All clear now. Thanks for the update!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-autolanding/204/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1245
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1101
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-autolanding/148
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-autolanding/148
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-autolanding/148/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-autolanding/148
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1571
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2130
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2130/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8890
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/909
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1244
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1244/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1119
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/489/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1270
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/321
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/321
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/321/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/321
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1588
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2164
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2164/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8916
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/924
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1263
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1263/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/489/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1120
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/495/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1284
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1131
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/327
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/327
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/327/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/327
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1602
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2184
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2184/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8937
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/934
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1274
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1274/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/495/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1121
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/512/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1350
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1181
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/344
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/344
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/344/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/344
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1658
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2274
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2274/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9022
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/974
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1324
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1324/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/512/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1122
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/533/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1456
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1253
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/365
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/365
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/365/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/365
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1746
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2423
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2423/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9151
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1033
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1401
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1401/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/533/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1125
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/572/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1787/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1504
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/404
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/404
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/404/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/404
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2050/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2859
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2859/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9596
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1259
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1691
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1691/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/572/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-autolanding/239/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1878
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1570
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-autolanding/183
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-autolanding/183
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-autolanding/183/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-autolanding/183
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2134
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2975
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2975/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9710
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1315
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1760
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1760/artifact/work/output/*zip*/output.zip

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1126
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/589/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1938
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1616
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/421
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/421/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/421
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2186
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3050
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3050/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9783
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1352
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1819
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1819/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/589/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Looks like tests are failing because for autopilot the buttons are no longer of type Button, so stuff like this fails:

        hide_actions_button = self.main_view.select_single(
            'Button',
            objectName='hide_actions_button')

I guess they are now Button11 (for 1.1, but when fixing the tests we should also verify that they still work when using 1.0).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1127
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/591/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1975
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1657
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/423
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/423
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/423/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/423
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2218
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3090
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3090/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9822
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1388
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1861
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1861/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/591/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

QUbuntu: Could not create application instance
ProcessSearchError: Process exited with exit code: -6

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1128. By Cris Dywan

Move versioned Button classes to subfolders

This avoids Autopilot unintentionally changing class names
And restore specifying of Button classes in Autopilot

1129. By Cris Dywan

Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging

1130. By Cris Dywan

Get un/versioned files in the same order in components.api

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

qdoc doesn't like it:

tim@C720:~/dev/ubuntu-ui-toolkit/r/strokeColor$ make docs
SRC=. ./documentation/docs.sh /home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/documentation;
/home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/modules/Ubuntu/Components/Action.qml:20: warning: Can't link to 'Button'
/home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/modules/Ubuntu/Components/Colors/UbuntuColors.qml:81: warning: Can't link to 'Button::gradient'
/home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/modules/Ubuntu/Components/Colors/UbuntuColors.qml:72: warning: Can't link to 'Button::gradient'
/home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/modules/Ubuntu/Components/Popups/Dialog.qml:98: warning: Can't link to 'Button'
/home/tim/dev/ubuntu-ui-toolkit/r/strokeColor/modules/Ubuntu/Components/Popups/Popover.qml:112: warning: Can't link to 'Button'
make: *** [docs] Error 1

Revision history for this message
Tim Peeters (tpeeters) :
review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1131. By Cris Dywan

Move around Button11.qdoc in an attempt to please qdoc

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1132. By Cris Dywan

Move all Button docs into Button.qdoc and mark the real ones as internal

1133. By Cris Dywan

Use correct Button parent class

Revision history for this message
Cris Dywan (kalikiana) wrote :

My last changes make it *build* alas the docs don't include any properties and there's non-working "Button" links. This is as good as it will get, I can't find a way to make it work.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1134. By Cris Dywan

Make pep8 happy

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1134
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/658/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2428/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1977
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/490
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/490
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/490/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/490
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2597/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3660
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3660/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10342
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1655
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2227
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2227/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/658/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Note to self: push_to_phone.sh doesn't push 1.1/Button.qml

1135. By Cris Dywan

Also push the versioned 10 and 11 folders to the phone

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1135
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/663/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2496/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2018
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/495
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/495
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/495/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/495
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2648/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3739
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3739/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10419
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1688
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2271
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2271/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/663/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

10/ and 11/ also need to be added to debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install

review: Needs Fixing
1136. By Cris Dywan

Add folders 10 and 11 to qtdeclarative5-ubuntu-ui-toolkit-plugin.install

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1137. By Cris Dywan

Add .pro files for 10 and 11 folders

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1137
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/669/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2584
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2066
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/501
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/501/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/501
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3827
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3827/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10540
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1730
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2319
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2319/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/669/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

It appears like I finally found a solution for the problems with qdoc and AP: duplicate the Button API in 10/Button and 11/Button instead of making 11/Button inherit from 10/Button. See https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/strokeColorFix

1138. By Cris Dywan

Merge lp:~tpeeters/ubuntu-ui-toolkit/strokeColorFix

1139. By Cris Dywan

Drop docs from 10/Button.qml which are redundant now

Revision history for this message
Tim Peeters (tpeeters) wrote :

hurray :) let's hope this is it!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'components.api'
--- components.api 2014-07-21 13:57:13 +0000
+++ components.api 2014-07-29 14:43:30 +0000
@@ -33,6 +33,13 @@
33 property Gradient gradient33 property Gradient gradient
34 property font font34 property font font
35 property string iconPosition35 property string iconPosition
36Button 1.1
37AbstractButton
38 property color strokeColor
39 property color color
40 property Gradient gradient
41 property font font
42 property string iconPosition
36CheckBox 0.1 1.043CheckBox 0.1 1.0
37AbstractButton44AbstractButton
38 property bool checked45 property bool checked
3946
=== modified file 'debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install'
--- debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install 2014-04-29 12:50:32 +0000
+++ debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install 2014-07-29 14:43:30 +0000
@@ -6,6 +6,8 @@
6usr/lib/*/qt5/qml/Ubuntu/Layouts/plugins.qmltypes6usr/lib/*/qt5/qml/Ubuntu/Layouts/plugins.qmltypes
7usr/lib/*/qt5/qml/Ubuntu/Layouts/libUbuntuLayouts.so7usr/lib/*/qt5/qml/Ubuntu/Layouts/libUbuntuLayouts.so
8usr/lib/*/qt5/qml/Ubuntu/Components/*.qml8usr/lib/*/qt5/qml/Ubuntu/Components/*.qml
9usr/lib/*/qt5/qml/Ubuntu/Components/10/*.qml
10usr/lib/*/qt5/qml/Ubuntu/Components/11/*.qml
9usr/lib/*/qt5/qml/Ubuntu/Components/*.js11usr/lib/*/qt5/qml/Ubuntu/Components/*.js
10usr/lib/*/qt5/qml/Ubuntu/Components/qmldir12usr/lib/*/qt5/qml/Ubuntu/Components/qmldir
11usr/lib/*/qt5/qml/Ubuntu/Components/plugins.qmltypes13usr/lib/*/qt5/qml/Ubuntu/Components/plugins.qmltypes
1214
=== modified file 'documentation/docs.sh'
--- documentation/docs.sh 2014-03-27 08:59:19 +0000
+++ documentation/docs.sh 2014-07-29 14:43:30 +0000
@@ -24,7 +24,7 @@
24# Offline docs for QtCreator24# Offline docs for QtCreator
25qdoc $DOC_PATH/ubuntu-ui-toolkit-qtcreator.qdocconf 2> $DOC_PATH/qdoc.log25qdoc $DOC_PATH/ubuntu-ui-toolkit-qtcreator.qdocconf 2> $DOC_PATH/qdoc.log
26# FIXME: With Qt 5.2 this warning shows up, forcibly omit it from errors26# FIXME: With Qt 5.2 this warning shows up, forcibly omit it from errors
27cat $DOC_PATH/qdoc.log | grep -v "qdoc: warning: No documentation for 'global'" > $DOC_PATH/qdoc.err27grep -v "error: HTML file already exists; overwriting" $DOC_PATH/qdoc.log | grep -v "qdoc: warning: No documentation for 'global'" > $DOC_PATH/qdoc.err
28cat $DOC_PATH/qdoc.err28cat $DOC_PATH/qdoc.err
29test ! -s $DOC_PATH/qdoc.err || exit 129test ! -s $DOC_PATH/qdoc.err || exit 1
30echo docs: Offline done.30echo docs: Offline done.
@@ -35,7 +35,7 @@
35# Online docs. Run qdoc twice: the second run with indexes for cross-referencing35# Online docs. Run qdoc twice: the second run with indexes for cross-referencing
36# other APIs but discard errors because qdoc inherits all doc bugs otherwise36# other APIs but discard errors because qdoc inherits all doc bugs otherwise
37qdoc $DOC_PATH/ubuntu-ui-toolkit-online.qdocconf 2> $DOC_PATH/qdoc.log37qdoc $DOC_PATH/ubuntu-ui-toolkit-online.qdocconf 2> $DOC_PATH/qdoc.log
38cat $DOC_PATH/qdoc.log | grep -v "qdoc: warning: No documentation for 'global'" > $DOC_PATH/qdoc.err38grep -v "error: HTML file already exists; overwriting" $DOC_PATH/qdoc.log | grep -v "qdoc: warning: No documentation for 'global'" > $DOC_PATH/qdoc.err
39cat $DOC_PATH/qdoc.err39cat $DOC_PATH/qdoc.err
40test ! -s $DOC_PATH/qdoc.err || exit 140test ! -s $DOC_PATH/qdoc.err || exit 1
41echo docs: Online done.41echo docs: Online done.
4242
=== modified file 'examples/ubuntu-ui-toolkit-gallery/Buttons.qml'
--- examples/ubuntu-ui-toolkit-gallery/Buttons.qml 2014-04-23 09:39:11 +0000
+++ examples/ubuntu-ui-toolkit-gallery/Buttons.qml 2014-07-29 14:43:30 +0000
@@ -34,6 +34,16 @@
34 }34 }
3535
36 TemplateRow {36 TemplateRow {
37 title: i18n.tr("Stroke")
38
39 Button {
40 objectName: "button_stroke"
41 text: i18n.tr("Call")
42 strokeColor: UbuntuColors.warmGrey
43 }
44 }
45
46 TemplateRow {
37 title: i18n.tr("Color")47 title: i18n.tr("Color")
3848
39 Button {49 Button {
4050
=== added directory 'modules/Ubuntu/Components/10'
=== added file 'modules/Ubuntu/Components/10/10.pro'
--- modules/Ubuntu/Components/10/10.pro 1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/10/10.pro 2014-07-29 14:43:30 +0000
@@ -0,0 +1,9 @@
1TEMPLATE = subdirs
2
3uri = Ubuntu.Components.10
4installPath = $$[QT_INSTALL_QML]/$$replace(uri, \\., /)
5
6qml_files.path = $$installPath
7qml_files.files = *.qml
8
9INSTALLS += qml_files
010
=== renamed file 'modules/Ubuntu/Components/Button.qml' => 'modules/Ubuntu/Components/10/Button.qml'
--- modules/Ubuntu/Components/Button.qml 2014-04-23 08:50:20 +0000
+++ modules/Ubuntu/Components/10/Button.qml 2014-07-29 14:43:30 +0000
@@ -15,105 +15,21 @@
15 */15 */
1616
17import QtQuick 2.017import QtQuick 2.0
18import Ubuntu.Components 1.0
1819
19/*!20/*!
20 \qmltype Button21 \internal
21 \inqmlmodule Ubuntu.Components 1.122 Documentation in 11/Button.qml
22 \ingroup ubuntu
23 \brief Standard Ubuntu button.
24
25 \l {http://design.ubuntu.com/apps/building-blocks/buttons}{See also the Design Guidelines on Buttons}.
26
27 Examples:
28 \qml
29 Column {
30 Button {
31 text: "Send"
32 onClicked: print("clicked text-only Button")
33 }
34 Button {
35 iconName: "compose"
36 gradient: UbuntuColors.greyGradient
37 onClicked: print("clicked icon-only Button")
38 }
39 Button {
40 iconName: "compose"
41 text: "Icon on left"
42 iconPosition: "left"
43 onClicked: print("clicked text and icon Button")
44 }
45 }
46 \endqml
47 An \l Action can be used to specify \b clicked, iconSource and text. Example:
48 \qml
49 Item {
50 Action {
51 id: action1
52 text: "Click me"
53 onTriggered: print("action!")
54 iconName: "compose"
55 }
56 Button {
57 anchors.centerIn: parent
58 action: action1
59 color: UbuntuColors.warmGrey
60 }
61 }
62 \endqml
63*/23*/
64AbstractButton {24AbstractButton {
65 id: button25 id: button
6626
67 /*!
68 The background color of the button.
69
70 \sa gradient
71 */
72 property color color: __styleInstance.defaultColor27 property color color: __styleInstance.defaultColor
7328
74 /*!
75 The gradient used to fill the background of the button.
76
77 Standard Ubuntu gradients are defined in \l UbuntuColors.
78
79 If both a gradient and a color are specified, the gradient will be used.
80
81 \sa color
82 */
83 property Gradient gradient: __styleInstance.defaultGradient29 property Gradient gradient: __styleInstance.defaultGradient
8430
85 /*!
86 The font used for the button's text.
87 */
88 property font font: __styleInstance ? __styleInstance.defaultFont : Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")})31 property font font: __styleInstance ? __styleInstance.defaultFont : Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")})
8932
90 /*!
91 The source URL of the icon to display inside the button.
92 Leave this value blank for a text-only button.
93 If \l action is set, the default iconSource is that of the action.
94 \qmlproperty url iconSource
95 */
96
97 /*!
98 The text to display in the button. If an icon was defined,
99 the text will be shown next to the icon, otherwise it will
100 be centered. Leave blank for an icon-only button.
101 If \l action is set, the default text is that of the action.
102 \qmlproperty string text
103 */
104
105 /*!
106 The position of the icon relative to the text. Options
107 are "left" and "right". The default value is "left".
108
109 If only text or only an icon is defined, this
110 property is ignored and the text or icon is
111 centered horizontally and vertically in the button.
112
113 Currently this is a string value. We are waiting for
114 support for enums:
115 https://bugreports.qt-project.org/browse/QTBUG-14861
116 */
117 property string iconPosition: "left"33 property string iconPosition: "left"
11834
119 style: Theme.createStyleComponent("ButtonStyle.qml", button)35 style: Theme.createStyleComponent("ButtonStyle.qml", button)
12036
=== added directory 'modules/Ubuntu/Components/11'
=== added file 'modules/Ubuntu/Components/11/11.pro'
--- modules/Ubuntu/Components/11/11.pro 1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/11/11.pro 2014-07-29 14:43:30 +0000
@@ -0,0 +1,9 @@
1TEMPLATE = subdirs
2
3uri = Ubuntu.Components.11
4installPath = $$[QT_INSTALL_QML]/$$replace(uri, \\., /)
5
6qml_files.path = $$installPath
7qml_files.files = *.qml
8
9INSTALLS += qml_files
010
=== added file 'modules/Ubuntu/Components/11/Button.qml'
--- modules/Ubuntu/Components/11/Button.qml 1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/11/Button.qml 2014-07-29 14:43:30 +0000
@@ -0,0 +1,125 @@
1/*
2 * Copyright 2014 Canonical Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU Lesser General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.2
18import Ubuntu.Components 1.1
19
20/*!
21 \qmltype Button
22 \inqmlmodule Ubuntu.Components 1.1
23 \ingroup ubuntu
24 \brief Standard Ubuntu button.
25
26 \l {http://design.ubuntu.com/apps/building-blocks/buttons}{See also the Design Guidelines on Buttons}.
27
28 Examples:
29 \qml
30 Column {
31 Button {
32 text: "Send"
33 onClicked: print("clicked text-only Button")
34 }
35 Button {
36 iconName: "compose"
37 gradient: UbuntuColors.greyGradient
38 onClicked: print("clicked icon-only Button")
39 }
40 Button {
41 iconName: "compose"
42 text: "Icon on left"
43 iconPosition: "left"
44 onClicked: print("clicked text and icon Button")
45 }
46 }
47 \endqml
48 An \l Action can be used to specify \b clicked, iconSource and text. Example:
49 \qml
50 Item {
51 Action {
52 id: action1
53 text: "Click me"
54 onTriggered: print("action!")
55 iconName: "compose"
56 }
57 Button {
58 anchors.centerIn: parent
59 action: action1
60 color: UbuntuColors.warmGrey
61 }
62 }
63 \endqml*/
64AbstractButton {
65 id: button
66 /*!
67 \since Ubuntu.Components 1.1
68 If set to a color, the button has a stroke border instead of a filled shape.
69 */
70 property color strokeColor: Qt.rgba(0.0, 0.0, 0.0, 0.0)
71
72 /*!
73 \qmlproperty url Button::iconSource
74 The source URL of the icon to display inside the button.
75 Leave this value blank for a text-only button.
76 If \l action is set, the default iconSource is that of the action.
77 */
78
79 /*!
80 The text to display in the button. If an icon was defined,
81 the text will be shown next to the icon, otherwise it will
82 be centered. Leave blank for an icon-only button.
83 If \l action is set, the default text is that of the action.
84 \qmlproperty string Button::text
85 */
86
87 /*!
88 The background color of the button.
89
90 \sa gradient
91 */
92 property color color: __styleInstance.defaultColor
93
94 /*!
95 The gradient used to fill the background of the button.
96
97 Standard Ubuntu gradients are defined in \l UbuntuColors.
98
99 If both a gradient and a color are specified, the gradient will be used.
100
101 \sa color
102 */
103 property Gradient gradient: __styleInstance.defaultGradient
104
105 /*!
106 The font used for the button's text.
107 */
108 property font font: __styleInstance ? __styleInstance.defaultFont : Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")})
109
110 /*!
111 The position of the icon relative to the text. Options
112 are "left" and "right". The default value is "left".
113
114 If only text or only an icon is defined, this
115 property is ignored and the text or icon is
116 centered horizontally and vertically in the button.
117
118 Currently this is a string value. We are waiting for
119 support for enums:
120 https://bugreports.qt-project.org/browse/QTBUG-14861
121 */
122 property string iconPosition: "left"
123
124 style: Theme.createStyleComponent("ButtonStyle.qml", button)
125}
0126
=== modified file 'modules/Ubuntu/Components/Components.pro'
--- modules/Ubuntu/Components/Components.pro 2013-07-01 05:54:33 +0000
+++ modules/Ubuntu/Components/Components.pro 2014-07-29 14:43:30 +0000
@@ -1,5 +1,5 @@
1TEMPLATE = subdirs1TEMPLATE = subdirs
22
3SUBDIRS += plugin Themes Colors3SUBDIRS += plugin Themes Colors 10 11
44
5include(deployment.pri)5include(deployment.pri)
66
=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml'
--- modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml 2014-04-23 08:50:20 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml 2014-07-29 14:43:30 +0000
@@ -22,13 +22,14 @@
22Item {22Item {
23 id: buttonStyle23 id: buttonStyle
2424
25 property Button button: styledItem25 property var button: styledItem
26 property real minimumWidth: units.gu(10)26 property real minimumWidth: units.gu(10)
27 property real horizontalPadding: units.gu(1)27 property real horizontalPadding: units.gu(1)
28 property color defaultColor: UbuntuColors.orange28 property color defaultColor: UbuntuColors.orange
29 property font defaultFont: Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")})29 property font defaultFont: Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")})
30 property Gradient defaultGradient30 property Gradient defaultGradient
31 property real buttonFaceOffset: 031 property real buttonFaceOffset: 0
32 property bool stroke: button.hasOwnProperty("strokeColor") && button.strokeColor != Qt.rgba(0.0, 0.0, 0.0, 0.0)
32 /*!33 /*!
33 The property overrides the button's default background with an item. This34 The property overrides the button's default background with an item. This
34 item can be used by derived styles to reuse the ButtonStyle and override35 item can be used by derived styles to reuse the ButtonStyle and override
@@ -82,22 +83,54 @@
82 property bool isGradient: button.gradient && (button.color == defaultColor ||83 property bool isGradient: button.gradient && (button.color == defaultColor ||
83 button.gradient != defaultGradient)84 button.gradient != defaultGradient)
8485
86 Image {
87 id: strokeBorder
88 anchors.fill: parent
89 anchors.margins: -units.gu(0.5)
90 source: "artwork/stroke_button.png"
91 visible: false
92 }
93
94 ShaderEffect {
95 id: colorizedImage
96
97 anchors.fill: parent
98 visible: stroke && strokeBorder.status == Image.Ready
99
100 property Item source: visible ? strokeBorder : null
101 property color keyColorOut: stroke ? strokeColor : Qt.rgba(0.0, 0.0, 0.0, 0.0)
102 property color keyColorIn: Qt.rgba(1.0, 1.0, 1.0, 1.0)
103 property real threshold: 1.0
104
105 fragmentShader: "
106 varying highp vec2 qt_TexCoord0;
107 uniform sampler2D source;
108 uniform highp vec4 keyColorOut;
109 uniform highp vec4 keyColorIn;
110 uniform lowp float threshold;
111 uniform lowp float qt_Opacity;
112 void main() {
113 lowp vec4 sourceColor = texture2D(source, qt_TexCoord0);
114 gl_FragColor = mix(vec4(keyColorOut.rgb, 1.0) * sourceColor.a, sourceColor, step(threshold, distance(sourceColor.rgb / sourceColor.a, keyColorIn.rgb))) * qt_Opacity;
115 }"
116 }
117
85 UbuntuShape {118 UbuntuShape {
86 id: background119 id: background
87 anchors.fill: parent120 anchors.fill: parent
88 borderSource: "radius_idle.sci"121 borderSource: "radius_idle.sci"
89 visible: (color.a != 0.0) || backgroundSource122 visible: stroke ? false : ((color.a != 0.0) || backgroundSource)
90 image: backgroundSource123 image: backgroundSource
91124
92 color: backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.topColor) : __colorHack(button.color))125 color: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.topColor) : __colorHack(button.color)))
93 gradientColor: backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.bottomColor) : __colorHack(button.color))126 gradientColor: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.bottomColor) : __colorHack(button.color)))
94 }127 }
95128
96 UbuntuShape {129 UbuntuShape {
97 id: backgroundPressed130 id: backgroundPressed
98 anchors.fill: parent131 anchors.fill: parent
99 color: background.color132 color: stroke ? strokeColor : background.color
100 gradientColor: background.gradientColor133 gradientColor: stroke ? strokeColor : background.gradientColor
101 borderSource: "radius_pressed.sci"134 borderSource: "radius_pressed.sci"
102 opacity: button.pressed ? 1.0 : 0.0135 opacity: button.pressed ? 1.0 : 0.0
103 Behavior on opacity {136 Behavior on opacity {
@@ -106,7 +139,7 @@
106 easing.type: Easing.Linear139 easing.type: Easing.Linear
107 }140 }
108 }141 }
109 visible: background.visible142 visible: stroke || background.visible
110 }143 }
111144
112 ButtonForeground {145 ButtonForeground {
@@ -120,7 +153,7 @@
120 /* Pick either a clear or dark text color depending on the luminance of the153 /* Pick either a clear or dark text color depending on the luminance of the
121 background color to maintain good contrast (works in most cases)154 background color to maintain good contrast (works in most cases)
122 */155 */
123 textColor: ColorUtils.luminance(button.color) <= 0.85 ? "#F3F3E7" : "#888888"156 textColor: ColorUtils.luminance(button.color) <= 0.85 && !(stroke && !pressed) ? "#F3F3E7" : "#888888"
124 iconSource: button.iconSource157 iconSource: button.iconSource
125 iconPosition: button.iconPosition158 iconPosition: button.iconPosition
126 iconSize: units.gu(3)159 iconSize: units.gu(3)
127160
=== added file 'modules/Ubuntu/Components/Themes/Ambiance/artwork/stroke_button@27.png'
128Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/stroke_button@27.png 1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/stroke_button@27.png 2014-07-29 14:43:30 +0000 differ161Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/stroke_button@27.png 1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/stroke_button@27.png 2014-07-29 14:43:30 +0000 differ
=== modified file 'modules/Ubuntu/Components/qmldir'
--- modules/Ubuntu/Components/qmldir 2014-07-16 11:58:43 +0000
+++ modules/Ubuntu/Components/qmldir 2014-07-29 14:43:30 +0000
@@ -6,7 +6,7 @@
6ToolbarItems 0.1 ToolbarItems.qml6ToolbarItems 0.1 ToolbarItems.qml
7ToolbarButton 0.1 ToolbarButton.qml7ToolbarButton 0.1 ToolbarButton.qml
8MainView 0.1 MainView.qml8MainView 0.1 MainView.qml
9Button 0.1 Button.qml9Button 0.1 10/Button.qml
10Panel 0.1 Panel.qml10Panel 0.1 Panel.qml
11internal DraggingArea DraggingArea.qml11internal DraggingArea DraggingArea.qml
12Tab 0.1 Tab.qml12Tab 0.1 Tab.qml
@@ -57,7 +57,7 @@
57ToolbarItems 1.0 ToolbarItems.qml57ToolbarItems 1.0 ToolbarItems.qml
58ToolbarButton 1.0 ToolbarButton.qml58ToolbarButton 1.0 ToolbarButton.qml
59MainView 1.0 MainView.qml59MainView 1.0 MainView.qml
60Button 1.0 Button.qml60Button 1.0 10/Button.qml
61Panel 1.0 Panel.qml61Panel 1.0 Panel.qml
62Tab 1.0 Tab.qml62Tab 1.0 Tab.qml
63TabBar 1.0 TabBar.qml63TabBar 1.0 TabBar.qml
@@ -93,6 +93,7 @@
9393
94#version 1.194#version 1.1
95ComboButton 1.1 ComboButton.qml95ComboButton 1.1 ComboButton.qml
96Button 1.1 11/Button.qml
96ProgressBar 1.1 ProgressBar11.qml97ProgressBar 1.1 ProgressBar11.qml
97CrossFadeImage 1.1 CrossFadeImage11.qml98CrossFadeImage 1.1 CrossFadeImage11.qml
98PullToRefresh 1.1 PullToRefresh.qml99PullToRefresh 1.1 PullToRefresh.qml
99100
=== modified file 'push_to_phone.sh'
--- push_to_phone.sh 2014-07-22 10:47:35 +0000
+++ push_to_phone.sh 2014-07-29 14:43:30 +0000
@@ -33,7 +33,7 @@
33echo modules/Ubuntu/Components/qmldir '->' /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/33echo modules/Ubuntu/Components/qmldir '->' /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/
34adb push Ubuntu/Components/qmldir /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/34adb push Ubuntu/Components/qmldir /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/
35cd ..35cd ..
36for i in ListItems Pickers Popups Colors Styles Themes artwork; do36for i in 10 11 ListItems Pickers Popups Colors Styles Themes artwork; do
37 adb push modules/Ubuntu/Components/$i/ /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/$i || exit 137 adb push modules/Ubuntu/Components/$i/ /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/$i || exit 1
38done38done
39# Autopilot tests should always match the Toolkit39# Autopilot tests should always match the Toolkit
4040
=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py'
--- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py 2014-04-25 16:49:45 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_main_view.py 2014-07-29 14:43:30 +0000
@@ -134,7 +134,8 @@
134134
135 def _go_to_page1(self):135 def _go_to_page1(self):
136 button = self.main_view.select_single(136 button = self.main_view.select_single(
137 'Button', objectName='go_to_page1')137 'Button',
138 objectName='go_to_page1')
138 self.pointing_device.click_object(button)139 self.pointing_device.click_object(button)
139140
140 def test_go_back(self):141 def test_go_back(self):
141142
=== modified file 'tests/qmlapicheck.py'
--- tests/qmlapicheck.py 2014-07-18 15:58:50 +0000
+++ tests/qmlapicheck.py 2014-07-29 14:43:30 +0000
@@ -74,7 +74,14 @@
74 inputfiles.append(fileinput.filename())74 inputfiles.append(fileinput.filename())
75 fileinput.nextfile()75 fileinput.nextfile()
7676
77inputfiles.sort()77
78# Sort filenames to maintain a consistent order
79# Get un/versioned files in the same order
80def skipversion(filename):
81 for v in ['10', '11']:
82 filename = filename.replace(v + '/', '')
83 return filename
84inputfiles.sort(key=skipversion)
7885
79hook = fileinput.hook_encoded('utf-8')86hook = fileinput.hook_encoded('utf-8')
80for line in fileinput.input(inputfiles, openhook=hook):87for line in fileinput.input(inputfiles, openhook=hook):

Subscribers

People subscribed via source and target branches