Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedWindow

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

We noticed that this MR breaks messaging-app and maybe other apps.
organizationName is used by QSettings to build the configuration file path.

In messaging-app we set the organizationName in the cpp code even before the MainView is loaded.
That makes the app create directories like $HOME/.config/Unknown Organization/MessagingApp, which didn't happen before.

We are probably hitting this case:
https://github.com/qt/qtbase/blob/dev/src/corelib/io/qsettings.cpp#L1138

We can certainly set that property on the MainView from now on to avoid running into this problem, but I wonder if other apps that also depend on QSettings (or Settings qml component from qt-labs-settings) wont break.

« Back to merge proposal