Code review comment for lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/navi

Revision history for this message
David Planella (dpm) wrote :

As requested by Christian, here's the feedback after reviewing. Here are the existing known issues:

1) Breadcrumbs appear reversed: http://people.canonical.com/~dpm/sdk-docs/html/theming-components.html
2) Last breadcrumb missing: http://people.canonical.com/~dpm/sdk-docs/html/qmlmodule-ubuntu-components0-ubuntu-components-0-1.html
5) Duplicate breadcrumbs in http://people.canonical.com/~dpm/sdk-docs/html/qmlmodule-ubuntu-components0-ubuntu-components-0-1.html

And here is one I've noticed was fixed but then manifested in a different way:

4) Inconsistent navigation

The root page is called "Overview" in the breadcrumbs:
http://people.canonical.com/~dpm/sdk-docs/html/resolution-independence.html

But on the root page itself, it's called "Ubuntu User Interface Toolkit" in the breadcrumbs:
http://people.canonical.com/~dpm/sdk-docs/html/overview-ubuntu-sdk.html

I'd recommend settling on one of the two (either "Overview" or "Ubuntu User Interface Toolkit") and use it throughout the docs.

« Back to merge proposal