Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/clipScrollbar into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Merge reported by: Cris Dywan
Merged at revision: not available
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/clipScrollbar
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 91 lines (+43/-4)
4 files modified
src/Ubuntu/Components/1.3/TextArea.qml (+3/-4)
src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml (+6/-0)
tests/unit/performance/TextArea13Grid.qml (+33/-0)
tests/unit/performance/tst_performance.cpp (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/clipScrollbar
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Needs Fixing
Loïc Molinari (community) Approve
Review via email: mp+296551@code.launchpad.net

Commit message

Put Scrollbar in ShaderEffectSource to blend with frame

Description of the change

Performance seems to be the same if not a tad faster.

Before
0.018 msecs per iteration (total: 75, iterations: 4096)
0.018 msecs per iteration (total: 76, iterations: 4096)
0.018 msecs per iteration (total: 77, iterations: 4096)
0.018 msecs per iteration (total: 75, iterations: 4096)
After
0.018 msecs per iteration (total: 76, iterations: 4096)
0.017 msecs per iteration (total: 72, iterations: 4096)
0.018 msecs per iteration (total: 76, iterations: 4096)
0.018 msecs per iteration (total: 75, iterations: 4096)

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Easy! Looks good to me.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Ubuntu/Components/1.3/TextArea.qml'
--- src/Ubuntu/Components/1.3/TextArea.qml 2016-05-25 12:48:10 +0000
+++ src/Ubuntu/Components/1.3/TextArea.qml 2016-06-06 14:07:38 +0000
@@ -875,6 +875,9 @@
875 }875 }
876 }876 }
877 }877 }
878
879 /*! \internal */
880 property Item __rightScrollbar: rightScrollbar
878 Scrollbar {881 Scrollbar {
879 id: rightScrollbar882 id: rightScrollbar
880 flickableItem: flicker883 flickableItem: flicker
@@ -884,10 +887,6 @@
884 anchors.topMargin: -internal.frameSpacing887 anchors.topMargin: -internal.frameSpacing
885 anchors.rightMargin: -internal.frameSpacing888 anchors.rightMargin: -internal.frameSpacing
886 anchors.bottomMargin: -internal.frameSpacing889 anchors.bottomMargin: -internal.frameSpacing
887 Ubuntu.StyleHints {
888 // No background color
889 troughColorSteppersStyle: Qt.rgba(0, 0, 0, 0)
890 }
891 }890 }
892891
893 styleName: "TextAreaStyle"892 styleName: "TextAreaStyle"
894893
=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml'
--- src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml 2016-05-10 12:08:32 +0000
+++ src/Ubuntu/Components/Themes/Ambiance/1.3/TextAreaStyle.qml 2016-06-06 14:07:38 +0000
@@ -76,6 +76,12 @@
76 radius: units.gu(1.7)76 radius: units.gu(1.7)
77 backgroundColor: visuals.backgroundColor77 backgroundColor: visuals.backgroundColor
78 aspect: UbuntuShape.Flat78 aspect: UbuntuShape.Flat
79 source: ShaderEffectSource {
80 sourceItem: styledItem.__rightScrollbar ? styledItem.__rightScrollbar : null
81 hideSource: true
82 }
83 sourceFillMode: UbuntuShape.Pad
84 sourceHorizontalAlignment: UbuntuShape.AlignRight
79 }85 }
80 }86 }
8187
8288
=== added file 'tests/unit/performance/TextArea13Grid.qml'
--- tests/unit/performance/TextArea13Grid.qml 1970-01-01 00:00:00 +0000
+++ tests/unit/performance/TextArea13Grid.qml 2016-06-06 14:07:38 +0000
@@ -0,0 +1,33 @@
1/*
2 * Copyright 2016 Canonical Ltd.
3 *
4 * This program is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU Lesser General Public License as published by
6 * the Free Software Foundation; version 3.
7 *
8 * This program is distributed in the hope that it will be useful,
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 * GNU Lesser General Public License for more details.
12 *
13 * You should have received a copy of the GNU Lesser General Public License
14 * along with this program. If not, see <http://www.gnu.org/licenses/>.
15 */
16
17import QtQuick 2.0
18import Ubuntu.Components 1.3
19
20Grid {
21 width: units.gu(80)
22 height: units.gu(60)
23 rows: 16
24 columns: 16
25
26 Repeater {
27 model: 16 * 16
28
29 TextField {
30 text: i18n.tr("Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.")
31 }
32 }
33}
034
=== modified file 'tests/unit/performance/tst_performance.cpp'
--- tests/unit/performance/tst_performance.cpp 2015-12-07 22:16:52 +0000
+++ tests/unit/performance/tst_performance.cpp 2016-06-06 14:07:38 +0000
@@ -102,6 +102,7 @@
102 QTest::addColumn<QString>("document");102 QTest::addColumn<QString>("document");
103 QTest::addColumn<QUrl>("theme");103 QTest::addColumn<QUrl>("theme");
104104
105 QTest::newRow("TextArea 1.3") << "TextArea13Grid.qml" << QUrl();
105 QTest::newRow("AbstractButton 1.2") << "AbstractButtonGrid.qml" << QUrl();106 QTest::newRow("AbstractButton 1.2") << "AbstractButtonGrid.qml" << QUrl();
106 QTest::newRow("AbstractButton 1.3") << "AbstractButton13Grid.qml" << QUrl();107 QTest::newRow("AbstractButton 1.3") << "AbstractButton13Grid.qml" << QUrl();
107 QTest::newRow("grid with Rectangle") << "RectangleGrid.qml" << QUrl();108 QTest::newRow("grid with Rectangle") << "RectangleGrid.qml" << QUrl();

Subscribers

People subscribed via source and target branches