Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/buildWarnings into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 2061
Merged at revision: 2063
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/buildWarnings
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 107 lines (+7/-20)
7 files modified
app-launch-profiler/app-launch-profiler.pro (+1/-0)
app-launch-profiler/app-launch-tracepoints.c (+2/-0)
src/Ubuntu/UbuntuToolkit/sortfiltermodel.cpp (+1/-11)
src/Ubuntu/UbuntuToolkit/sortfiltermodel_p.h (+0/-1)
src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp (+1/-1)
tests/unit/alarms/tst_alarms.cpp (+1/-2)
tests/unit/page/tst_page.cpp (+1/-5)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/buildWarnings
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+303004@code.launchpad.net

Commit message

Fix build warnings

Description of the change

./src/Ubuntu/UbuntuToolkit/sortfiltermodel_p.h:48:38 error: non-virtual member function marked override hides virtual function
 QVariant data(int row, int role) override;
 ^

./src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp:1112:31 error: constexpr function never produces a constant expression [-Winvalid-constexpr]
static Q_DECL_CONSTEXPR float roundTextureCoord(float coord, size)
 ^
./src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp:1114:12 note: non-constexpr function roundf cannot be used in a constant expression
 return roundf(coord * size) / size;
 ^

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Thanks

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app-launch-profiler/app-launch-profiler.pro'
--- app-launch-profiler/app-launch-profiler.pro 2016-03-12 17:38:04 +0000
+++ app-launch-profiler/app-launch-profiler.pro 2016-08-16 11:07:49 +0000
@@ -1,6 +1,7 @@
1TEMPLATE = app1TEMPLATE = app
2LIBS += -llttng-ust -ldl2LIBS += -llttng-ust -ldl
3CONFIG += -I.3CONFIG += -I.
4QMAKE_CXXFLAGS += -Werror
4HEADERS += app-launch-tracepoints.h5HEADERS += app-launch-tracepoints.h
5SOURCES += app-launch-tracepoints.c6SOURCES += app-launch-tracepoints.c
6TARGET = app-launch-tracepoints7TARGET = app-launch-tracepoints
78
=== modified file 'app-launch-profiler/app-launch-tracepoints.c'
--- app-launch-profiler/app-launch-tracepoints.c 2015-09-22 12:06:28 +0000
+++ app-launch-profiler/app-launch-tracepoints.c 2016-08-16 11:07:49 +0000
@@ -28,6 +28,8 @@
2828
29int main (int argc, char* argv[])29int main (int argc, char* argv[])
30{30{
31 #pragma unused(argc)
32 #pragma unused(argv)
31 tracepoint(app,invokeApplauncher);33 tracepoint(app,invokeApplauncher);
32 return 0;34 return 0;
33}35}
3436
=== modified file 'src/Ubuntu/UbuntuToolkit/sortfiltermodel.cpp'
--- src/Ubuntu/UbuntuToolkit/sortfiltermodel.cpp 2016-07-07 07:21:48 +0000
+++ src/Ubuntu/UbuntuToolkit/sortfiltermodel.cpp 2016-08-16 11:07:49 +0000
@@ -224,21 +224,11 @@
224 QHashIterator<int, QByteArray> i(roles);224 QHashIterator<int, QByteArray> i(roles);
225 while (i.hasNext()) {225 while (i.hasNext()) {
226 i.next();226 i.next();
227 res.insert(i.value(), data(row, i.key()));227 res.insert(i.value(), index(row, 0).data(i.key()));
228 }228 }
229 return res;229 return res;
230}230}
231231
232QVariant
233QSortFilterProxyModelQML::data(int row, int role)
234{
235 if (sourceModel() == NULL) {
236 return QVariant();
237 }
238
239 return index(row, 0).data(role);
240}
241
242int232int
243QSortFilterProxyModelQML::count()233QSortFilterProxyModelQML::count()
244{234{
245235
=== modified file 'src/Ubuntu/UbuntuToolkit/sortfiltermodel_p.h'
--- src/Ubuntu/UbuntuToolkit/sortfiltermodel_p.h 2016-07-07 07:21:48 +0000
+++ src/Ubuntu/UbuntuToolkit/sortfiltermodel_p.h 2016-08-16 11:07:49 +0000
@@ -45,7 +45,6 @@
45 explicit QSortFilterProxyModelQML(QObject *parent = 0);45 explicit QSortFilterProxyModelQML(QObject *parent = 0);
4646
47 Q_INVOKABLE QVariantMap get(int row);47 Q_INVOKABLE QVariantMap get(int row);
48 QVariant data(int row, int role);
49 Q_INVOKABLE int count();48 Q_INVOKABLE int count();
50 bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;49 bool filterAcceptsRow(int sourceRow, const QModelIndex &sourceParent) const override;
5150
5251
=== modified file 'src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp'
--- src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp 2016-07-07 07:21:48 +0000
+++ src/Ubuntu/UbuntuToolkit/ucubuntushape.cpp 2016-08-16 11:07:49 +0000
@@ -1109,7 +1109,7 @@
1109}1109}
11101110
1111// Gets the nearest boundary to coord in the texel grid of the given size.1111// Gets the nearest boundary to coord in the texel grid of the given size.
1112static Q_DECL_CONSTEXPR float roundTextureCoord(float coord, float size)1112static float roundTextureCoord(float coord, float size)
1113{1113{
1114 return roundf(coord * size) / size;1114 return roundf(coord * size) / size;
1115}1115}
11161116
=== modified file 'tests/unit/alarms/tst_alarms.cpp'
--- tests/unit/alarms/tst_alarms.cpp 2016-07-07 15:33:34 +0000
+++ tests/unit/alarms/tst_alarms.cpp 2016-08-16 11:07:49 +0000
@@ -537,8 +537,7 @@
537 QVERIFY(containsAlarm(&alarm));537 QVERIFY(containsAlarm(&alarm));
538538
539 // update alarm to occur 1h earlier539 // update alarm to occur 1h earlier
540 QDateTime date = alarm.date();540 QDateTime date = alarm.date().addSecs(-60);
541 date.addSecs(-60);
542 alarm.save();541 alarm.save();
543 waitForUpdate();542 waitForUpdate();
544 QVERIFY(containsAlarm(&alarm));543 QVERIFY(containsAlarm(&alarm));
545544
=== modified file 'tests/unit/page/tst_page.cpp'
--- tests/unit/page/tst_page.cpp 2014-03-28 17:02:52 +0000
+++ tests/unit/page/tst_page.cpp 2016-08-16 11:07:49 +0000
@@ -29,12 +29,8 @@
29{29{
30 Q_OBJECT30 Q_OBJECT
3131
32private:
33 QQuickView *view;
34
35public:32public:
36 tst_Page() :33 tst_Page()
37 view(0)
38 {34 {
39 }35 }
4036

Subscribers

People subscribed via source and target branches