Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4 into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Cris Dywan
Approved revision: 1353
Merged at revision: 1357
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 40 lines (+4/-4)
3 files modified
modules/Ubuntu/Components/AbstractButton.qml (+1/-1)
modules/Ubuntu/Components/Page.qdoc (+1/-1)
modules/Ubuntu/Components/plugin/ucaction.cpp (+2/-2)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/boldLinkingforQt5.4
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Timo Jyrinki Approve
Review via email: mp+243154@code.launchpad.net

Commit message

Change offending links into bold font

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I cannot now test this fix at the moment, since as of 5.4.0 RC there is a new build problem with UITK bug #1397979

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/AbstractButton.qml'
--- modules/Ubuntu/Components/AbstractButton.qml 2014-11-28 08:19:13 +0000
+++ modules/Ubuntu/Components/AbstractButton.qml 2014-11-28 13:31:36 +0000
@@ -40,7 +40,7 @@
4040
41 /*!41 /*!
42 This handler is called when there is a mouse click on the button42 This handler is called when there is a mouse click on the button
43 and the button is not disabled. If \l action is defined,43 and the button is not disabled. If \b action is defined,
44 the action will be triggered.44 the action will be triggered.
45 */45 */
46 signal clicked()46 signal clicked()
4747
=== modified file 'modules/Ubuntu/Components/Page.qdoc'
--- modules/Ubuntu/Components/Page.qdoc 2014-06-27 13:27:56 +0000
+++ modules/Ubuntu/Components/Page.qdoc 2014-11-28 13:31:36 +0000
@@ -71,7 +71,7 @@
71 \qmlproperty Item Page::tools71 \qmlproperty Item Page::tools
72 \deprecated72 \deprecated
73 The toolbar items associated with this Page.73 The toolbar items associated with this Page.
74 DEPRECATED. Use \l head.actions instead.74 DEPRECATED. Use \b head.actions instead.
75 */75 */
7676
77/*!77/*!
7878
=== modified file 'modules/Ubuntu/Components/plugin/ucaction.cpp'
--- modules/Ubuntu/Components/plugin/ucaction.cpp 2014-09-16 05:49:26 +0000
+++ modules/Ubuntu/Components/plugin/ucaction.cpp 2014-11-28 13:31:36 +0000
@@ -28,8 +28,8 @@
28 *28 *
29 * Actions can be used to define a specific task to be executed in different29 * Actions can be used to define a specific task to be executed in different
30 * contexts using different components. The same action can be assigned to30 * contexts using different components. The same action can be assigned to
31 * a \l Button, a \l Checkbox or even a \l TextField. The \l triggered signal31 * a \l Button, a \b Checkbox or even a \l TextField. The \l triggered signal
32 * is emitted depending on the component. \l Button and \l CheckBox for instance32 * is emitted depending on the component. \l Button and \b CheckBox for instance
33 * emits the signal when clicked, whereas \l TextField emits the signal when33 * emits the signal when clicked, whereas \l TextField emits the signal when
34 * its accepted signal is triggered.34 * its accepted signal is triggered.
35 *35 *

Subscribers

People subscribed via source and target branches