Merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/SEGFAULTingUnitTestsOptional into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Tim Peeters
Approved revision: 1940
Merged at revision: 1943
Proposed branch: lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/SEGFAULTingUnitTestsOptional
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 61 lines (+11/-6)
2 files modified
tests/checkresults.sh (+2/-2)
tests/unit/runtest.sh (+9/-4)
To merge this branch: bzr merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/SEGFAULTingUnitTestsOptional
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+291738@code.launchpad.net

Commit message

Allow SEGFAULTing tests to be flagged as exceptions

To post a comment you must log in.
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Good, thanks.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/checkresults.sh'
--- tests/checkresults.sh 2016-04-08 16:49:52 +0000
+++ tests/checkresults.sh 2016-04-13 11:10:47 +0000
@@ -33,8 +33,8 @@
3333
34 EXCEPTIONS='tst_components_benchmark \34 EXCEPTIONS='tst_components_benchmark \
35 tst_tabbar.qml \35 tst_tabbar.qml \
36 tst_datepicker.qml \36 tst_datepicker12.bug1567840.SEGFAULT.qml \
37 tst_datepicker13.qml \37 tst_datepicker13.bug1567840.SEGFAULT.qml \
38 tst_swipearea \38 tst_swipearea \
39 tst_qquick_image_extension \39 tst_qquick_image_extension \
40 tst_page.qml \40 tst_page.qml \
4141
=== modified file 'tests/unit/runtest.sh'
--- tests/unit/runtest.sh 2016-04-11 11:15:58 +0000
+++ tests/unit/runtest.sh 2016-04-13 11:10:47 +0000
@@ -66,9 +66,9 @@
66function create_fallback_xml {66function create_fallback_xml {
67 cat << EOF > $_XML67 cat << EOF > $_XML
68<?xml version="1.0" encoding="UTF-8" ?>68<?xml version="1.0" encoding="UTF-8" ?>
69<testsuite errors="1" failures="1" tests="1" name="$_TESTFILE">69<testsuite errors="$1" failures="1" tests="1" name="$_TESTFILE">
70 <testcase result="fail" name="${_TESTFILE}_Execution">70 <testcase result="fail" name="${_TESTFILE}_Execution">
71 <failure message="$1" result="fail"/>71 $2
72 </testcase>72 </testcase>
73</testsuite>73</testsuite>
74EOF74EOF
@@ -112,12 +112,17 @@
112 # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999112 # https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1256999
113 # https://bugreports.qt-project.org/browse/QTBUG-36243113 # https://bugreports.qt-project.org/browse/QTBUG-36243
114 114
115 # QV4_MM_AGGRESSIVE_GC=1 \
115 ALARM_BACKEND=memory SUPPRESS_DEPRECATED_NOTE=no \116 ALARM_BACKEND=memory SUPPRESS_DEPRECATED_NOTE=no \
116 QT_LOGGING_RULES="[PERFORMANCE].warning=false" \117 QT_LOGGING_RULES="[PERFORMANCE].warning=false" \
117 $_CMD $_ARGS 2>&1 | grep -v 'QFontDatabase: Cannot find font directory'118 $_CMD $_ARGS 2>&1 | grep -v 'QFontDatabase: Cannot find font directory'
118 if [ ! -s $_XML ]; then119 if [ ! -s $_XML ]; then
119 # Write fallback in case it crashed and the file is empty120 # Write fallback in case it crashed and the file is empty
120 create_fallback_xml "Test results corrupted (crash)"121 if [[ $_XML == *".SEGFAULT"* ]]; then
122 create_fallback_xml 0 '<!-- message="Test results corrupted (crashed)" type="qwarn" -->'
123 else
124 create_fallback_xml 1 '<failure message="Test results corrupted (crashed)" result="fail"/>'
125 fi
121 fi126 fi
122 if [ "x$UITK_TEST_KEEP_RUNNING" != "x1" ]; then127 if [ "x$UITK_TEST_KEEP_RUNNING" != "x1" ]; then
123 ${BUILD_DIR}/tests/checkresults.sh $_XML128 ${BUILD_DIR}/tests/checkresults.sh $_XML
@@ -140,7 +145,7 @@
140}145}
141146
142# Always create XML in case the test can't be run, eg. .so file missing147# Always create XML in case the test can't be run, eg. .so file missing
143create_fallback_xml "Test couldn't be run"148create_fallback_xml 1 '<failure message="Test couldnt be run" result="fail"/>'
144create_test_cmd149create_test_cmd
145execute_test_cmd150execute_test_cmd
146RESULT=$?151RESULT=$?
147152
=== renamed file 'tests/unit_x11/tst_components/tst_datepicker12.qml.SEGFAULT.bug1567840' => 'tests/unit_x11/tst_components/tst_datepicker12.bug1567840.SEGFAULT.qml'
=== renamed file 'tests/unit_x11/tst_components/tst_datepicker13.SEGFAULT.bug1567840' => 'tests/unit_x11/tst_components/tst_datepicker13.bug1567840.SEGFAULT.qml'

Subscribers

People subscribed via source and target branches