Merge autopkgtest-cloud:bionic-install-gpg-agent into autopkgtest-cloud:master

[Brian Murray]

Running autopkgtests with packages from PPAs on Bionic is failing with the following messages (seen in logs on the cloud workers).

55s Warning: apt-key output should not be parsed (stdout is not a terminal)
55s Executing: /tmp/apt-key-gpghome.JSxai74dnJ/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-key 7CA1F5946D641569F6169DA6185BA77D9DB344C3
55s gpg: key 185BA77D9DB344C3: public key "Launchpad PPA for The FIPS-CC-STIG" imported
55s gpg: failed to start agent '/usr/bin/gpg-agent': No such file or directory
55s gpg: can't connect to the agent: No such file or directory

It's unclear why gpg-agent isn't available but this will resolve the immediate problem of the tests not being able to run.

Before merging (or cowboy'ing) this I think a worth while test would be to remote the adt/ubuntu-bionic-*.img from the available images and recreate it using build-adt-image.

[Brian Murray (brian-murray)]

I ended up removing the adt/ubuntu-bionic-amd64-server-20240301.img and recreating it and that did not help.

[Brian Murray (brian-murray)]

I've cowboy'ed this on both autopkgtest-cloud-workers.

[Tim Andersson (andersson123)]

LGTM

review: Approve

[Paride Legovini (paride)]

I know the reason for this: to prevent the Noble images from breaking because the new gpg-wks-server was pulling in postfix, I made setup-testbed remove it. Of course this in turn removes gnupg. I didn't expect breakage because right after the removal setup-testbed does:

  chroot "$root" apt-get install -y gpg

if needed, but maybe that doesn't automatically pull in gpg-agent in Bionic.

Let's remember drop drop this workaround once we restart building Noble images with good base images (not having the gnupg -> gpg-wks-server -> postfix issue).

diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker-config-production/setup-canonical.sh b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker-config-production/setup-canonical.sh
index 0f60575..d7fe9a7 100644
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker-config-production/setup-canonical.sh
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker-config-production/setup-canonical.sh
@@ -39,6 +39,13 @@ if [ "${RELEASE}" != "trusty" ]; then
 fi
 rm /etc/apt/preferences.d/force-downgrade-to-release.pref
 
+# 2024-03-01 The adt image for bionic is somehow missing gpg-agent and
+# subsequently we cannot test packages from PPAs which is critical for
+# security-britney.
+if [ "${RELEASE}" = "bionic" ]; then
+    DEBIAN_FRONTEND=noninteractive eatmydata apt-get install -y gpg-agent
+fi
+
 # Remove packages not available from any configured repository, e.g.
 # packages fully removed from the archive. This requires the analyze-pattern
 # feature, which has been introduced in apt 2.0.1 (>= Focal).