Merge autopkgtest-cloud:github-no-running-check into autopkgtest-cloud:master

Proposed by Brian Murray
Status: Merged
Approved by: Tim Andersson
Approved revision: 0e060118537a04e7eb6966edbe388c50445bd5c8
Merged at revision: 0e060118537a04e7eb6966edbe388c50445bd5c8
Proposed branch: autopkgtest-cloud:github-no-running-check
Merge into: autopkgtest-cloud:master
Diff against target: 15 lines (+3/-1)
1 file modified
charms/focal/autopkgtest-web/webcontrol/request/submit.py (+3/-1)
Reviewer Review Type Date Requested Status
Tim Andersson Approve
Review via email: mp+449764@code.launchpad.net

Description of the change

This change has already been made on the production servers and given that we want to update the autopkgtest-web charm we should incorporate this change into the charm while we investigate the root cause.

Getting to the bottom of why the already running check was not working is a part of ADT-319.

To post a comment you must log in.
Revision history for this message
Tim Andersson (andersson123) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
2index a1b8c2b..e40e3d4 100644
3--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
4+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
5@@ -241,7 +241,9 @@ class Submit:
6 else:
7 triggers.append(env_var.split("=")[1])
8
9- self.is_request_queued_or_running(release, arch, package, triggers)
10+ # XXX - needs fixing the parameters passed to the check may be
11+ # insufficient to determine if a request is unique
12+ # self.is_request_queued_or_running(release, arch, package, triggers)
13
14 if release not in self.releases:
15 raise NotFound("release", release)

Subscribers

People subscribed via source and target branches