Merge autopkgtest-cloud:autopkgtest-requestors into autopkgtest-cloud:master

Proposed by Brian Murray
Status: Merged
Approved by: Tim Andersson
Approved revision: a10fc15645ed595b28761b05edb780fc718ab541
Merged at revision: a10fc15645ed595b28761b05edb780fc718ab541
Proposed branch: autopkgtest-cloud:autopkgtest-requestors
Merge into: autopkgtest-cloud:master
Diff against target: 12 lines (+1/-1)
1 file modified
charms/focal/autopkgtest-web/webcontrol/request/submit.py (+1/-1)
Reviewer Review Type Date Requested Status
Tim Andersson Approve
Review via email: mp+446883@code.launchpad.net

Description of the change

Instead of adding multiple Launchpad teams to ALLOWED_TEAMS we'll use one Launchpad team - autopkgtest-requestors. This'll avoid having to update the charm just to add an additional team.

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

The team can be found here and should be checked or any typos in the name.

https://launchpad.net/~autopkgtest-requestors

Revision history for this message
Tim Andersson (andersson123) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
2index ec97969..04d7f61 100644
3--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
4+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
5@@ -27,7 +27,7 @@ ENV = re.compile(r"^[a-zA-Z][a-zA-Z0-9_]+=[a-zA-Z0-9.:~/ -=]*$")
6 # URL and optional branch name
7 GIT = re.compile(r"^https?://[a-zA-Z0-9._/~+-]+(#[a-zA-Z0-9._/-]+)?$")
8
9-ALLOWED_TEAMS = ["canonical-kernel-distro-team", "canonical-foundations"]
10+ALLOWED_TEAMS = ["canonical-kernel-distro-team", "autopkgtest-requestors"]
11 # not teams
12 ALLOWED_USERS_PERPACKAGE = {"snapcraft": ["snappy-m-o"]}
13

Subscribers

People subscribed via source and target branches