Merge autopkgtest-cloud:arm64-only-qemu-efi-noacpi into autopkgtest-cloud:master

[Brian Murray]

We were seeing autopkgtest failures on armhf with the following in the logs:

No such directory: /boot/efi/EFI

The actual package being tested was fwts with the trigger "linux-meta-raspi/5.19.0.1002.4 qemu-efi-noacpi/0" and it was the qemu-efi-noacpi trigger which aborts if /boot/efi/EFI does not exist. We don't think the trigger should run on anything besides arm64 so want to prevent the test from running.

[Brian Murray (brian-murray)]

This change has been cowboy'ed and we can see the results here https://autopkgtest.ubuntu.com/packages/fwts/kinetic/armhf

[Paride Legovini (paride)]

This looks good, thanks for the fixups. Maybe we should add a

  logging.warning('...')

in the else stanza, otherwise I think this will won't be very visible from the service logs, which can help us debugging.

Another more general comment: there is some code duplication now, basically all the 'else' stanza is the same of the "never_run" check. Should we need to add another instance of this "don't run test but fake exit code and log file" code let's remember to factor it out in a separate function or similar.

review: Approve

[Brian Murray (brian-murray)]

I'm not happy with how we see "trigger:" in the Version table at https://autopkgtest.ubuntu.com/packages/fwts/kinetic/armhf .

[Brian Murray (brian-murray)]

> I'm not happy with how we see "trigger:" in the Version table at
> https://autopkgtest.ubuntu.com/packages/fwts/kinetic/armhf .

However, it might be because the cowboy'ed version of the change is different.

[Paride Legovini (paride)]

Should we go ahead and merge this?

c9b3206... by Brian Murray on 2022-10-28

Clarify where seed-new-release is located.

[Paride Legovini (paride)]

Looks like there's an extra unrelated commit in the proposed branch now?

review: Needs Information

[Paride Legovini (paride)]

Merging this as discussed in side channel (adt-153).

review: Approve

[Paride Legovini (paride)]

This is merged but not automatically marked as merged by LP as I had to manually get rid of the spurious commit (c9b3206).

I can't manually change the MP status to merged.
@Brian can you please do so?

diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
index 8a05766..77d0ebe 100755
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker
@@ -587,7 +587,22 @@ def request(msg):
             argv += ['--setup-commands', c]
 
         if 'triggers' in params and 'qemu-efi-noacpi/0' in params['triggers']:
-            argv += ['--setup-commands', '/home/ubuntu/autopkgtest-cloud/worker-config-production/qemu-efi-noacpi.sh']
+            if architecture == 'arm64':
+                argv += ['--setup-commands', '/home/ubuntu/autopkgtest-cloud/worker-config-production/qemu-efi-noacpi.sh']
+            else:
+                # these will be written later on
+                code = 99
+                duration = 0
+
+                os.makedirs(out_dir)
+                # fake a log file
+                with open(os.path.join(out_dir, 'log'), 'w') as log:
+                    log.write('Not running due to invalid trigger: qemu-efi-noacpi/0 is arm64 only')
+                dont_run = True
+
+                # and the testpackage version (invalid trigger with a reason)
+                with open(os.path.join(out_dir, 'testpkg-version'), 'w') as testpkg_version:
+                    testpkg_version.write('invalid trigger: qemu-efi-noacpi/0 is arm64 only')
 
         if 'ppas' in params and params['ppas']:
             for ppa in params['ppas']:
diff --git a/docs/administration.rst b/docs/administration.rst
index 4e25997..997bfa1 100644
--- a/docs/administration.rst
+++ b/docs/administration.rst
@@ -144,8 +144,8 @@ Opening up a new series
 
 * Download the latest ``autopkgtest.db`` from the website/unit to the home
   directory on wendigo
-* Run ``seed-new-release <old_release> <new_release> autopkgtest.db`` on
-  wendigo.
+* Run ``autopkgtest-cloud/tools/seed-new-release <old_release> <new_release> autopkgtest.db``
+  on wendigo.
 * Update the ``service-bundle`` to include the release in ``releases`` and
   deploy it. Run ``systemctl start download-all-results.service`` to download
   the results from swift to the db. TODO: This should be done automatically