Merge lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm-maas-stilson2 into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

Proposed by Francis Ginther
Status: Merged
Merged at revision: 801
Proposed branch: lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm-maas-stilson2
Merge into: lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm
Diff against target: 74 lines (+8/-8)
4 files modified
jenkins/MAASv2_Builder.sh (+1/-1)
jenkins/MAASv3_Builder.sh (+1/-1)
templates/img-maasv2.tmpl (+3/-3)
templates/img-maasv3.tmpl (+3/-3)
To merge this branch: bzr merge lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm-maas-stilson2
Reviewer Review Type Date Requested Status
Robert C Jennings (community) Approve
Philip Roche Approve
Review via email: mp+348867@code.launchpad.net

This proposal supersedes a proposal from 2018-07-02.

Commit message

Update the maas build scripts to use the ppc64el config on stilson which reports `ppc64le` for `uname -m` and use a raw disk attached to /dev/vdc.

Description of the change

The change from snyder to stilson resulted in a change in `uname -m`. It now reports as `ppc64le`. The build config uses this to pivot to a different cfg file which contains a different package set to install.

Also, kvm now mounts the raw disk used to pass the contents of the build in /dev/vdc instead of /dev/vdb.

To post a comment you must log in.
Revision history for this message
Robert C Jennings (rcj) wrote : Posted in a previous version of this proposal

+1

review: Approve
Revision history for this message
Philip Roche (philroche) : Posted in a previous version of this proposal
review: Approve
801. By Francis Ginther

The maas raw disk is now on /dev/vdc

Revision history for this message
Philip Roche (philroche) :
review: Approve
Revision history for this message
Robert C Jennings (rcj) wrote :

One possible improvement below but I'm +1 if that idea is unworkable or too far out of scope.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

@rcj, as we discussed over a hangout, the snyder disks were placed in a different host. So stilson is not impacted when those disks are removed.

I do think we can revisit this logic should the devices be renamed again as it's a frustrating change to debug.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jenkins/MAASv2_Builder.sh'
2--- jenkins/MAASv2_Builder.sh 2016-09-28 19:52:00 +0000
3+++ jenkins/MAASv2_Builder.sh 2018-07-02 21:17:14 +0000
4@@ -95,7 +95,7 @@
5 set +x
6
7 ci_cfg="${kvm_builder}/config/cloud-maasv2.cfg"
8-[ "$(uname -m)" == "ppc64" ] && ci_cfg="${kvm_builder}/config/cloud-trusty-pp64el.cfg"
9+[ "$(uname -m)" == "ppc64le" ] && ci_cfg="${kvm_builder}/config/cloud-trusty-pp64el.cfg"
10
11 # Launch KVM to do the work
12 launch_kvm.sh \
13
14=== modified file 'jenkins/MAASv3_Builder.sh'
15--- jenkins/MAASv3_Builder.sh 2016-10-04 18:53:03 +0000
16+++ jenkins/MAASv3_Builder.sh 2018-07-02 21:17:14 +0000
17@@ -47,7 +47,7 @@
18 fail "Failed to configure KVM instance for building"
19
20 ci_cfg="${kvm_builder}/config/cloud-maasv3.cfg"
21-[ "$(uname -m)" == "ppc64" ] && ci_cfg="${kvm_builder}/config/cloud-trusty-pp64el.cfg"
22+[ "$(uname -m)" == "ppc64le" ] && ci_cfg="${kvm_builder}/config/cloud-trusty-pp64el.cfg"
23
24 # Launch KVM to do the work
25 launch_kvm.sh \
26
27=== modified file 'templates/img-maasv2.tmpl'
28--- templates/img-maasv2.tmpl 2015-09-16 23:14:53 +0000
29+++ templates/img-maasv2.tmpl 2018-07-02 21:17:14 +0000
30@@ -7,7 +7,7 @@
31 fail() {
32 [ $# -eq 0 ] || error "$@";
33 echo "Failed" > /tmp/failed;
34- tar -C /tmp -cvf /dev/vdb failed build.log;
35+ tar -C /tmp -cvf /dev/vdc failed build.log;
36 shutdown -P now;
37 exit 1;
38 }
39@@ -128,9 +128,9 @@
40 done
41
42 # Finish the work
43-echo "Taring up artifacts to /dev/vdb!"
44+echo "Taring up artifacts to /dev/vdc!"
45 touch /tmp/success
46-tar -C /tmp -cvf /dev/vdb maas_images /var/log/* logs success build.log "${OUT_D}" >> /dev/null
47+tar -C /tmp -cvf /dev/vdc maas_images /var/log/* logs success build.log "${OUT_D}" >> /dev/null
48 sync
49 shutdown -P now
50
51
52=== modified file 'templates/img-maasv3.tmpl'
53--- templates/img-maasv3.tmpl 2016-10-06 15:20:55 +0000
54+++ templates/img-maasv3.tmpl 2018-07-02 21:17:14 +0000
55@@ -7,7 +7,7 @@
56 fail() {
57 [ $# -eq 0 ] || error "$@";
58 echo "Failed" > /tmp/failed;
59- tar -C /tmp -cvf /dev/vdb failed build.log;
60+ tar -C /tmp -cvf /dev/vdc failed build.log;
61 shutdown -P now;
62 exit 1;
63 }
64@@ -76,9 +76,9 @@
65 done
66
67 # Finish the work
68-echo "Taring up artifacts to /dev/vdb!"
69+echo "Taring up artifacts to /dev/vdc!"
70 touch /tmp/success
71-tar -C /tmp -cvf /dev/vdb maas_images /var/log/* logs success build.log "${OUT_D}" >> /dev/null
72+tar -C /tmp -cvf /dev/vdc maas_images /var/log/* logs success build.log "${OUT_D}" >> /dev/null
73 sync
74 shutdown -P now
75

Subscribers

People subscribed via source and target branches

to all changes: