Code review comment for lp:~ubuntu-multiseat/lightdm/simple-globbing-in-seat-config-section

Revision history for this message
Robert Ancell (robert-ancell) wrote :

There were some typos in the script but the main reason was the seat IDs (e.g. "seat-AAA-Foo") were being converted into invalid D-Bus address names (e.g. "/org/freedesktop/login1/seat/seat-AAA-Foo" - "_" is not allowed in D-Bus addresses). So there was a bug in my mock login1 code in tests/src/test-runner.c

I fixed that up and simplified the test.

Thanks!

« Back to merge proposal