Code review comment for ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus-alertmanager:use-snap-architecture-21.04

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote (last edit ):

Hi Sergio,

Thanks for the MP!

Looks good to me.

I tested it by running the changed curl command locally in an x86_64 machine and verifying the snap file, which is as expected. Then, I substituted the introduced dpkg command for different architectures to make sure the contents of the snap contain binaries for the requested architectures.

For instance (s90x):

$ file bin/alertmanager
prom/bin/alertmanager: ELF 64-bit MSB executable, IBM S/390, version 1 (SYSV), statically linked, Go BuildID=Li3q76PL8Nz7l2TuPIhI/LCp2e7c9ccaiwizuBy2k/8SgumMYUWSkk59-xU5IX/fuPcO5vH5LUSM51o3oq6, not stripped

review: Approve

« Back to merge proposal