Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/nginx:1.18-21.10-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/nginx:1.18-21.04

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: bcc60c04e8b09ce0379adaf6ae2baf4e96b3e13e
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/nginx:1.18-21.10-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/nginx:1.18-21.04
Diff against target: 67 lines (+6/-6)
4 files modified
Dockerfile (+1/-1)
HACKING.md (+1/-1)
README.md (+3/-3)
data/nginx.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+403481@code.launchpad.net

Description of the change

This change creates the nginx OCI image for impish.

Just the trivial changes were needed and no regressions were detected when running the unit test.

Note that this MP is targeting the 1.18-21.04 branch solely for comparing purposes. When accepted, these changes should be pushed into a new 1.18-21.10 branch.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, this built fine. Unfortunately I'm unable to make the IPv6 test pass, but I verified that it's rather a docker issue, and not something related to the image. For this reason, LGTM. +1

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Pushed to 1.18-21.10 and removed the 1.18-21.10-wip branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Dockerfile b/Dockerfile
index 0ae3721..924554e 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
1FROM ubuntu:hirsute1FROM ubuntu:impish
22
3ENV TZ UTC3ENV TZ UTC
44
diff --git a/HACKING.md b/HACKING.md
index 73cbe1a..02b6869 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -1,7 +1,7 @@
1# Contributing1# Contributing
22
3In Ubuntu, Nginx is available as a `.deb` package. For this reason,3In Ubuntu, Nginx is available as a `.deb` package. For this reason,
4this image was built by installing the Nginx Ubuntu 21.04 package4this image was built by installing the Nginx Ubuntu 21.10 package
5inside a docker container.5inside a docker container.
66
7In order to contribute to the Nginx OCI image, do the following:7In order to contribute to the Nginx OCI image, do the following:
diff --git a/README.md b/README.md
index 2947d6f..fe62e1b 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/nginx but are shown here for comple
1919
20| Channel Tag | | | Currently | Architectures |20| Channel Tag | | | Currently | Architectures |
21|---|---|---|---|---|21|---|---|---|---|---|
22| **`1.18-21.04_beta`**    | | | Nginx 1.18.0 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |22| **`1.18-21.10_beta`**    | | | Nginx 1.18.0 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
23| _`track_risk`_ |23| _`track_risk`_ |
2424
25Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.25Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
30Launch this image locally:30Launch this image locally:
3131
32```sh32```sh
33docker run -d --name nginx-container -e TZ=UTC -p 8080:80 ubuntu/nginx:1.18-21.04_beta33docker run -d --name nginx-container -e TZ=UTC -p 8080:80 ubuntu/nginx:1.18-21.10_beta
34```34```
35Access your Nginx server at `http://localhost:8080`.35Access your Nginx server at `http://localhost:8080`.
3636
@@ -66,7 +66,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
6666
67Download67Download
68[nginx.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/config/nginx.conf), [index.html](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/config/html/index.html) and68[nginx.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/config/nginx.conf), [index.html](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/config/html/index.html) and
69[nginx-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/nginx-deployment.yml) and set `containers.nginx.image` in `nginx-deployment.yml` to your chosen channel tag (e.g. `ubuntu/nginx:1.18-21.04_beta`), then:69[nginx-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/nginx/plain/examples/nginx-deployment.yml) and set `containers.nginx.image` in `nginx-deployment.yml` to your chosen channel tag (e.g. `ubuntu/nginx:1.18-21.10_beta`), then:
7070
71```sh71```sh
72kubectl create configmap nginx-config --from-file=nginx=nginx.conf --from-file=nginx-site=index.html72kubectl create configmap nginx-config --from-file=nginx=nginx.conf --from-file=nginx-site=index.html
diff --git a/data/nginx.yaml b/data/nginx.yaml
index 711923e..522ca6b 100644
--- a/data/nginx.yaml
+++ b/data/nginx.yaml
@@ -4,7 +4,7 @@ repo: nginx
4description: >4description: >
5 Nginx ("engine X") is a high-performance web and reverse proxy server created by Igor Sysoev. It can be used both as a standalone web server and as a proxy to reduce the load on back-end HTTP or mail servers. Read more on the [nginx website](https://www.nginx.com/).5 Nginx ("engine X") is a high-performance web and reverse proxy server created by Igor Sysoev. It can be used both as a standalone web server and as a proxy to reduce the load on back-end HTTP or mail servers. Read more on the [nginx website](https://www.nginx.com/).
6version: 1.18.06version: 1.18.0
7base: Ubuntu 21.047base: Ubuntu 21.10
8architectures:8architectures:
9 - amd649 - amd64
10 - arm6410 - arm64

Subscribers

People subscribed via source and target branches

to all changes: