Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:resync-20.04-with-21.04 into ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:edge

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 302df6a93ec8d5bbb0cb52d5e7de1a0cce3155fd
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:resync-20.04-with-21.04
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:edge
Diff against target: 42 lines (+17/-7)
1 file modified
Dockerfile (+17/-7)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Canonical Server Pending
Review via email: mp+400063@code.launchpad.net

Description of the change

Resync with Dockerfile from the 21.04 branch

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Bryce.

I thought it was strange to see my "Create manifest" commit in the list of unmerged commits, but then I noticed that this MP is set to be merged against the "edge" branch. Just a heads up.

Builds and tests fine. LGTM, +1.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

On Wed, Mar 24, 2021 at 02:36:16AM -0000, Sergio Durigan Junior wrote:
> Review: Approve
>
> Thanks, Bryce.
>
> I thought it was strange to see my "Create manifest" commit in the list of unmerged commits, but then I noticed that this MP is set to be merged against the "edge" branch. Just a heads up.
>
> Builds and tests fine. LGTM, +1.

Probably an artifact in my .git/config from before the branch split.
I'll make sure they're landed in the right origin branches, and fix up
the .git/configs properly.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Dockerfile b/Dockerfile
index 646f4d0..5cf5025 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -2,20 +2,30 @@ FROM ubuntu:focal
22
3ENV TZ UTC3ENV TZ UTC
44
5RUN set -eux; \
6# installation
7 apt-get update; \
8 DEBIAN_FRONTEND=noninteractive apt-get full-upgrade -y; \
9 DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
5# ensure SASL's "libplain.so" is installed as per https://github.com/memcached/memcached/wiki/SASLHowto10# ensure SASL's "libplain.so" is installed as per https://github.com/memcached/memcached/wiki/SASLHowto
6RUN set -eux \
7 && apt-get update \
8 && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
9 libsasl2-modules \11 libsasl2-modules \
10 memcached \12 memcached \
11 tzdata \13 tzdata \
12 && rm -rf /var/lib/apt/lists/* \14 ; \
13 && memcached -V15 DEBIAN_FRONTEND=noninteractive apt-get remove --purge --auto-remove -y; \
16 rm -rf /var/lib/apt/lists/*; \
17# smoke test
18 memcached -V; \
19# create manifest
20 mkdir -p /usr/share/rocks; \
21 (echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > /usr/share/rocks/dpkg.query
22
1423
15COPY docker-entrypoint.sh /usr/local/bin/24COPY docker-entrypoint.sh /usr/local/bin/
16RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat25RUN ln -s usr/local/bin/docker-entrypoint.sh /entrypoint.sh # backwards compat
17ENTRYPOINT ["docker-entrypoint.sh"]26ENTRYPOINT ["docker-entrypoint.sh"]
1827
19USER memcache28USER memcache
29
20EXPOSE 1121130EXPOSE 11211
21CMD ["memcached"]31CMD ["memcached"]

Subscribers

People subscribed via source and target branches

to all changes: