Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.10-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.04

Proposed by Athos Ribeiro
Status: Rejected
Rejected by: Athos Ribeiro
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.10-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.04
Diff against target: 79 lines (+7/-7)
4 files modified
Dockerfile (+2/-2)
HACKING.md (+1/-1)
README.md (+3/-3)
data/grafana.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Needs Fixing
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+403533@code.launchpad.net

Description of the change

This change creates the grafana OCI image for impish.

Just the trivial changes were needed and no regressions were detected when running the unit test.

Note that this MP is targeting the 7.4-21.04 branch solely for comparing purposes. When accepted, these changes should be pushed into a new 7.4-21.10 branch.

Moreover, we did not change the snap track for fetching the snap, since an impish track is not available yet.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Athos.

For these images, I think it's better if we work on creating the proper snap tracks and then updating the snaps themselves. Let's put this MP on hold until then.

review: Needs Fixing
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

BTW, the same applies to the other images are based on snaps.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Closing this one for now. I will either reopen it or file a new MP when the time comes for us to create and build new impish OCI images.

Unmerged commits

012b37e... by Athos Ribeiro

Regenerate documentation

Signed-off-by: Athos Ribeiro <email address hidden>

1d1c2f6... by Athos Ribeiro

Update to impish

Update the image to be based on impish. Note that until there is an
impish track for the grafana snap, we will keep using the hirsute one.

Signed-off-by: Athos Ribeiro <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Dockerfile b/Dockerfile
index ba826ca..5e36aae 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,7 @@
4# and adapted to use the grafana snap built from4# and adapted to use the grafana snap built from
5# https://github.com/auria/snap-grafana and installed from5# https://github.com/auria/snap-grafana and installed from
6# https://snapcraft.io/grafana6# https://snapcraft.io/grafana
7FROM ubuntu:hirsute AS snap-installer7FROM ubuntu:impish AS snap-installer
88
9RUN apt-get update && \9RUN apt-get update && \
10 DEBIAN_FRONTEND=noninteractive apt-get dist-upgrade -y && \10 DEBIAN_FRONTEND=noninteractive apt-get dist-upgrade -y && \
@@ -18,7 +18,7 @@ RUN curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/sna
18RUN mkdir -p /snap && unsquashfs -d /snap/grafana grafana.snap18RUN mkdir -p /snap && unsquashfs -d /snap/grafana grafana.snap
1919
2020
21FROM ubuntu:hirsute21FROM ubuntu:impish
2222
23EXPOSE 300023EXPOSE 3000
24LABEL maintainer="Ubuntu Server team <ubuntu-server@lists.ubuntu.com>"24LABEL maintainer="Ubuntu Server team <ubuntu-server@lists.ubuntu.com>"
diff --git a/HACKING.md b/HACKING.md
index 9448300..fca4771 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -7,7 +7,7 @@ In order to contribute to the Grafana OCI image do the following:
7* Build a new image with your changes. You can use the following command:7* Build a new image with your changes. You can use the following command:
88
9```9```
10$ docker build -t ubuntu/grafana:test 10$ docker build -t ubuntu/grafana:test .
11```11```
1212
13* Test the new image. Run it in some way that exercise your changes, you can also check th README.md file.13* Test the new image. Run it in some way that exercise your changes, you can also check th README.md file.
diff --git a/README.md b/README.md
index 2f3e897..d6aea31 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/grafana but are shown here for comp
1919
20| Channel Tag | | | Currently | Architectures |20| Channel Tag | | | Currently | Architectures |
21|---|---|---|---|---|21|---|---|---|---|---|
22| **`7.4-21.04_beta`** &nbsp;&nbsp; | | | Grafana 7.4.1 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |22| **`7.4-21.10_beta`** &nbsp;&nbsp; | | | Grafana 7.4.1 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
23| _`track_risk`_ |23| _`track_risk`_ |
2424
25Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.25Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
30Launch this image locally:30Launch this image locally:
3131
32```sh32```sh
33docker run -d --name grafana-container -e TZ=UTC -p 30000:3000 ubuntu/grafana:7.4-21.04_beta33docker run -d --name grafana-container -e TZ=UTC -p 30000:3000 ubuntu/grafana:7.4-21.10_beta
34```34```
35Access your Grafana server at `localhost:30000`.35Access your Grafana server at `localhost:30000`.
3636
@@ -65,7 +65,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
6565
66Download66Download
67[datasource.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/datasource.yml), [dashboard.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/dashboard.yml), [system-stats-dashboard.json](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/system-stats-dashboard.json) and67[datasource.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/datasource.yml), [dashboard.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/dashboard.yml), [system-stats-dashboard.json](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/system-stats-dashboard.json) and
68[grafana-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/grafana-deployment.yml) and set `containers.grafana.image` in `grafana-deployment.yml` to your chosen channel tag (e.g. `ubuntu/grafana:7.4-21.04_beta`), then:68[grafana-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/grafana-deployment.yml) and set `containers.grafana.image` in `grafana-deployment.yml` to your chosen channel tag (e.g. `ubuntu/grafana:7.4-21.10_beta`), then:
6969
70```sh70```sh
71kubectl create configmap grafana-config --from-file=grafana-datasource=datasource.yml --from-file=grafana-dashboard-definition=dashboard.yml --from-file=grafana-dashboard=system-stats-dashboard.json71kubectl create configmap grafana-config --from-file=grafana-datasource=datasource.yml --from-file=grafana-dashboard-definition=dashboard.yml --from-file=grafana-dashboard=system-stats-dashboard.json
diff --git a/data/grafana.yaml b/data/grafana.yaml
index efcd5f5..ec600f9 100644
--- a/data/grafana.yaml
+++ b/data/grafana.yaml
@@ -5,7 +5,7 @@ description: >
5 Grafana is a feature rich metrics dashboard and graph editor for Cloudwatch, Elasticsearch, Graphite, InfluxDB, OpenTSB, Prometheus, and Hosted Metrics. 5 Grafana is a feature rich metrics dashboard and graph editor for Cloudwatch, Elasticsearch, Graphite, InfluxDB, OpenTSB, Prometheus, and Hosted Metrics.
6 Read more on the [Grafana website](https://grafana.com/docs/).6 Read more on the [Grafana website](https://grafana.com/docs/).
7version: 7.4.17version: 7.4.1
8base: Ubuntu 21.048base: Ubuntu 21.10
9architectures:9architectures:
10 - amd6410 - amd64
11 - arm6411 - arm64

Subscribers

People subscribed via source and target branches

to all changes: