Code review comment for ~ubuntu-core-dev/grub/+git/ubuntu:sil2100/use-auto-nvram
Revision history for this message
| Łukasz Zemczak (sil2100) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Agreed, maybe I rushed with this MP a bit. It doesn't seem to be needed here. Let's drop it.
As for $NO_NVRAM, I agree it might be slightly cleaner to do it that way - but since --auto-nvram respects --no-nvram, I decided to introduce a one-line-diff instead of a multi-line one having to modify $NO_NVRAM (or introducing something like $AUTO_NVRAM). It seemed like useless copy-pasting of code. When --no-nvram is given along with --auto-nvram, no magic is done and simply no NVRAM operations are being done.