Code review comment for lp:~ubuntu-clock-dev/ubuntu-clock-app/stopwatch-feature-staging

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> Some more remarks:
> 1. With current implementation page swiping is not working any more.

Yes, that's intentional since the swipe-to-delete world city gesture is conflicting with the page swiping gesture. I talked to Unity developers like Michael Zanetti and agree that disabling that is the best way to go. I will bring this up with the designers when we meet.

> 2. In my opinion the time list is not easy to read, at first look:
> - It is hard to say which time is lap and which total time. In
> https://uappexplorer.com/app/stopwatch.mzanetti there are additionals
> description for every row.
> - It is hard to compare time results. In
> https://uappexplorer.com/app/stopwatch.mzanetti the hours is not displayed and
> miliseconds are smaller
> - Currently time list it looks like: http://i.imgur.com/qxh932g.png

I totally agree to both your points. If you look at the design document given to us, it didn't have a lap design. So I just temporarily just implemented something temporarily. I feel that the mzanetti's stopwatch app is a bit crowded. So I don't think showing the string "totalTime" and "laptime" for every list item would look nice. Perhaps as a header maybe? I will see what I can come up with or ask the designers.

« Back to merge proposal