Merge lp:~ubuntu-clock-dev/ubuntu-clock-app/reboot-packaging into lp:ubuntu-clock-app

Proposed by Nicholas Skaggs
Status: Merged
Approved by: Francis Ginther
Approved revision: 87
Merged at revision: 50
Proposed branch: lp:~ubuntu-clock-dev/ubuntu-clock-app/reboot-packaging
Merge into: lp:ubuntu-clock-app
Diff against target: 895 lines (+571/-78)
28 files modified
.bzr-builddeb/default.conf (+2/-0)
CMakeLists.txt (+43/-29)
app/CMakeLists.txt (+12/-5)
app/alarm/CMakeLists.txt (+1/-1)
app/clock/CMakeLists.txt (+1/-1)
app/components/CMakeLists.txt (+1/-1)
app/graphics/CMakeLists.txt (+5/-3)
app/upstreamcomponents/CMakeLists.txt (+1/-1)
app/worldclock/CMakeLists.txt (+1/-1)
backend/CMakeLists.txt (+8/-8)
cmake/Click.cmake (+0/-17)
debian/changelog (+327/-0)
debian/compat (+1/-0)
debian/control (+43/-0)
debian/copyright (+54/-0)
debian/rules (+20/-0)
debian/tests/control (+13/-0)
debian/tests/make-autopilot (+2/-0)
debian/tests/make-test (+2/-0)
debian/ubuntu-clock-app-autopilot.install (+1/-0)
debian/ubuntu-clock-app.install (+2/-0)
manifest.json (+8/-3)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/run (+3/-1)
tests/autopilot/ubuntu_clock_app/emulators.py (+2/-1)
tests/autopilot/ubuntu_clock_app/tests/__init__.py (+8/-5)
tests/unit/tst_hellocomponent.qml (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-clock-dev/ubuntu-clock-app/reboot-packaging
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Timo Jyrinki Approve
Sergio Schvezov Pending
Review via email: mp+230530@code.launchpad.net

This proposal supersedes a proposal from 2014-08-01.

Commit message

Various changes to the packaging to make it work with the newest ubuntu-clock-app.

Description of the change

RESUBMIT under team branch.

Various changes to the packaging to make it work with the newest ubuntu-clock-app.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:42
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/97/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1247/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/97/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/97/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:48
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/98/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1248/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/98/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/98/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote : Posted in a previous version of this proposal

Can you merge trunk as it now has a working autopilot test. I will follow up with sergieusens asap.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:50
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/108/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1284/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/108/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/108/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote : Posted in a previous version of this proposal

Daniel, I got the "make autopilot" to work. The first fix needed was already done by you in rev 51 (adjusting CMakeList.txt file to point at the new test path). The second fix needed is to rename ubuntu-clock-app to ubuntu_clock_app in the tests/autopilot/run file.

=== modified file 'tests/autopilot/run' (properties changed: -x to +x)
--- tests/autopilot/run 2014-07-31 16:58:56 +0000
+++ tests/autopilot/run 2014-08-05 10:13:21 +0000
@@ -7,5 +7,5 @@

 SCRIPTPATH=`dirname $0`
 pushd ${SCRIPTPATH}
-autopilot run ubuntu-clock-app
+autopilot run ubuntu_clock_app

After which I get it passing,

nik90@nik90-devel:~/Clock/add-alarm-test/builddir$ make autopilot
[ 0%] Built target alarmsettings-qmldir
[ 7%] Automoc for target timezone
[ 7%] Built target timezone_automoc
[ 42%] Built target timezone
[ 50%] Automoc for target datetime
[ 50%] Built target datetime_automoc
[ 71%] Built target datetime
[ 78%] Automoc for target alarmsettings
[ 78%] Built target alarmsettings_automoc
[100%] Built target alarmsettings
[100%] Built target timezone-qmldir
[100%] Built target datetime-qmldir
~/Clock/add-alarm-test/tests/autopilot ~/Clock/add-alarm-test/builddir/app
Loading tests from: /home/nik90/Clock/add-alarm-test/tests/autopilot

Tests running...

Ran 1 test in 48.013s
OK
~/Clock/add-alarm-test/builddir/app
[100%] Built target autopilot

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel Holbach (dholbach) wrote : Posted in a previous version of this proposal

A number of files are not installed in the right place or not present/installed at all:

 - backend/ directory is missing
 - files in usr/lib probably need their own, a bit more descriptive directory name
 - files for the -autopilot package are not installed anywhere
 - .desktop file.

Revision history for this message
Sergio Schvezov (sergiusens) wrote : Posted in a previous version of this proposal

one inline comment for now, more later

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote : Posted in a previous version of this proposal
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I dropped the find_local_path as the python code was failing and I intend to propose a better solution in a future mp. No matter what we decide, this reverts to trunk and we can address the local path issue in another MP.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:77
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/reboot-packaging/+merge/230530/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/172/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/4/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/172/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/172/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Sergiusens fixed the remaining issues w.r.t to the click package. Please do not merge. I want to do one final review before approving and merging to trunk.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I made some changes to be more in line with other phone packages in Ubuntu (originally instructed in https://wiki.ubuntu.com/DailyRelease/InlinePackaging).

If you want, you can keep the old version numbering as long as this is not hitting the Ubuntu archives officially. Also, "UNRELEASED" for the version is just normal what's done when wanting to have the CI Train to append it's own date format and do the official releasing, which is not applicable here.

Anyway, builds fine, looks fine.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Lgtm now.

review: Approve (cmake and click packaging)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Sry forgot to do one small fix which was to update cmake to point at the lp:ubuntu-clock-app/reboot branch instead of the old lp:ubuntu-clock-app branch. I fixed this in rev 87

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Autolanding job was not correctly updated when the ci job was to used the python3 specific test runner. This has been fixed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.bzr-builddeb'
2=== added file '.bzr-builddeb/default.conf'
3--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
4+++ .bzr-builddeb/default.conf 2014-08-13 12:03:59 +0000
5@@ -0,0 +1,2 @@
6+[BUILDDEB]
7+split = True
8
9=== modified file 'CMakeLists.txt'
10--- CMakeLists.txt 2014-07-26 09:34:15 +0000
11+++ CMakeLists.txt 2014-08-13 12:03:59 +0000
12@@ -2,7 +2,6 @@
13 cmake_minimum_required(VERSION 2.8.9)
14
15 set (UBUNTU_PROJECT_TYPE "ClickApp" CACHE INTERNAL "Tells QtCreator this is a Click application project")
16-set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
17 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")
18
19 find_package(Qt5Core)
20@@ -20,51 +19,66 @@
21 set(APP_NAME clock)
22 set(APP_HARDCODE ubuntu-clock-app)
23 set(MAIN_QML ${APP_HARDCODE}.qml)
24-set(ICON clock-app@30.png)
25+set(ICON clock-app)
26+SET(AUTOPILOT_DIR ubuntu_clock_app)
27+
28+# Standard install paths
29+include(GNUInstallDirs)
30
31 #set install paths
32-if(${CLICK_MODE})
33- set(CMAKE_INSTALL_PREFIX /)
34- set(DATA_DIR /)
35- set(DESKTOP_DIR ${DATA_DIR})
36- set(UBUNTU-CLOCK-APP_DIR "share/qml/ubuntu-clock-app")
37- set(ICON "${UBUNTU-CLOCK-APP_DIR}/${ICON}")
38+if(CLICK_MODE)
39+ set(CMAKE_INSTALL_PREFIX "/")
40+ set(UBUNTU-CLOCK_APP_DIR "${CMAKE_INSTALL_DATADIR}/qml")
41
42- execute_process(
43- COMMAND dpkg-architecture -qDEB_HOST_MULTIARCH
44- OUTPUT_VARIABLE ARCH_TRIPLET
45- OUTPUT_STRIP_TRAILING_WHITESPACE
46- )
47- set(QT_IMPORTS_DIR "lib/${ARCH_TRIPLET}")
48-else()
49- set(DATA_DIR "share/clockapp")
50- set(DESKTOP_DIR ${DATA_DIR})
51- set(ICON "${DATA_DIR}/${ICON}")
52- set(UBUNTU-CLOCK-APP_DIR "share/ubuntu-clock-app/qml")
53- include(GNUInstallDirs)
54 set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}")
55-endif()
56-
57-set(EXEC "qmlscene $@ ${UBUNTU-CLOCK-APP_DIR}/${MAIN_QML}")
58+ set(EXEC "qmlscene $@ ${UBUNTU-CLOCK_APP_DIR}/${MAIN_QML}")
59+ set(MODULE_PATH ${QT_IMPORTS_DIR})
60+ if(NOT BZR_REVNO)
61+ execute_process(
62+ COMMAND bzr revno
63+ OUTPUT_VARIABLE BZR_REVNO
64+ WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
65+ OUTPUT_STRIP_TRAILING_WHITESPACE
66+ )
67+ endif(NOT BZR_REVNO)
68+ if(NOT BZR_SOURCE)
69+ set(BZR_SOURCE lp:${APP_HARDCODE}/reboot)
70+ message("-- Setting BZR_SOURCE to ${BZR_SOURCE}")
71+ endif(NOT BZR_SOURCE)
72+else(CLICK_MODE)
73+ set(UBUNTU-CLOCK_APP_DIR "${CMAKE_INSTALL_DATADIR}/ubuntu-clock-app")
74+ execute_process(
75+ COMMAND qmake -query QT_INSTALL_QML
76+ OUTPUT_VARIABLE QT_IMPORTS_DIR
77+ OUTPUT_STRIP_TRAILING_WHITESPACE
78+ )
79+set(MODULE_PATH ${QT_IMPORTS_DIR}/ClockApp)
80+endif(CLICK_MODE)
81
82 if(${CLICK_MODE})
83- install(FILES manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
84+ message("-- Configuring manifest.json")
85+ configure_file(manifest.json manifest.json)
86+ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
87+ install(FILES "${APP_HARDCODE}.json" DESTINATION ${CMAKE_INSTALL_PREFIX})
88+else(CLICK_MODE)
89+ set(EXEC "qmlscene $@ -I ${MODULE_PATH} ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CLOCK_APP_DIR}/${MAIN_QML}")
90 endif()
91-install(DIRECTORY "app/graphics" DESTINATION ${DATA_DIR})
92-install(FILES "${APP_HARDCODE}.json" DESTINATION ${DATA_DIR})
93
94 add_subdirectory(app)
95 add_subdirectory(backend)
96+if(NOT CLICK_MODE)
97+ add_subdirectory(tests)
98+endif(NOT CLICK_MODE)
99
100-add_custom_target("autopilot" chmod +x ${CMAKE_SOURCE_DIR}/app/tests/autopilot/run
101- COMMAND ${CMAKE_SOURCE_DIR}/app/tests/autopilot/run
102+add_custom_target("autopilot" chmod +x ${CMAKE_SOURCE_DIR}/tests/autopilot/run
103+ COMMAND ${CMAKE_SOURCE_DIR}/tests/autopilot/run
104 DEPENDS timezone timezone-qmldir alarmsettings alarmsettings-qmldir datetime datetime-qmldir
105 WORKING_DIRECTORY ./app)
106
107 enable_testing()
108 add_test(NAME basic
109 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/app
110- COMMAND /usr/bin/qmltestrunner -input ${CMAKE_SOURCE_DIR}/app/tests/unit -import ${CMAKE_BINARY_DIR}/backend
111+ COMMAND /usr/bin/qmltestrunner -input ${CMAKE_SOURCE_DIR}/tests/unit -import ${CMAKE_BINARY_DIR}/backend
112 )
113
114 add_custom_target("run" /usr/bin/qmlscene -I ${CMAKE_BINARY_DIR}/backend ${CMAKE_SOURCE_DIR}/app/ubuntu-clock-app.qml
115
116=== modified file 'app/CMakeLists.txt'
117--- app/CMakeLists.txt 2014-07-28 13:02:59 +0000
118+++ app/CMakeLists.txt 2014-08-13 12:03:59 +0000
119@@ -1,14 +1,21 @@
120-file(GLOB QML_JS_FILES *.qml *.js *.png)
121-
122-# make the files visible on qtcreator
123+if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
124 add_custom_target(ubuntu-clock-app_QMlFiles ALL SOURCES ${QML_JS_FILES})
125+endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
126+
127+
128+if(CLICK_MODE)
129+ set(ICON "${ICON}@30.png")
130+ install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
131+endif(CLICK_MODE)
132
133 # substitute variables in the desktop file
134 set(DESKTOP_FILE "ubuntu-clock-app.desktop")
135+message("-- Configuring ubuntu-clock-app.desktop.in")
136 configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
137
138-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE} DESTINATION ${DESKTOP_DIR})
139-install(FILES ${QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR})
140+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
141+ DESTINATION ${CMAKE_INSTALL_DATADIR}/applications)
142+install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CLOCK_APP_DIR})
143
144 add_subdirectory(clock)
145 add_subdirectory(alarm)
146
147=== modified file 'app/alarm/CMakeLists.txt'
148--- app/alarm/CMakeLists.txt 2014-06-16 14:09:12 +0000
149+++ app/alarm/CMakeLists.txt 2014-08-13 12:03:59 +0000
150@@ -3,4 +3,4 @@
151 # make the files visible in the qtcreator tree
152 add_custom_target(ubuntu-clock-app_alarm_QMlFiles ALL SOURCES ${ALARM_QML_JS_FILES})
153
154-install(FILES ${ALARM_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/alarm)
155+install(FILES ${ALARM_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/alarm)
156
157=== modified file 'app/clock/CMakeLists.txt'
158--- app/clock/CMakeLists.txt 2014-06-06 18:45:49 +0000
159+++ app/clock/CMakeLists.txt 2014-08-13 12:03:59 +0000
160@@ -3,4 +3,4 @@
161 # make the files visible in the qtcreator tree
162 add_custom_target(ubuntu-clock-app_clock_QMlFiles ALL SOURCES ${CLOCK_QML_JS_FILES})
163
164-install(FILES ${CLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/clock)
165+install(FILES ${CLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/clock)
166
167=== modified file 'app/components/CMakeLists.txt'
168--- app/components/CMakeLists.txt 2014-06-06 18:45:49 +0000
169+++ app/components/CMakeLists.txt 2014-08-13 12:03:59 +0000
170@@ -3,4 +3,4 @@
171 # make the files visible in the qtcreator tree
172 add_custom_target(ubuntu-clock-app_components_QMlFiles ALL SOURCES ${COMPONENTS_QML_JS_FILES})
173
174-install(FILES ${COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/components)
175+install(FILES ${COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/components)
176
177=== modified file 'app/graphics/CMakeLists.txt'
178--- app/graphics/CMakeLists.txt 2014-06-06 18:45:49 +0000
179+++ app/graphics/CMakeLists.txt 2014-08-13 12:03:59 +0000
180@@ -1,6 +1,8 @@
181-file(GLOB IMAGES_PNG_FILES *.png *.jpg)
182+file(GLOB GRAPHICS_FILES *.png *.jpg)
183
184 # make the files visible in the qtcreator tree
185-add_custom_target(ubuntu-clock-app_graphics_PNGFiles ALL SOURCES ${IMAGES_PNG_FILES})
186+if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
187+ add_custom_target(ubuntu-clock-app_graphics_PNGFiles ALL SOURCES ${IMAGES_PNG_FILES})
188+endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
189
190-install(FILES ${IMAGES_PNG_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/graphics)
191+install(FILES ${GRAPHICS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/graphics)
192
193=== modified file 'app/upstreamcomponents/CMakeLists.txt'
194--- app/upstreamcomponents/CMakeLists.txt 2014-07-28 13:02:59 +0000
195+++ app/upstreamcomponents/CMakeLists.txt 2014-08-13 12:03:59 +0000
196@@ -3,4 +3,4 @@
197 # make the files visible in the qtcreator tree
198 add_custom_target(ubuntu-clock-app_upstream_components_QMlFiles ALL SOURCES ${UPSTREAM_COMPONENTS_QML_JS_FILES})
199
200-install(FILES ${UPSTREAM_COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/upstreamcomponents)
201+install(FILES ${UPSTREAM_COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/upstreamcomponents)
202
203=== modified file 'app/worldclock/CMakeLists.txt'
204--- app/worldclock/CMakeLists.txt 2014-07-13 11:18:31 +0000
205+++ app/worldclock/CMakeLists.txt 2014-08-13 12:03:59 +0000
206@@ -3,4 +3,4 @@
207 # make the files visible in the qtcreator tree
208 add_custom_target(ubuntu-clock-app_worldclock_QMlFiles ALL SOURCES ${WORLDCLOCK_QML_JS_FILES})
209
210-install(FILES ${WORLDCLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/worldclock)
211+install(FILES ${WORLDCLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/worldclock)
212
213=== modified file 'backend/CMakeLists.txt'
214--- backend/CMakeLists.txt 2014-07-26 09:34:15 +0000
215+++ backend/CMakeLists.txt 2014-08-13 12:03:59 +0000
216@@ -67,11 +67,11 @@
217 )
218
219 # Install plugin file
220-install(TARGETS timezone DESTINATION ${QT_IMPORTS_DIR}/Timezone/)
221-install(FILES modules/Timezone/qmldir DESTINATION ${QT_IMPORTS_DIR}/Timezone/)
222-
223-install(TARGETS datetime DESTINATION ${QT_IMPORTS_DIR}/DateTime/)
224-install(FILES modules/DateTime/qmldir DESTINATION ${QT_IMPORTS_DIR}/DateTime/)
225-
226-install(TARGETS alarmsettings DESTINATION ${QT_IMPORTS_DIR}/Alarm/Settings/)
227-install(FILES modules/Alarm/Settings/qmldir DESTINATION ${QT_IMPORTS_DIR}/Alarm/Settings/)
228+install(TARGETS timezone DESTINATION ${MODULE_PATH}/Timezone/)
229+install(FILES modules/Timezone/qmldir DESTINATION ${MODULE_PATH}/Timezone/)
230+
231+install(TARGETS datetime DESTINATION ${MODULE_PATH}/DateTime/)
232+install(FILES modules/DateTime/qmldir DESTINATION ${MODULE_PATH}/DateTime/)
233+
234+install(TARGETS alarmsettings DESTINATION ${MODULE_PATH}/Alarm/Settings/)
235+install(FILES modules/Alarm/Settings/qmldir DESTINATION ${MODULE_PATH}/Alarm/Settings/)
236
237=== removed directory 'cmake'
238=== removed file 'cmake/Click.cmake'
239--- cmake/Click.cmake 2014-06-06 18:45:49 +0000
240+++ cmake/Click.cmake 1970-01-01 00:00:00 +0000
241@@ -1,17 +0,0 @@
242-if(CLICK_MODE)
243- STRING(REPLACE "/usr/" "/" QT_IMPORTS_DIR ${QT_IMPORTS_DIR})
244- set(CMAKE_INSTALL_PREFIX /)
245- set(CMAKE_INSTALL_BINDIR /)
246- set(DATA_DIR /)
247- set(EXEC "qmlscene $@ -I .${QT_IMPORTS_DIR} ${UBUNTU-CLOCK-APP_DIR}/${MAIN_QML}")
248- set(DESKTOP_DIR ${DATA_DIR})
249- set(ICON ".${DATA_DIR}/${ICON}")
250- install(FILES manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
251- install(DIRECTORY "app/graphics" DESTINATION ${DATA_DIR})
252- install(FILES "${CMAKE_PROJECT_NAME}.json" DESTINATION ${DATA_DIR})
253-else(CLICK_MODE)
254- set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_NAME})
255- set(EXEC "qmlscene $@ ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/qml/${MAIN_QML}")
256- set(ICON "${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON}")
257- set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
258-endif(CLICK_MODE)
259
260=== added directory 'debian'
261=== added file 'debian/changelog'
262--- debian/changelog 1970-01-01 00:00:00 +0000
263+++ debian/changelog 2014-08-13 12:03:59 +0000
264@@ -0,0 +1,327 @@
265+ubuntu-clock-app (3.0-0ubuntu1) utopic; urgency=medium
266+
267+ [ Daniel Holbach ]
268+ * Fix debhelper-but-no-misc-depends ubuntu-clock-app-autopilot.
269+ * Bump Standards-Version to 3.9.5, no changes required.
270+ * Add missing build-depends.
271+ * Run 'wrap-and-sort'.
272+ * Don't try to install files from usr/bin, there are none.
273+ * Install files from usr/lib.
274+ * Fail if not all files can be installed.
275+ * Make ubuntu-clock-app Arch:any.
276+ * Install files into ubuntu-clock-app-autopilot again (LP: #1354074).
277+ * Add ${shlibs:Depends} to Depends.
278+ * Remove duplicate 'Section' definition.
279+ * Relax dependency from ubuntu-clock-app-autopilot on ubuntu-clock-app
280+ somewhat.
281+ * Run tests as autopkgtest. (LP: #1354091)
282+ * Don't ignore return code of autopilot test execution. (LP: #1354095)
283+ * Fix path in Exec= line of .desktop file. (LP: #1354081)
284+ * Move module files into proper place. (LP: #1354079)
285+ * Make pep8 happy.
286+ * Add -I argument to Exec line in .desktop file.
287+
288+ [ Jussi Pakkanen ]
289+ * Use CMake's testing framework instead of a custom target.
290+ * Only install manifest in click mode.
291+ * Spaces are tabs.
292+ * Add a CMake option to build both as a click app and a regular one.
293+
294+ [ Sergio Schvezov ]
295+ * Using GnuInstallDirs takes care of the arch triplet.
296+ * Used a proper qt_imports_dir (still needs qml import updates).
297+ * Moved gnuinstalldirs higher up for better path management.
298+ * Removed a bunch of very custom variables and build on top.
299+ * Removed the install target for the gallery directory as it was a dup
300+ and going to the wrong path.
301+ * Not installing icon for deb and just rely on us using the desktop
302+ default (we can depend on the suru icon set, it's there).
303+ * Made some rules filter out if not in qtcreator.
304+ * Changed the path for a couple of things to use common subpaths in most
305+ cases.
306+
307+ -- Daniel Holbach <daniel.holbach@ubuntu.com> Wed, 13 Aug 2014 11:24:41 +0000
308+
309+ubuntu-clock-app (2.9) utopic; urgency=medium
310+
311+ [Nekhelesh Ramananthan]
312+ * Added multiselect mode for alarms list as per design (LP: #1349882)
313+ * Fixed a small portion of the listitem behind left behind after
314+ deleting it. (LP: #1354617)
315+ * Added vibration settings option for alarms (LP: #1350017)
316+
317+ [Michael Zanetti]
318+ * Improve the performance of the world city list by creating QTimeZone
319+ objects only once as they are really slow to create. (LP: #1350433)
320+
321+ [Nicholas Skaggs]
322+ * Tweak AP setup and launching
323+
324+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Mon, 11 Aug 2014 16:20:00 +0200
325+
326+ubuntu-clock-app (2.8) utopic; urgency=medium
327+
328+ [Nekhelesh Ramananthan]
329+ * Implemented custom swipe delete for list items (LP: #1349881)
330+ * Synced bottom edge component with upstream code
331+ * Added fast scroll to the world city page (LP: #1349877)
332+ * Implemented the world clock UI in the main clock page
333+ * Added settings option to change system time in the clock app.
334+
335+ [Carla Sella]
336+ * Setup autopilot infrastructure and added alarm test
337+ * Added objectNames required for the AP tests
338+ * Expanded alarm tests using scenarios to cover different days
339+
340+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 08 Aug 2014 21:05:12 +0200
341+
342+ubuntu-clock-app (2.7) utopic; urgency=medium
343+
344+ [Nekhelesh Ramananthan]
345+ * Expanded base TimeZoneModel to also take a u1db query model
346+ * Added more cities to the local world city list
347+ * Improved the accuracy of the clock hour hand by taking into account the
348+ minutes as well.
349+ * Improved minute and second hand accuracy
350+ * Improved the clock hands movement. It is now more smoother.
351+ * Added a delete alarm button in the edit alarm page as per design
352+ * Encapsulated the settings icon into an abstract button to provide haptic
353+ feedback when pressed.
354+
355+ [Victor Thompson]
356+ * Resolve build warning related to unused variable in the AlarmSettings plugin
357+
358+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Mon, 04 Aug 2014 11:23:30 +0200
359+
360+ubuntu-clock-app (2.6) utopic; urgency=medium
361+
362+ [Nekhelesh Ramananthan]
363+ * Clock mode is now saved in u1db to remember the user preferences
364+ * Added support for alarm setting options like alarm duration and volume
365+ * Updated license headers
366+ * Added support to listen to Dbus changes to the alarm settings and update
367+ UI automatically.
368+
369+ [Victor Thompson]
370+ * Update digital time every second instead of every 60 seconds
371+
372+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Wed, 30 Jul 2014 10:10:23 +0200
373+
374+ubuntu-clock-app (2.5) utopic; urgency=medium
375+
376+ [Nekhelesh Ramananthan]
377+ * Added a page to select world cities.
378+ * World cities are filtered as the user types using the SDK SortFilterModel
379+ * Added a XML file with a list of popular cities
380+
381+ [Victor Thompson]
382+ * Center the plus icon in PullToAdd.qml
383+ * Use the ok icon instead of save in the edit alarm page
384+
385+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 24 Jul 2014 15:20:15 +0200
386+
387+ubuntu-clock-app (2.4) utopic; urgency=medium
388+
389+ [Nekhelesh Ramananthan]
390+ * Fixed some issues that were noticed while running on the device for the first time
391+ * Removed AddCityButton.qml since we use the pulltoadd component now
392+ * Pulltoadd animation is now more reliable since it uses grid units instead of pixels
393+ * Transition to the new headers API
394+ * Removed the redundant back button definition in the alarm page since it is provided
395+ by the pagestack automatically.
396+ * Implemented Analog mode and allowed for switching between different modes.
397+
398+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 17 Jul 2014 20:32:15 +0200
399+
400+ubuntu-clock-app (2.3) utopic; urgency=medium
401+
402+ [Nekhelesh Ramananthan]
403+ * Updated framework version to ubuntu-sdk-14.10-dev2
404+ * Fix apparmor issue with regards to reading the ringtone folder (LP: #1340326)
405+
406+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Sat, 12 Jul 2014 14:00:00 +0200
407+
408+ubuntu-clock-app (2.2) utopic; urgency=medium
409+
410+ [Nekhelesh Ramananthan]
411+ * Split labels to allow for a different color time divider.
412+ * Added support for 12-hour time display.
413+ * Fixed CMakeList.txt for apparmor file
414+ * Returned the clock time in the proper user locale
415+ * Added support to edit saved alarms
416+
417+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 10 Jul 2014 14:00:00 +0200
418+
419+ubuntu-clock-app (2.1) utopic; urgency=medium
420+
421+ [Nekhelesh Ramananthan]
422+ * Added support for creating new alarms
423+ * Added bottom edge for alarms
424+ * Added tug down add city animation
425+ * Updated the font size of several UI elements according to design.
426+
427+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 03 Jul 2014 10:00:00 +0200
428+
429+ubuntu-clock-app (2.0) utopic; urgency=medium
430+
431+ [Nekhelesh Ramananthan]
432+ * First release of the clock app reboot
433+ * Implemented Digital Mode (LP: #1267146)
434+ * Fixed scrollable lists on scrollable pages (LP: #1227418)
435+ * Added developer guidelines
436+
437+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 26 Jun 2014 18:57:25 +0200
438+
439+ubuntu-clock-app (1.1) raring; urgency=medium
440+
441+ * New icon
442+ * Add -qt5 command line option (LP: #1288885)
443+ * Update framework and apparmor profile version
444+
445+ -- Alan Pope <popey@ubuntu.com> Fri, 02 May 2014 13:57:25 +0100
446+
447+ubuntu-clock-app (1.0) saucy; urgency=low
448+
449+ [Nekhelesh Ramananthan]
450+ * World Clock list needs to inform user when results cannot be retrieved due to network error (LP: #1231106)
451+ * Load premade presets for new user so user doesn't end up in blank app (LP: #1226131)
452+ * Return more fine-grained territorial divisions for city search results (LP: #1230153)
453+ * Improve the visual appearance of the clock, timer, stopwatch and alarm
454+ * Removed hour support from timer
455+
456+ [Sergio Schvezov]
457+ * Translation for desktop and debian package
458+ * Fix click package confinement issues
459+
460+ [Riccardo Padovani]
461+ * Alarm notifications do not appear when an alarm is triggered (LP: #1233176)
462+
463+ [Nicholas Skaggs]
464+ * Several apps have failing tests with 20131003 ui-toolkit (LP: #1234544)
465+
466+ [Andrea Cerisara]
467+ * Autopilot Testcase Needed: Test Add World Clock (LP: #1210196)
468+ * Autopilot Testcase Needed: Test Delete World Clock (LP: #1210197)
469+
470+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 11 Oct 2013 01:45:36 +0200
471+
472+ubuntu-clock-app (0.7) saucy; urgency=low
473+
474+ [Nekhelesh Ramananthan]
475+ * Alarm doesn't work (LP: #1187994)
476+ * Clock app does not honor timezone (LP: #1191291)
477+ * Clocks need to sync better and use the same backend (LP: #1201830)
478+ * Clock reports time in UTC by default (LP: #1201858)
479+ * On scrolling down page, hide tab header (LP: #1226128)
480+ * Very difficult to select bottom city in scrollable list of 4 or more (LP: #1227674)
481+ * There is no effect on the circle shape (LP: #1215332)
482+ * HUD actions should not appear for toolbar button such as save or cancel (LP: #1224891)
483+
484+ [Paolo Rotolo]
485+ * Add error message if no cities were found (LP: #1222235)
486+ * Timer label updates before the timer hand reaches destination (LP: #1172869)
487+ * Cancel toolbar action needs the correct icon (LP: #1222942)
488+
489+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 27 Sep 2013 12:47:21 +0200
490+
491+ubuntu-clock-app (0.6) saucy; urgency=low
492+
493+ [Nekhelesh Ramananthan]
494+ * Digital clock font size is smaller than design spec (LP: #1215334)
495+ * Font in world city list are too big (LP: #1200594)
496+ * Timer does not inform user if there are no presets (LP: #1169182)
497+ * Clicking the Add preset or add city button should reflect on the title for visual feedback (LP: #1168329)
498+ * In Timer, clock face is off screen when selecting preset (LP: #1219770)
499+ * Toolbar prevents text preset from accepting input (LP: #1209024)
500+
501+ [Paolo Rotolo]
502+ * Search button icon is not as per design specifications (LP: #1221252)
503+ * Search icon isn't in Ubuntu Touch Style (LP: #1202364)
504+ * Reset button doesn't work while the stopwatch is running (LP: #1204861)
505+ * Timer sometimes does not reset its clock hands after stopping it (LP: #1197908)
506+ * Provide the ability to delete a stopwatch lap (LP: #1220375)
507+ * Scrolling list of cities overlaps labels (LP: #1219768)
508+ * Reset and lap icons appear pixelated on a phone (LP: #1218751)
509+ * While searching world cities provide a small pause before going online to search (LP: #1200410)
510+
511+ [Camron]
512+ * Stopwatch runs backwards (LP: #1217743)
513+
514+ [Andrew Starr-Bochicchio]
515+ * Sunrise/Sunset Times should be retrieved online sparingly (LP: #1200410)
516+
517+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 06 Sep 2013 23:26:54 +0200
518+
519+ubuntu-clock-app (0.5) saucy; urgency=low
520+
521+ [Nekhelesh Ramananthan]
522+ * Added background gradients support with proper use of theme palette colors
523+ * Connected Sunrise/Sunset to the current location set by the user (LP: #1195701)
524+ * Fixed inaccurate timer touch input (LP: #1186396, #1168327)
525+ * Fixed second hand moving erratically in mobile devices (LP: #1186279)
526+ * Fixed timer being able to start without setting any time (LP: #1197914)
527+ * Fixed city name going over the search box (LP: #1199379)
528+
529+ [Riccardo Padovani]
530+ * Added support to pause timer (LP: #1166264)
531+ * Added state names to world city search to distinguish cities with duplicate names (LP: #1197436)
532+ * Added autopilot test to test adding a timer (LP: #1188800)
533+ * Added autopilot test to run a saved timer preset (LP: #1188801)
534+ * Added autopilot test to delete a saved timer preset (LP: #1188807)
535+
536+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Tue, 16 Jul 2013 21:24:53 +0200
537+
538+ubuntu-clock-app (0.4) raring; urgency=low
539+
540+ * Added World Clocks
541+ * Added autopilot tests for Stopwatch (LP: #1188796, #1188812, #1188794)
542+ * Implemented initial visual designs for Clock
543+ * Fixed Timer runs slower than expected (LP: #117655)
544+ * Add city clock from toolbar (LP: #1164943)
545+ * Added Animations for Clock, Timer and Stopwatch (LP: #1168325, #1169153)
546+
547+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 14 Jun 2013 22:31:07 +0200
548+
549+ubuntu-clock-app (0.3) raring; urgency=low
550+
551+ * Added translations support
552+
553+ -- David Planella <david.planella@ubuntu.com> Tue, 07 May 2013 16:10:25 +0200
554+
555+ubuntu-clock-app (0.2) raring; urgency=low
556+
557+ [ Nekhelesh Ramananthan ]
558+ * Fix Timer Label bugs (LP: #1172864, #1172865, #1173572).
559+ * Add blip to the stopwatch (LP: #1168468).
560+ * Tweak behavior of timer hand (LP: #1168335).
561+ * Timer format should read mm:ss and count upwards into minutes and hours (LP: #1171467).
562+
563+ [ Alessandro Pozzi ]
564+ * Stopwatch needs to show 1/10th of a second in the label for better accuracy (LP: #1163855).
565+ * Add gradient to the stopwatch second hand (LP: #1168402).
566+
567+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Sun, 28 Apr 2013 15:21:19 +0200
568+
569+ubuntu-clock-app (0.1) raring; urgency=low
570+
571+ [ Michael Hall ]
572+ * Initial release
573+
574+ [ Juha Ristolainen ]
575+ * Implemented basic clock layout
576+
577+ [ Nick Leppänen Larsson ]
578+ * Implemented Analog Clock Face API
579+ * Basic clock layout
580+
581+ [ Nekhelesh Ramananthan ]
582+ * Add copyright/license headers to the clock app files (LP: #1164594)
583+ * Analog clock markers around 3,6,9,12 should be differentiated from others (LP: #1163852)
584+ * Clock app code style does not follow qml, javascript guidelines (LP: #1167040)
585+ * No easy way to set timer for an hour or more (LP: #1163854)
586+
587+ [ Alessandro Pozzi ]
588+ * Timer function requires design for adding and editing presets (LP: #1164443)
589+ * Implemented basic stopwatch functionality
590+
591+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 11 Apr 2013 21:09:19 +0200
592
593=== added file 'debian/compat'
594--- debian/compat 1970-01-01 00:00:00 +0000
595+++ debian/compat 2014-08-13 12:03:59 +0000
596@@ -0,0 +1,1 @@
597+9
598
599=== added file 'debian/control'
600--- debian/control 1970-01-01 00:00:00 +0000
601+++ debian/control 2014-08-13 12:03:59 +0000
602@@ -0,0 +1,43 @@
603+Source: ubuntu-clock-app
604+Priority: extra
605+Maintainer: Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>
606+Build-Depends: cmake,
607+ debhelper (>= 9),
608+ gettext,
609+ intltool,
610+ python3 | python3-all | python3-dev | python3-all-dev,
611+ python3-minimal,
612+ qt5-default,
613+ qtbase5-dev,
614+ qtdeclarative5-dev,
615+Standards-Version: 3.9.5
616+Section: misc
617+Homepage: https://launchpad.net/ubuntu-clock-app
618+Vcs-Bzr: https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0
619+XS-Testsuite: autopkgtest
620+
621+Package: ubuntu-clock-app
622+Architecture: any
623+Depends: qmlscene,
624+ qtdeclarative5-localstorage-plugin,
625+ qtdeclarative5-qtquick2-plugin,
626+ qtdeclarative5-u1db1.0,
627+ qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
628+ qtdeclarative5-xmllistmodel-plugin,
629+ suru-icon-theme | ubuntu-mobile-icons,
630+ ${misc:Depends},
631+ ${shlibs:Depends},
632+Description: Clock application
633+ Ubuntu Core Clock application which provides Alarm, Clock and
634+ World Clock functionalities.
635+
636+Package: ubuntu-clock-app-autopilot
637+Architecture: all
638+Depends: libautopilot-qt,
639+ libqt5test5,
640+ ubuntu-clock-app (>= ${source:Version}),
641+ ubuntu-ui-toolkit-autopilot,
642+ ${misc:Depends},
643+ ${python3:Depends},
644+Description: Autopilot tests for Ubuntu Clock Application
645+ This package contains autopilot tests for the Ubuntu Clock application.
646
647=== added file 'debian/copyright'
648--- debian/copyright 1970-01-01 00:00:00 +0000
649+++ debian/copyright 2014-08-13 12:03:59 +0000
650@@ -0,0 +1,54 @@
651+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
652+Upstream-Name: ubuntu-clock-app
653+Source: https://launchpad.net/ubuntu-clock-app
654+
655+Files: *
656+Copyright: 2013, 2014 Canonical Ltd.
657+ 2013 Alessandro Pozzi <signor.hyde@gmail.com>
658+ 2013 Juha Ristolainen <juha.ristolainen@codemancers.fi>
659+ 2013 Marco Biscaro <marcobiscaro2112@gmail.com>
660+ 2013, 2014 Nekhelesh Ramananthan <krnekhelesh@gmail.com>
661+ 2013 Nick Leppänen Larsson <frals@frals.se>
662+ 2013 Omer Akram <om26er@ubuntu.com>
663+ 2013 Paolo Rotolo <paolorotolo@ubuntu.com>
664+ 2013, 2014 Riccardo Padovani <rpadovani@ubuntu.com>
665+ 2014 Bartosz Kosiorek <gang65@poczta.onet.pl>
666+License: GPL-3
667+
668+Files: debian/*
669+Copyright: 2013, 2014 Canonical Ltd.
670+License: LGPL-3
671+
672+License: GPL-3
673+ This package is free software; you can redistribute it and/or
674+ modify it under the terms of the GNU General Public
675+ License as published by the Free Software Foundation; either
676+ version 3 of the License.
677+ .
678+ This package is distributed in the hope that it will be useful,
679+ but WITHOUT ANY WARRANTY; without even the implied warranty of
680+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
681+ General Public License for more details.
682+ .
683+ You should have received a copy of the GNU General Public License
684+ along with this program. If not, see <http://www.gnu.org/licenses/>.
685+ .
686+ On Debian systems, the complete text of the GNU General
687+ Public License can be found in "/usr/share/common-licenses/GPL-3".
688+
689+License: LGPL-3
690+ This package is free software; you can redistribute it and/or
691+ modify it under the terms of the GNU Lesser General Public
692+ License as published by the Free Software Foundation; either
693+ version 3 of the License.
694+ .
695+ This package is distributed in the hope that it will be useful,
696+ but WITHOUT ANY WARRANTY; without even the implied warranty of
697+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
698+ Lesser General Public License for more details.
699+ .
700+ You should have received a copy of the GNU General Public License
701+ along with this program. If not, see <http://www.gnu.org/licenses/>.
702+ .
703+ On Debian systems, the complete text of the GNU Lesser General
704+ Public License can be found in "/usr/share/common-licenses/LGPL-3".
705
706=== added file 'debian/rules'
707--- debian/rules 1970-01-01 00:00:00 +0000
708+++ debian/rules 2014-08-13 12:03:59 +0000
709@@ -0,0 +1,20 @@
710+#!/usr/bin/make -f
711+# -*- makefile -*-
712+
713+# Uncomment this to turn on verbose mode.
714+#export DH_VERBOSE=1
715+
716+%:
717+ dh $@
718+
719+override_dh_auto_configure:
720+ dh_auto_configure -- -DCLICK_MODE=OFF
721+
722+override_dh_auto_test:
723+ echo
724+
725+override_dh_install:
726+ dh_install --fail-missing
727+
728+override_dh_python3:
729+ dh_python3 -pubuntu-clock-app-autopilot
730
731=== added directory 'debian/tests'
732=== added file 'debian/tests/control'
733--- debian/tests/control 1970-01-01 00:00:00 +0000
734+++ debian/tests/control 2014-08-13 12:03:59 +0000
735@@ -0,0 +1,13 @@
736+Tests: make-autopilot make-test
737+Depends: autopilot-touch,
738+ cmake,
739+ libautopilot-qt,
740+ libqt5test5,
741+ python3-autopilot,
742+ qml-module-qttest,
743+ qt5-default,
744+ qtbase5-dev,
745+ qtdeclarative5-dev,
746+ qtdeclarative5-dev-tools,
747+ ubuntu-ui-toolkit-autopilot
748+Restrictions: build-needed
749
750=== added file 'debian/tests/make-autopilot'
751--- debian/tests/make-autopilot 1970-01-01 00:00:00 +0000
752+++ debian/tests/make-autopilot 2014-08-13 12:03:59 +0000
753@@ -0,0 +1,2 @@
754+#!/bin/sh
755+cd obj*; make autopilot
756
757=== added file 'debian/tests/make-test'
758--- debian/tests/make-test 1970-01-01 00:00:00 +0000
759+++ debian/tests/make-test 2014-08-13 12:03:59 +0000
760@@ -0,0 +1,2 @@
761+#!/bin/sh
762+cd obj*; make test
763
764=== added file 'debian/ubuntu-clock-app-autopilot.install'
765--- debian/ubuntu-clock-app-autopilot.install 1970-01-01 00:00:00 +0000
766+++ debian/ubuntu-clock-app-autopilot.install 2014-08-13 12:03:59 +0000
767@@ -0,0 +1,1 @@
768+/usr/lib/*/dist-packages/ubuntu_clock_app/*
769
770=== added file 'debian/ubuntu-clock-app.install'
771--- debian/ubuntu-clock-app.install 1970-01-01 00:00:00 +0000
772+++ debian/ubuntu-clock-app.install 2014-08-13 12:03:59 +0000
773@@ -0,0 +1,2 @@
774+usr/lib/*/qt5/qml/ClockApp/*
775+usr/share/*
776
777=== modified file 'manifest.json'
778--- manifest.json 2014-08-06 20:14:02 +0000
779+++ manifest.json 2014-08-13 12:03:59 +0000
780@@ -4,15 +4,20 @@
781 "framework": "ubuntu-sdk-14.10-dev2",
782 "architecture": "all",
783 "title": "Clock Reboot",
784+ "icon": "clock@30.png",
785 "hooks": {
786 "ubuntu-clock-app": {
787 "apparmor": "ubuntu-clock-app.json",
788- "desktop": "ubuntu-clock-app.desktop"
789+ "desktop": "share/applications/ubuntu-clock-app.desktop"
790 }
791 },
792- "version": "0.1",
793+ "version": "3.0.@BZR_REVNO@",
794 "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>",
795 "x-test": {
796 "autopilot": "ubuntu_clock_app"
797+ },
798+ "x-source": {
799+ "vcs-bzr": "@BZR_SOURCE@",
800+ "vcs-bzr-revno": "@BZR_REVNO@"
801 }
802-}
803\ No newline at end of file
804+}
805
806=== added file 'tests/CMakeLists.txt'
807--- tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
808+++ tests/CMakeLists.txt 2014-08-13 12:03:59 +0000
809@@ -0,0 +1,1 @@
810+add_subdirectory(autopilot)
811
812=== added file 'tests/autopilot/CMakeLists.txt'
813--- tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +0000
814+++ tests/autopilot/CMakeLists.txt 2014-08-13 12:03:59 +0000
815@@ -0,0 +1,8 @@
816+execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
817+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
818+
819+if(INSTALL_TESTS)
820+ install(DIRECTORY ${AUTOPILOT_DIR}
821+ DESTINATION ${PYTHON_PACKAGE_DIR}
822+ )
823+endif(INSTALL_TESTS)
824
825=== modified file 'tests/autopilot/run' (properties changed: -x to +x)
826--- tests/autopilot/run 2014-07-31 16:58:56 +0000
827+++ tests/autopilot/run 2014-08-13 12:03:59 +0000
828@@ -7,5 +7,7 @@
829
830 SCRIPTPATH=`dirname $0`
831 pushd ${SCRIPTPATH}
832-autopilot run ubuntu-clock-app
833+autopilot run ubuntu_clock_app
834+retcode=$?
835 popd
836+exit $retcode
837
838=== modified file 'tests/autopilot/ubuntu_clock_app/emulators.py'
839--- tests/autopilot/ubuntu_clock_app/emulators.py 2014-08-09 18:09:26 +0000
840+++ tests/autopilot/ubuntu_clock_app/emulators.py 2014-08-13 12:03:59 +0000
841@@ -395,7 +395,8 @@
842 raise ClockEmulatorException('Error deleting alarm.')
843
844
845-class ListItemWithActions(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
846+class ListItemWithActions(
847+ ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
848
849 def swipe_to_delete(self):
850 x, y, width, height = self.globalRect
851
852=== modified file 'tests/autopilot/ubuntu_clock_app/tests/__init__.py'
853--- tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-08-08 22:30:20 +0000
854+++ tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-08-13 12:03:59 +0000
855@@ -19,6 +19,7 @@
856 import os.path
857 import os
858 import shutil
859+import glob
860 import logging
861 import fixtures
862
863@@ -41,13 +42,15 @@
864 """
865
866 local_location = os.path.dirname(os.path.dirname(os.getcwd()))
867- local_location_qml = os.path.join(
868- local_location, 'app/ubuntu-clock-app.qml')
869+ local_location_qml = os.path.join(local_location,
870+ 'app/ubuntu-clock-app.qml')
871 local_location_backend = os.path.join(local_location, 'builddir/backend')
872- installed_location_backend = \
873- '/usr/share/ubuntu-clock-app/builddir/backend'
874+ installed_location_backend = ""
875+ if glob.glob('/usr/lib/*/qt5/qml/ClockApp'):
876+ installed_location_backend = \
877+ glob.glob('/usr/lib/*/qt5/qml/ClockApp')[0]
878 installed_location_qml = \
879- '/usr/share/ubuntu-clock-app/app/ubuntu-clock-app.qml'
880+ '/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml'
881
882 # note this directory could change to com.ubuntu.clock at some point
883 sqlite_dir = os.path.expanduser(
884
885=== modified file 'tests/unit/tst_hellocomponent.qml'
886--- tests/unit/tst_hellocomponent.qml 2014-07-31 16:58:56 +0000
887+++ tests/unit/tst_hellocomponent.qml 2014-08-13 12:03:59 +0000
888@@ -1,7 +1,7 @@
889 import QtQuick 2.0
890 import QtTest 1.0
891 import Ubuntu.Components 0.1
892-import "../../components"
893+import "../../app/components"
894
895 // See more details @ http://qt-project.org/doc/qt-5.0/qtquick/qml-testcase.html
896

Subscribers

People subscribed via source and target branches

to all changes: