Merge lp:~dholbach/ubuntu-clock-app/reboot-packaging into lp:ubuntu-clock-app

Proposed by Daniel Holbach
Status: Superseded
Proposed branch: lp:~dholbach/ubuntu-clock-app/reboot-packaging
Merge into: lp:ubuntu-clock-app
Diff against target: 767 lines (+442/-76)
28 files modified
CMakeLists.txt (+27/-28)
app/CMakeLists.txt (+11/-5)
app/alarm/CMakeLists.txt (+1/-1)
app/clock/CMakeLists.txt (+1/-1)
app/components/CMakeLists.txt (+1/-1)
app/graphics/CMakeLists.txt (+5/-3)
app/upstreamcomponents/CMakeLists.txt (+1/-1)
app/worldclock/CMakeLists.txt (+1/-1)
backend/CMakeLists.txt (+8/-8)
cmake/Click.cmake (+0/-17)
debian/changelog (+197/-0)
debian/compat (+1/-0)
debian/control (+42/-0)
debian/copyright (+54/-0)
debian/rules (+20/-0)
debian/source/format (+1/-0)
debian/tests/control (+13/-0)
debian/tests/make-autopilot (+2/-0)
debian/tests/make-test (+2/-0)
debian/ubuntu-clock-app-autopilot.install (+1/-0)
debian/ubuntu-clock-app.install (+2/-0)
manifest.json (+2/-1)
tests/CMakeLists.txt (+1/-0)
tests/autopilot/CMakeLists.txt (+8/-0)
tests/autopilot/run (+3/-1)
tests/autopilot/ubuntu_clock_app/emulators.py (+2/-1)
tests/autopilot/ubuntu_clock_app/tests/__init__.py (+34/-6)
tests/unit/tst_hellocomponent.qml (+1/-1)
To merge this branch: bzr merge lp:~dholbach/ubuntu-clock-app/reboot-packaging
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Sergio Schvezov (community) Needs Fixing
Ubuntu Clock Developers Pending
Review via email: mp+229173@code.launchpad.net

This proposal has been superseded by a proposal from 2014-08-12.

Commit message

Various changes to the packaging to make it work with the newest ubuntu-clock-app.

To post a comment you must log in.
43. By Daniel Holbach

Run 'make autopilot' during the build instead of 'make test'.

44. By Daniel Holbach

Rename 'ubuntu-clock-app' to 'ubuntu_clock_app' in tests.

45. By Daniel Holbach

Don't try to install files from usr/bin, there are none.

46. By Daniel Holbach

Fail if not all files can be installed.

47. By Daniel Holbach

* Use CMake's testing framework instead of a custom target.
* Only install manifest in click mode.
* Spaces are tabs.
* Add a CMake option to build both as a click app and a regular one.

48. By Daniel Holbach

return to previous version of CMakeLists.txt - looks like the necessary changes were implemented already

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:42
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/97/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1247/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/97/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/97/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:48
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/98/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1248/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/98/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/98/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Can you merge trunk as it now has a working autopilot test. I will follow up with sergieusens asap.

49. By Daniel Holbach

Revert 'Rename 'ubuntu-clock-app' to 'ubuntu_clock_app' in tests.'

50. By Daniel Holbach

merge from trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:50
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging/+merge/229173/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/108/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1284/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-utopic-amd64-ci/108/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/108/rebuild

review: Needs Fixing (continuous-integration)
51. By Daniel Holbach

adjust to new test paths

52. By Daniel Holbach

* Install files from usr/lib.
* Make ubuntu-clock-app Arch:any.
* Don't install 'ubuntu-clock-app-autopilot' files for now.
  Bits in the cmake installation have to be fixed.

53. By Daniel Holbach

Add ${shlibs:Depends} to Depends.

54. By Daniel Holbach

Remove duplicate 'Section' definition.

55. By Daniel Holbach

Relax dependency from ubuntu-clock-app-autopilot on ubuntu-clock-app
somewhat.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Daniel, I got the "make autopilot" to work. The first fix needed was already done by you in rev 51 (adjusting CMakeList.txt file to point at the new test path). The second fix needed is to rename ubuntu-clock-app to ubuntu_clock_app in the tests/autopilot/run file.

=== modified file 'tests/autopilot/run' (properties changed: -x to +x)
--- tests/autopilot/run 2014-07-31 16:58:56 +0000
+++ tests/autopilot/run 2014-08-05 10:13:21 +0000
@@ -7,5 +7,5 @@

 SCRIPTPATH=`dirname $0`
 pushd ${SCRIPTPATH}
-autopilot run ubuntu-clock-app
+autopilot run ubuntu_clock_app

After which I get it passing,

nik90@nik90-devel:~/Clock/add-alarm-test/builddir$ make autopilot
[ 0%] Built target alarmsettings-qmldir
[ 7%] Automoc for target timezone
[ 7%] Built target timezone_automoc
[ 42%] Built target timezone
[ 50%] Automoc for target datetime
[ 50%] Built target datetime_automoc
[ 71%] Built target datetime
[ 78%] Automoc for target alarmsettings
[ 78%] Built target alarmsettings_automoc
[100%] Built target alarmsettings
[100%] Built target timezone-qmldir
[100%] Built target datetime-qmldir
~/Clock/add-alarm-test/tests/autopilot ~/Clock/add-alarm-test/builddir/app
Loading tests from: /home/nik90/Clock/add-alarm-test/tests/autopilot

Tests running...

Ran 1 test in 48.013s
OK
~/Clock/add-alarm-test/builddir/app
[100%] Built target autopilot

56. By Daniel Holbach

rename ubuntu-clock-app to ubuntu_clock_app

57. By Daniel Holbach

add build-depends for running 'make autopilot', run 'wrap-and-sort'

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel Holbach (dholbach) wrote :

A number of files are not installed in the right place or not present/installed at all:

 - backend/ directory is missing
 - files in usr/lib probably need their own, a bit more descriptive directory name
 - files for the -autopilot package are not installed anywhere
 - .desktop file.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

one inline comment for now, more later

review: Needs Fixing
Revision history for this message
Daniel Holbach (dholbach) wrote :
58. By Daniel Holbach

Run tests as autopkgtest. (LP: #1354091)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
59. By Daniel Holbach

Don't return ignore of autopilot test execution. (LP: #1354095)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
60. By Daniel Holbach

* Using GnuInstallDirs takes care of the arch triplet.
* Used a proper qt_imports_dir (still needs qml import updates).
* Moved gnuinstalldirs higher up for better path management.
* Removed a bunch of very custom variables and build on top.
* Removed the install target for the gallery directory as it was a dup
  and going to the wrong path.
* Not installing icon for deb and just rely on us using the desktop
  default (we can depend on the suru icon set, it's there).
* Made some rules filter out if not in qtcreator.
* Changed the path for a couple of things to use common subpaths in most
  cases.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
61. By Daniel Holbach

Fix path in Exec= line of .desktop file. (LP: #1354081)

62. By Daniel Holbach

fix changelog entry

63. By Daniel Holbach

Move module files into proper place. (LP: #1354079)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
64. By Daniel Holbach

fix tests path for basic testcase

65. By Daniel Holbach

get 'make test' closer to actually working

66. By Daniel Holbach

merge from trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
67. By Daniel Holbach

fix path location for upstreamcomponents

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
68. By Daniel Holbach

make pep8 happy

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
69. By Daniel Holbach

generalise local paths in tests somewhat

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
70. By Daniel Holbach

Make pep8 happy.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
71. By Daniel Holbach

bring installation path more closely in line with other apps

72. By Daniel Holbach

Add -I argument to Exec line in .desktop file.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
73. By Daniel Holbach

Install files into ubuntu-clock-app-autopilot again (LP: #1354074).

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
74. By Daniel Holbach

merge from trunk

75. By Daniel Holbach

merged lp:~nskaggs/ubuntu-clock-app/fix-ap-setup - resolve conflicts

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
76. By Daniel Holbach

remove 'builddir' portion from system-installed paths

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
77. By Daniel Holbach

merge from trunk

78. By Daniel Holbach

merge from trunk

79. By Daniel Holbach

Don't force python3. For some reason that seems to fail with qtcreator.

Unmerged revisions

79. By Daniel Holbach

Don't force python3. For some reason that seems to fail with qtcreator.

78. By Daniel Holbach

merge from trunk

77. By Daniel Holbach

merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-07-26 09:34:15 +0000
3+++ CMakeLists.txt 2014-08-11 16:19:22 +0000
4@@ -2,7 +2,6 @@
5 cmake_minimum_required(VERSION 2.8.9)
6
7 set (UBUNTU_PROJECT_TYPE "ClickApp" CACHE INTERNAL "Tells QtCreator this is a Click application project")
8-set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
9 set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")
10
11 find_package(Qt5Core)
12@@ -20,51 +19,51 @@
13 set(APP_NAME clock)
14 set(APP_HARDCODE ubuntu-clock-app)
15 set(MAIN_QML ${APP_HARDCODE}.qml)
16-set(ICON clock-app@30.png)
17+set(ICON clock-app)
18+SET(AUTOPILOT_DIR ubuntu_clock_app)
19+
20+# Standard install paths
21+include(GNUInstallDirs)
22
23 #set install paths
24-if(${CLICK_MODE})
25- set(CMAKE_INSTALL_PREFIX /)
26- set(DATA_DIR /)
27- set(DESKTOP_DIR ${DATA_DIR})
28- set(UBUNTU-CLOCK-APP_DIR "share/qml/ubuntu-clock-app")
29- set(ICON "${UBUNTU-CLOCK-APP_DIR}/${ICON}")
30+if(CLICK_MODE)
31+ set(CMAKE_INSTALL_PREFIX "/")
32+ set(UBUNTU-CLOCK_APP_DIR "${CMAKE_INSTALL_DATADIR}/qml")
33
34- execute_process(
35- COMMAND dpkg-architecture -qDEB_HOST_MULTIARCH
36- OUTPUT_VARIABLE ARCH_TRIPLET
37- OUTPUT_STRIP_TRAILING_WHITESPACE
38- )
39- set(QT_IMPORTS_DIR "lib/${ARCH_TRIPLET}")
40-else()
41- set(DATA_DIR "share/clockapp")
42- set(DESKTOP_DIR ${DATA_DIR})
43- set(ICON "${DATA_DIR}/${ICON}")
44- set(UBUNTU-CLOCK-APP_DIR "share/ubuntu-clock-app/qml")
45- include(GNUInstallDirs)
46 set(QT_IMPORTS_DIR "${CMAKE_INSTALL_LIBDIR}")
47-endif()
48-
49-set(EXEC "qmlscene $@ ${UBUNTU-CLOCK-APP_DIR}/${MAIN_QML}")
50+ set(EXEC "qmlscene $@ ${UBUNTU-CLOCK_APP_DIR}/${MAIN_QML}")
51+else(CLICK_MODE)
52+ set(UBUNTU-CLOCK_APP_DIR "${CMAKE_INSTALL_DATADIR}/ubuntu-clock-app")
53+ execute_process(
54+ COMMAND qmake -query QT_INSTALL_QML
55+ OUTPUT_VARIABLE QT_IMPORTS_DIR
56+ OUTPUT_STRIP_TRAILING_WHITESPACE
57+ )
58+
59+endif(CLICK_MODE)
60+
61+set(MODULE_PATH ${QT_IMPORTS_DIR}/ClockApp)
62
63 if(${CLICK_MODE})
64 install(FILES manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
65+ install(FILES "${APP_HARDCODE}.json" DESTINATION ${CMAKE_INSTALL_DATADIR})
66+else(CLICK_MODE)
67+ set(EXEC "qmlscene $@ -I ${MODULE_PATH} ${CMAKE_INSTALL_PREFIX}/${UBUNTU-CLOCK_APP_DIR}/${MAIN_QML}")
68 endif()
69-install(DIRECTORY "app/graphics" DESTINATION ${DATA_DIR})
70-install(FILES "${APP_HARDCODE}.json" DESTINATION ${DATA_DIR})
71
72 add_subdirectory(app)
73 add_subdirectory(backend)
74+add_subdirectory(tests)
75
76-add_custom_target("autopilot" chmod +x ${CMAKE_SOURCE_DIR}/app/tests/autopilot/run
77- COMMAND ${CMAKE_SOURCE_DIR}/app/tests/autopilot/run
78+add_custom_target("autopilot" chmod +x ${CMAKE_SOURCE_DIR}/tests/autopilot/run
79+ COMMAND ${CMAKE_SOURCE_DIR}/tests/autopilot/run
80 DEPENDS timezone timezone-qmldir alarmsettings alarmsettings-qmldir datetime datetime-qmldir
81 WORKING_DIRECTORY ./app)
82
83 enable_testing()
84 add_test(NAME basic
85 WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/app
86- COMMAND /usr/bin/qmltestrunner -input ${CMAKE_SOURCE_DIR}/app/tests/unit -import ${CMAKE_BINARY_DIR}/backend
87+ COMMAND /usr/bin/qmltestrunner -input ${CMAKE_SOURCE_DIR}/tests/unit -import ${CMAKE_BINARY_DIR}/backend
88 )
89
90 add_custom_target("run" /usr/bin/qmlscene -I ${CMAKE_BINARY_DIR}/backend ${CMAKE_SOURCE_DIR}/app/ubuntu-clock-app.qml
91
92=== modified file 'app/CMakeLists.txt'
93--- app/CMakeLists.txt 2014-07-28 13:02:59 +0000
94+++ app/CMakeLists.txt 2014-08-11 16:19:22 +0000
95@@ -1,14 +1,20 @@
96-file(GLOB QML_JS_FILES *.qml *.js *.png)
97-
98-# make the files visible on qtcreator
99+if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
100 add_custom_target(ubuntu-clock-app_QMlFiles ALL SOURCES ${QML_JS_FILES})
101+endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
102+
103+
104+if(CLICK_MODE)
105+ set(ICON "${ICON}@30.png")
106+ install(FILES ${ICON} DESTINATION ${CMAKE_INSTALL_PREFIX})
107+endif(CLICK_MODE)
108
109 # substitute variables in the desktop file
110 set(DESKTOP_FILE "ubuntu-clock-app.desktop")
111 configure_file(${DESKTOP_FILE}.in ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE})
112
113-install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE} DESTINATION ${DESKTOP_DIR})
114-install(FILES ${QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR})
115+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
116+ DESTINATION ${CMAKE_INSTALL_DATADIR}/applications)
117+install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CLOCK_APP_DIR})
118
119 add_subdirectory(clock)
120 add_subdirectory(alarm)
121
122=== modified file 'app/alarm/CMakeLists.txt'
123--- app/alarm/CMakeLists.txt 2014-06-16 14:09:12 +0000
124+++ app/alarm/CMakeLists.txt 2014-08-11 16:19:22 +0000
125@@ -3,4 +3,4 @@
126 # make the files visible in the qtcreator tree
127 add_custom_target(ubuntu-clock-app_alarm_QMlFiles ALL SOURCES ${ALARM_QML_JS_FILES})
128
129-install(FILES ${ALARM_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/alarm)
130+install(FILES ${ALARM_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/alarm)
131
132=== modified file 'app/clock/CMakeLists.txt'
133--- app/clock/CMakeLists.txt 2014-06-06 18:45:49 +0000
134+++ app/clock/CMakeLists.txt 2014-08-11 16:19:22 +0000
135@@ -3,4 +3,4 @@
136 # make the files visible in the qtcreator tree
137 add_custom_target(ubuntu-clock-app_clock_QMlFiles ALL SOURCES ${CLOCK_QML_JS_FILES})
138
139-install(FILES ${CLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/clock)
140+install(FILES ${CLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/clock)
141
142=== modified file 'app/components/CMakeLists.txt'
143--- app/components/CMakeLists.txt 2014-06-06 18:45:49 +0000
144+++ app/components/CMakeLists.txt 2014-08-11 16:19:22 +0000
145@@ -3,4 +3,4 @@
146 # make the files visible in the qtcreator tree
147 add_custom_target(ubuntu-clock-app_components_QMlFiles ALL SOURCES ${COMPONENTS_QML_JS_FILES})
148
149-install(FILES ${COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/components)
150+install(FILES ${COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/components)
151
152=== modified file 'app/graphics/CMakeLists.txt'
153--- app/graphics/CMakeLists.txt 2014-06-06 18:45:49 +0000
154+++ app/graphics/CMakeLists.txt 2014-08-11 16:19:22 +0000
155@@ -1,6 +1,8 @@
156-file(GLOB IMAGES_PNG_FILES *.png *.jpg)
157+file(GLOB GRAPHICS_FILES *.png *.jpg)
158
159 # make the files visible in the qtcreator tree
160-add_custom_target(ubuntu-clock-app_graphics_PNGFiles ALL SOURCES ${IMAGES_PNG_FILES})
161+if(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
162+ add_custom_target(ubuntu-clock-app_graphics_PNGFiles ALL SOURCES ${IMAGES_PNG_FILES})
163+endif(NOT "${CMAKE_CURRENT_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_BINARY_DIR}")
164
165-install(FILES ${IMAGES_PNG_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/graphics)
166+install(FILES ${GRAPHICS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/graphics)
167
168=== modified file 'app/upstreamcomponents/CMakeLists.txt'
169--- app/upstreamcomponents/CMakeLists.txt 2014-07-28 13:02:59 +0000
170+++ app/upstreamcomponents/CMakeLists.txt 2014-08-11 16:19:22 +0000
171@@ -3,4 +3,4 @@
172 # make the files visible in the qtcreator tree
173 add_custom_target(ubuntu-clock-app_upstream_components_QMlFiles ALL SOURCES ${UPSTREAM_COMPONENTS_QML_JS_FILES})
174
175-install(FILES ${UPSTREAM_COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/upstreamcomponents)
176+install(FILES ${UPSTREAM_COMPONENTS_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/upstreamcomponents)
177
178=== modified file 'app/worldclock/CMakeLists.txt'
179--- app/worldclock/CMakeLists.txt 2014-07-13 11:18:31 +0000
180+++ app/worldclock/CMakeLists.txt 2014-08-11 16:19:22 +0000
181@@ -3,4 +3,4 @@
182 # make the files visible in the qtcreator tree
183 add_custom_target(ubuntu-clock-app_worldclock_QMlFiles ALL SOURCES ${WORLDCLOCK_QML_JS_FILES})
184
185-install(FILES ${WORLDCLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK-APP_DIR}/worldclock)
186+install(FILES ${WORLDCLOCK_QML_JS_FILES} DESTINATION ${UBUNTU-CLOCK_APP_DIR}/worldclock)
187
188=== modified file 'backend/CMakeLists.txt'
189--- backend/CMakeLists.txt 2014-07-26 09:34:15 +0000
190+++ backend/CMakeLists.txt 2014-08-11 16:19:22 +0000
191@@ -67,11 +67,11 @@
192 )
193
194 # Install plugin file
195-install(TARGETS timezone DESTINATION ${QT_IMPORTS_DIR}/Timezone/)
196-install(FILES modules/Timezone/qmldir DESTINATION ${QT_IMPORTS_DIR}/Timezone/)
197-
198-install(TARGETS datetime DESTINATION ${QT_IMPORTS_DIR}/DateTime/)
199-install(FILES modules/DateTime/qmldir DESTINATION ${QT_IMPORTS_DIR}/DateTime/)
200-
201-install(TARGETS alarmsettings DESTINATION ${QT_IMPORTS_DIR}/Alarm/Settings/)
202-install(FILES modules/Alarm/Settings/qmldir DESTINATION ${QT_IMPORTS_DIR}/Alarm/Settings/)
203+install(TARGETS timezone DESTINATION ${MODULE_PATH}/Timezone/)
204+install(FILES modules/Timezone/qmldir DESTINATION ${MODULE_PATH}/Timezone/)
205+
206+install(TARGETS datetime DESTINATION ${MODULE_PATH}/DateTime/)
207+install(FILES modules/DateTime/qmldir DESTINATION ${MODULE_PATH}/DateTime/)
208+
209+install(TARGETS alarmsettings DESTINATION ${MODULE_PATH}/Alarm/Settings/)
210+install(FILES modules/Alarm/Settings/qmldir DESTINATION ${MODULE_PATH}/Alarm/Settings/)
211
212=== removed directory 'cmake'
213=== removed file 'cmake/Click.cmake'
214--- cmake/Click.cmake 2014-06-06 18:45:49 +0000
215+++ cmake/Click.cmake 1970-01-01 00:00:00 +0000
216@@ -1,17 +0,0 @@
217-if(CLICK_MODE)
218- STRING(REPLACE "/usr/" "/" QT_IMPORTS_DIR ${QT_IMPORTS_DIR})
219- set(CMAKE_INSTALL_PREFIX /)
220- set(CMAKE_INSTALL_BINDIR /)
221- set(DATA_DIR /)
222- set(EXEC "qmlscene $@ -I .${QT_IMPORTS_DIR} ${UBUNTU-CLOCK-APP_DIR}/${MAIN_QML}")
223- set(DESKTOP_DIR ${DATA_DIR})
224- set(ICON ".${DATA_DIR}/${ICON}")
225- install(FILES manifest.json DESTINATION ${CMAKE_INSTALL_PREFIX})
226- install(DIRECTORY "app/graphics" DESTINATION ${DATA_DIR})
227- install(FILES "${CMAKE_PROJECT_NAME}.json" DESTINATION ${DATA_DIR})
228-else(CLICK_MODE)
229- set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_NAME})
230- set(EXEC "qmlscene $@ ${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/qml/${MAIN_QML}")
231- set(ICON "${CMAKE_INSTALL_PREFIX}/${DATA_DIR}/${ICON}")
232- set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
233-endif(CLICK_MODE)
234
235=== added directory 'debian'
236=== added file 'debian/changelog'
237--- debian/changelog 1970-01-01 00:00:00 +0000
238+++ debian/changelog 2014-08-11 16:19:22 +0000
239@@ -0,0 +1,197 @@
240+ubuntu-clock-app (1.2) utopic; urgency=medium
241+
242+ [ Daniel Holbach ]
243+ * Fix debhelper-but-no-misc-depends ubuntu-clock-app-autopilot.
244+ * Bump Standards-Version to 3.9.5, no changes required.
245+ * Add missing build-depends.
246+ * Run 'wrap-and-sort'.
247+ * Don't try to install files from usr/bin, there are none.
248+ * Install files from usr/lib.
249+ * Fail if not all files can be installed.
250+ * Make ubuntu-clock-app Arch:any.
251+ * Install files into ubuntu-clock-app-autopilot again (LP: #1354074).
252+ * Add ${shlibs:Depends} to Depends.
253+ * Remove duplicate 'Section' definition.
254+ * Relax dependency from ubuntu-clock-app-autopilot on ubuntu-clock-app
255+ somewhat.
256+ * Run tests as autopkgtest. (LP: #1354091)
257+ * Don't ignore return code of autopilot test execution. (LP: #1354095)
258+ * Fix path in Exec= line of .desktop file. (LP: #1354081)
259+ * Move module files into proper place. (LP: #1354079)
260+ * Make pep8 happy.
261+ * Add -I argument to Exec line in .desktop file.
262+
263+ [ Jussi Pakkanen ]
264+ * Use CMake's testing framework instead of a custom target.
265+ * Only install manifest in click mode.
266+ * Spaces are tabs.
267+ * Add a CMake option to build both as a click app and a regular one.
268+
269+ [ Sergio Schvezov ]
270+ * Using GnuInstallDirs takes care of the arch triplet.
271+ * Used a proper qt_imports_dir (still needs qml import updates).
272+ * Moved gnuinstalldirs higher up for better path management.
273+ * Removed a bunch of very custom variables and build on top.
274+ * Removed the install target for the gallery directory as it was a dup
275+ and going to the wrong path.
276+ * Not installing icon for deb and just rely on us using the desktop
277+ default (we can depend on the suru icon set, it's there).
278+ * Made some rules filter out if not in qtcreator.
279+ * Changed the path for a couple of things to use common subpaths in most
280+ cases.
281+
282+ -- Daniel Holbach <daniel.holbach@ubuntu.com> Fri, 01 Aug 2014 09:16:35 +0200
283+
284+ubuntu-clock-app (1.1) raring; urgency=medium
285+
286+ * New icon
287+ * Add -qt5 command line option (LP: #1288885)
288+ * Update framework and apparmor profile version
289+
290+ -- Alan Pope <popey@ubuntu.com> Fri, 02 May 2014 13:57:25 +0100
291+
292+ubuntu-clock-app (1.0) saucy; urgency=low
293+
294+ [Nekhelesh Ramananthan]
295+ * World Clock list needs to inform user when results cannot be retrieved due to network error (LP: #1231106)
296+ * Load premade presets for new user so user doesn't end up in blank app (LP: #1226131)
297+ * Return more fine-grained territorial divisions for city search results (LP: #1230153)
298+ * Improve the visual appearance of the clock, timer, stopwatch and alarm
299+ * Removed hour support from timer
300+
301+ [Sergio Schvezov]
302+ * Translation for desktop and debian package
303+ * Fix click package confinement issues
304+
305+ [Riccardo Padovani]
306+ * Alarm notifications do not appear when an alarm is triggered (LP: #1233176)
307+
308+ [Nicholas Skaggs]
309+ * Several apps have failing tests with 20131003 ui-toolkit (LP: #1234544)
310+
311+ [Andrea Cerisara]
312+ * Autopilot Testcase Needed: Test Add World Clock (LP: #1210196)
313+ * Autopilot Testcase Needed: Test Delete World Clock (LP: #1210197)
314+
315+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 11 Oct 2013 01:45:36 +0200
316+
317+ubuntu-clock-app (0.7) saucy; urgency=low
318+
319+ [Nekhelesh Ramananthan]
320+ * Alarm doesn't work (LP: #1187994)
321+ * Clock app does not honor timezone (LP: #1191291)
322+ * Clocks need to sync better and use the same backend (LP: #1201830)
323+ * Clock reports time in UTC by default (LP: #1201858)
324+ * On scrolling down page, hide tab header (LP: #1226128)
325+ * Very difficult to select bottom city in scrollable list of 4 or more (LP: #1227674)
326+ * There is no effect on the circle shape (LP: #1215332)
327+ * HUD actions should not appear for toolbar button such as save or cancel (LP: #1224891)
328+
329+ [Paolo Rotolo]
330+ * Add error message if no cities were found (LP: #1222235)
331+ * Timer label updates before the timer hand reaches destination (LP: #1172869)
332+ * Cancel toolbar action needs the correct icon (LP: #1222942)
333+
334+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 27 Sep 2013 12:47:21 +0200
335+
336+ubuntu-clock-app (0.6) saucy; urgency=low
337+
338+ [Nekhelesh Ramananthan]
339+ * Digital clock font size is smaller than design spec (LP: #1215334)
340+ * Font in world city list are too big (LP: #1200594)
341+ * Timer does not inform user if there are no presets (LP: #1169182)
342+ * Clicking the Add preset or add city button should reflect on the title for visual feedback (LP: #1168329)
343+ * In Timer, clock face is off screen when selecting preset (LP: #1219770)
344+ * Toolbar prevents text preset from accepting input (LP: #1209024)
345+
346+ [Paolo Rotolo]
347+ * Search button icon is not as per design specifications (LP: #1221252)
348+ * Search icon isn't in Ubuntu Touch Style (LP: #1202364)
349+ * Reset button doesn't work while the stopwatch is running (LP: #1204861)
350+ * Timer sometimes does not reset its clock hands after stopping it (LP: #1197908)
351+ * Provide the ability to delete a stopwatch lap (LP: #1220375)
352+ * Scrolling list of cities overlaps labels (LP: #1219768)
353+ * Reset and lap icons appear pixelated on a phone (LP: #1218751)
354+ * While searching world cities provide a small pause before going online to search (LP: #1200410)
355+
356+ [Camron]
357+ * Stopwatch runs backwards (LP: #1217743)
358+
359+ [Andrew Starr-Bochicchio]
360+ * Sunrise/Sunset Times should be retrieved online sparingly (LP: #1200410)
361+
362+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 06 Sep 2013 23:26:54 +0200
363+
364+ubuntu-clock-app (0.5) saucy; urgency=low
365+
366+ [Nekhelesh Ramananthan]
367+ * Added background gradients support with proper use of theme palette colors
368+ * Connected Sunrise/Sunset to the current location set by the user (LP: #1195701)
369+ * Fixed inaccurate timer touch input (LP: #1186396, #1168327)
370+ * Fixed second hand moving erratically in mobile devices (LP: #1186279)
371+ * Fixed timer being able to start without setting any time (LP: #1197914)
372+ * Fixed city name going over the search box (LP: #1199379)
373+
374+ [Riccardo Padovani]
375+ * Added support to pause timer (LP: #1166264)
376+ * Added state names to world city search to distinguish cities with duplicate names (LP: #1197436)
377+ * Added autopilot test to test adding a timer (LP: #1188800)
378+ * Added autopilot test to run a saved timer preset (LP: #1188801)
379+ * Added autopilot test to delete a saved timer preset (LP: #1188807)
380+
381+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Tue, 16 Jul 2013 21:24:53 +0200
382+
383+ubuntu-clock-app (0.4) raring; urgency=low
384+
385+ * Added World Clocks
386+ * Added autopilot tests for Stopwatch (LP: #1188796, #1188812, #1188794)
387+ * Implemented initial visual designs for Clock
388+ * Fixed Timer runs slower than expected (LP: #117655)
389+ * Add city clock from toolbar (LP: #1164943)
390+ * Added Animations for Clock, Timer and Stopwatch (LP: #1168325, #1169153)
391+
392+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Fri, 14 Jun 2013 22:31:07 +0200
393+
394+ubuntu-clock-app (0.3) raring; urgency=low
395+
396+ * Added translations support
397+
398+ -- David Planella <david.planella@ubuntu.com> Tue, 07 May 2013 16:10:25 +0200
399+
400+ubuntu-clock-app (0.2) raring; urgency=low
401+
402+ [ Nekhelesh Ramananthan ]
403+ * Fix Timer Label bugs (LP: #1172864, #1172865, #1173572).
404+ * Add blip to the stopwatch (LP: #1168468).
405+ * Tweak behavior of timer hand (LP: #1168335).
406+ * Timer format should read mm:ss and count upwards into minutes and hours (LP: #1171467).
407+
408+ [ Alessandro Pozzi ]
409+ * Stopwatch needs to show 1/10th of a second in the label for better accuracy (LP: #1163855).
410+ * Add gradient to the stopwatch second hand (LP: #1168402).
411+
412+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Sun, 28 Apr 2013 15:21:19 +0200
413+
414+ubuntu-clock-app (0.1) raring; urgency=low
415+
416+ [ Michael Hall ]
417+ * Initial release
418+
419+ [ Juha Ristolainen ]
420+ * Implemented basic clock layout
421+
422+ [ Nick Leppänen Larsson ]
423+ * Implemented Analog Clock Face API
424+ * Basic clock layout
425+
426+ [ Nekhelesh Ramananthan ]
427+ * Add copyright/license headers to the clock app files (LP: #1164594)
428+ * Analog clock markers around 3,6,9,12 should be differentiated from others (LP: #1163852)
429+ * Clock app code style does not follow qml, javascript guidelines (LP: #1167040)
430+ * No easy way to set timer for an hour or more (LP: #1163854)
431+
432+ [ Alessandro Pozzi ]
433+ * Timer function requires design for adding and editing presets (LP: #1164443)
434+ * Implemented basic stopwatch functionality
435+
436+ -- Nekhelesh Ramananthan <krnekhelesh@gmail.com> Thu, 11 Apr 2013 21:09:19 +0200
437
438=== added file 'debian/compat'
439--- debian/compat 1970-01-01 00:00:00 +0000
440+++ debian/compat 2014-08-11 16:19:22 +0000
441@@ -0,0 +1,1 @@
442+9
443
444=== added file 'debian/control'
445--- debian/control 1970-01-01 00:00:00 +0000
446+++ debian/control 2014-08-11 16:19:22 +0000
447@@ -0,0 +1,42 @@
448+Source: ubuntu-clock-app
449+Priority: extra
450+Maintainer: Ubuntu App Cats <ubuntu-touch-coreapps@lists.launchpad.net>
451+Build-Depends: cmake,
452+ debhelper (>= 9),
453+ gettext,
454+ intltool,
455+ python3 | python3-all | python3-dev | python3-all-dev,
456+ python3-minimal,
457+ qt5-default,
458+ qtbase5-dev,
459+ qtdeclarative5-dev
460+Standards-Version: 3.9.5
461+Section: misc
462+Homepage: https://launchpad.net/ubuntu-clock-app
463+Vcs-Bzr: https://code.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/trunk
464+XS-Testsuite: autopkgtest
465+
466+Package: ubuntu-clock-app
467+Architecture: any
468+Depends: qmlscene,
469+ qtdeclarative5-localstorage-plugin,
470+ qtdeclarative5-qtquick2-plugin,
471+ qtdeclarative5-u1db1.0,
472+ qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
473+ qtdeclarative5-xmllistmodel-plugin,
474+ suru-icon-theme | ubuntu-mobile-icons,
475+ ${misc:Depends},
476+ ${shlibs:Depends}
477+Description: Clock application
478+ Ubuntu Core Clock application which provides Stopwatch, Timer, Alarm and Clock functionalities.
479+
480+Package: ubuntu-clock-app-autopilot
481+Architecture: all
482+Depends: libautopilot-qt,
483+ libqt5test5,
484+ ubuntu-clock-app (>= ${source:Version}),
485+ ubuntu-ui-toolkit-autopilot,
486+ ${misc:Depends},
487+ ${python3:Depends}
488+Description: Autopilot tests for Ubuntu Clock Application
489+ This package contains autopilot tests for the Ubuntu Clock application.
490
491=== added file 'debian/copyright'
492--- debian/copyright 1970-01-01 00:00:00 +0000
493+++ debian/copyright 2014-08-11 16:19:22 +0000
494@@ -0,0 +1,54 @@
495+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
496+Upstream-Name: ubuntu-clock-app
497+Source: https://launchpad.net/ubuntu-clock-app
498+
499+Files: *
500+Copyright: 2013, 2014 Canonical Ltd.
501+ 2013 Alessandro Pozzi <signor.hyde@gmail.com>
502+ 2013 Juha Ristolainen <juha.ristolainen@codemancers.fi>
503+ 2013 Marco Biscaro <marcobiscaro2112@gmail.com>
504+ 2013, 2014 Nekhelesh Ramananthan <krnekhelesh@gmail.com>
505+ 2013 Nick Leppänen Larsson <frals@frals.se>
506+ 2013 Omer Akram <om26er@ubuntu.com>
507+ 2013 Paolo Rotolo <paolorotolo@ubuntu.com>
508+ 2013, 2014 Riccardo Padovani <rpadovani@ubuntu.com>
509+ 2014 Bartosz Kosiorek <gang65@poczta.onet.pl>
510+License: GPL-3
511+
512+Files: debian/*
513+Copyright: 2013, 2014 Canonical Ltd.
514+License: LGPL-3
515+
516+License: GPL-3
517+ This package is free software; you can redistribute it and/or
518+ modify it under the terms of the GNU General Public
519+ License as published by the Free Software Foundation; either
520+ version 3 of the License.
521+ .
522+ This package is distributed in the hope that it will be useful,
523+ but WITHOUT ANY WARRANTY; without even the implied warranty of
524+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
525+ General Public License for more details.
526+ .
527+ You should have received a copy of the GNU General Public License
528+ along with this program. If not, see <http://www.gnu.org/licenses/>.
529+ .
530+ On Debian systems, the complete text of the GNU General
531+ Public License can be found in "/usr/share/common-licenses/GPL-3".
532+
533+License: LGPL-3
534+ This package is free software; you can redistribute it and/or
535+ modify it under the terms of the GNU Lesser General Public
536+ License as published by the Free Software Foundation; either
537+ version 3 of the License.
538+ .
539+ This package is distributed in the hope that it will be useful,
540+ but WITHOUT ANY WARRANTY; without even the implied warranty of
541+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
542+ Lesser General Public License for more details.
543+ .
544+ You should have received a copy of the GNU General Public License
545+ along with this program. If not, see <http://www.gnu.org/licenses/>.
546+ .
547+ On Debian systems, the complete text of the GNU Lesser General
548+ Public License can be found in "/usr/share/common-licenses/LGPL-3".
549
550=== added file 'debian/rules'
551--- debian/rules 1970-01-01 00:00:00 +0000
552+++ debian/rules 2014-08-11 16:19:22 +0000
553@@ -0,0 +1,20 @@
554+#!/usr/bin/make -f
555+# -*- makefile -*-
556+
557+# Uncomment this to turn on verbose mode.
558+#export DH_VERBOSE=1
559+
560+%:
561+ dh $@
562+
563+override_dh_auto_configure:
564+ dh_auto_configure -- -DCLICK_MODE=OFF
565+
566+override_dh_auto_test:
567+ echo
568+
569+override_dh_install:
570+ dh_install --fail-missing
571+
572+override_dh_python3:
573+ dh_python3 -pubuntu-clock-app-autopilot
574
575=== added directory 'debian/source'
576=== added file 'debian/source/format'
577--- debian/source/format 1970-01-01 00:00:00 +0000
578+++ debian/source/format 2014-08-11 16:19:22 +0000
579@@ -0,0 +1,1 @@
580+1.0
581
582=== added directory 'debian/tests'
583=== added file 'debian/tests/control'
584--- debian/tests/control 1970-01-01 00:00:00 +0000
585+++ debian/tests/control 2014-08-11 16:19:22 +0000
586@@ -0,0 +1,13 @@
587+Tests: make-autopilot make-test
588+Depends: autopilot-touch,
589+ cmake,
590+ libautopilot-qt,
591+ libqt5test5,
592+ python3-autopilot,
593+ qml-module-qttest,
594+ qt5-default,
595+ qtbase5-dev,
596+ qtdeclarative5-dev,
597+ qtdeclarative5-dev-tools,
598+ ubuntu-ui-toolkit-autopilot
599+Restrictions: build-needed
600
601=== added file 'debian/tests/make-autopilot'
602--- debian/tests/make-autopilot 1970-01-01 00:00:00 +0000
603+++ debian/tests/make-autopilot 2014-08-11 16:19:22 +0000
604@@ -0,0 +1,2 @@
605+#!/bin/sh
606+cd obj*; make autopilot
607
608=== added file 'debian/tests/make-test'
609--- debian/tests/make-test 1970-01-01 00:00:00 +0000
610+++ debian/tests/make-test 2014-08-11 16:19:22 +0000
611@@ -0,0 +1,2 @@
612+#!/bin/sh
613+cd obj*; make test
614
615=== added file 'debian/ubuntu-clock-app-autopilot.install'
616--- debian/ubuntu-clock-app-autopilot.install 1970-01-01 00:00:00 +0000
617+++ debian/ubuntu-clock-app-autopilot.install 2014-08-11 16:19:22 +0000
618@@ -0,0 +1,1 @@
619+/usr/lib/*/dist-packages/ubuntu_clock_app/*
620
621=== added file 'debian/ubuntu-clock-app.install'
622--- debian/ubuntu-clock-app.install 1970-01-01 00:00:00 +0000
623+++ debian/ubuntu-clock-app.install 2014-08-11 16:19:22 +0000
624@@ -0,0 +1,2 @@
625+usr/lib/*/qt5/qml/ClockApp/*
626+usr/share/*
627
628=== modified file 'manifest.json'
629--- manifest.json 2014-08-06 20:14:02 +0000
630+++ manifest.json 2014-08-11 16:19:22 +0000
631@@ -4,10 +4,11 @@
632 "framework": "ubuntu-sdk-14.10-dev2",
633 "architecture": "all",
634 "title": "Clock Reboot",
635+ "icon": "clock@30.png",
636 "hooks": {
637 "ubuntu-clock-app": {
638 "apparmor": "ubuntu-clock-app.json",
639- "desktop": "ubuntu-clock-app.desktop"
640+ "desktop": "share/applications/ubuntu-clock-app.desktop"
641 }
642 },
643 "version": "0.1",
644
645=== added file 'tests/CMakeLists.txt'
646--- tests/CMakeLists.txt 1970-01-01 00:00:00 +0000
647+++ tests/CMakeLists.txt 2014-08-11 16:19:22 +0000
648@@ -0,0 +1,1 @@
649+add_subdirectory(autopilot)
650
651=== added file 'tests/autopilot/CMakeLists.txt'
652--- tests/autopilot/CMakeLists.txt 1970-01-01 00:00:00 +0000
653+++ tests/autopilot/CMakeLists.txt 2014-08-11 16:19:22 +0000
654@@ -0,0 +1,8 @@
655+execute_process(COMMAND python3 -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
656+ OUTPUT_VARIABLE PYTHON_PACKAGE_DIR OUTPUT_STRIP_TRAILING_WHITESPACE)
657+
658+if(INSTALL_TESTS)
659+ install(DIRECTORY ${AUTOPILOT_DIR}
660+ DESTINATION ${PYTHON_PACKAGE_DIR}
661+ )
662+endif(INSTALL_TESTS)
663
664=== modified file 'tests/autopilot/run' (properties changed: -x to +x)
665--- tests/autopilot/run 2014-07-31 16:58:56 +0000
666+++ tests/autopilot/run 2014-08-11 16:19:22 +0000
667@@ -7,5 +7,7 @@
668
669 SCRIPTPATH=`dirname $0`
670 pushd ${SCRIPTPATH}
671-autopilot run ubuntu-clock-app
672+autopilot run ubuntu_clock_app
673+retcode=$?
674 popd
675+exit $retcode
676
677=== modified file 'tests/autopilot/ubuntu_clock_app/emulators.py'
678--- tests/autopilot/ubuntu_clock_app/emulators.py 2014-08-08 09:11:06 +0000
679+++ tests/autopilot/ubuntu_clock_app/emulators.py 2014-08-11 16:19:22 +0000
680@@ -396,7 +396,8 @@
681 raise ClockEmulatorException('Error deleting alarm.')
682
683
684-class ListItemWithActions(ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
685+class ListItemWithActions(
686+ ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase):
687
688 def swipe_to_delete(self):
689 x, y, width, height = self.globalRect
690
691=== modified file 'tests/autopilot/ubuntu_clock_app/tests/__init__.py'
692--- tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-08-08 22:30:20 +0000
693+++ tests/autopilot/ubuntu_clock_app/tests/__init__.py 2014-08-11 16:19:22 +0000
694@@ -19,6 +19,7 @@
695 import os.path
696 import os
697 import shutil
698+import glob
699 import logging
700 import fixtures
701
702@@ -33,6 +34,32 @@
703 logger = logging.getLogger(__name__)
704
705
706+def find_local_path(what):
707+
708+ """Depending on which directory we build in, paths might be
709+ named differently. This way we find them and don't have to
710+ hook into cmake variables.
711+
712+ """
713+ if not what:
714+ return None
715+ if what.endswith("/"):
716+ what = what[:-1]
717+ for dirpath, dirnames, filenames in os.walk("../.."):
718+ avail_dirs = map(lambda a: os.path.abspath(os.path.join(dirpath, a)),
719+ dirnames)
720+ match_dirs = filter(lambda a: a.endswith(what), avail_dirs)
721+ if match_dirs:
722+ return match_dirs[0]
723+
724+ avail_files = map(lambda a: os.path.abspath(os.path.join(dirpath, a)),
725+ filenames)
726+ match_files = filter(lambda a: a.endswith(what), avail_files)
727+ if match_files:
728+ return match_files[0]
729+ return None
730+
731+
732 class ClockAppTestCase(base.UbuntuUIToolkitAppTestCase):
733
734 """A common test case class that provides several useful methods for
735@@ -41,13 +68,14 @@
736 """
737
738 local_location = os.path.dirname(os.path.dirname(os.getcwd()))
739- local_location_qml = os.path.join(
740- local_location, 'app/ubuntu-clock-app.qml')
741- local_location_backend = os.path.join(local_location, 'builddir/backend')
742- installed_location_backend = \
743- '/usr/share/ubuntu-clock-app/builddir/backend'
744+ local_location_qml = find_local_path("app/ubuntu-clock-app.qml")
745+ local_location_backend = find_local_path("backend/")
746+ installed_location_backend = ""
747+ if glob.glob('/usr/lib/*/qt5/qml/ClockApp'):
748+ installed_location_backend = \
749+ glob.glob('/usr/lib/*/qt5/qml/ClockApp')[0]
750 installed_location_qml = \
751- '/usr/share/ubuntu-clock-app/app/ubuntu-clock-app.qml'
752+ '/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml'
753
754 # note this directory could change to com.ubuntu.clock at some point
755 sqlite_dir = os.path.expanduser(
756
757=== modified file 'tests/unit/tst_hellocomponent.qml'
758--- tests/unit/tst_hellocomponent.qml 2014-07-31 16:58:56 +0000
759+++ tests/unit/tst_hellocomponent.qml 2014-08-11 16:19:22 +0000
760@@ -1,7 +1,7 @@
761 import QtQuick 2.0
762 import QtTest 1.0
763 import Ubuntu.Components 0.1
764-import "../../components"
765+import "../../app/components"
766
767 // See more details @ http://qt-project.org/doc/qt-5.0/qtquick/qml-testcase.html
768

Subscribers

People subscribed via source and target branches