Code review comment for lp:~ubuntu-calendar-dev/ubuntu-calendar-app/5-Improved-EventDetails

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Tested and works as expected. Nice work Mihir!

Just one minor quirk,

606 - text: i18n.tr("Repeats")
607 - subText: eventUtils.getRecurrenceString(rule)
608 + text: i18n.tr("This Happens")

Why this change? I thought we (popey) agreed to using "Repeats" rather than "This Happens".

Also why did you remove,

613 - ListItem.ThinDivider {}

review: Needs Fixing

« Back to merge proposal