lp:ubuntu/vivid/click-reviewers-tools

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

26. By Daniel Holbach on 2015-04-20

[ Michael Vogt ]
* Fixed a number of issues raised by pyflakes.

[ Ricardo Kirkner ]
* support overrides in all click-check scripts
* refactored click checks to avoid duplication
* handle checks from branch as well as installed system-wide when running
  all checks

[ Jamie Strandboge ]
* update bin-path tests for new binaries yaml
* 'oem' is a valid type
* handle missing 'hooks' in manifest with oem snaps (LP: #1434279)
* cr_common.py: add config, immutable-config and oem in support of oem snaps
* obsolete framework click hook and meta/*.framework
* don't allow 'type: framework' to specify 'frameworks'
* fix click-show-files with native snaps
* click-show-files should show package.yaml
* add framework policy checks
* update systemd tests to check package.yaml
* .strip() whitespace in control_description_match
* check_package_filename() store downloads packages with _all instead of
  _multi. Account for that. We may want to remove this check entirely.
* cr_security.py: adjust for ubuntu-core/15.04 policy changes
* cr_security.py: policy_vendor is no longer redflagged
* cr_lint.py: don't strip 'all' from compat architecture list on snappy
* cr_lint.py: don't review unused control['Architecture'] on snappy

[ Fabian Ezequiel Gallina ]
* fix missing import on clickreviews/cr_framework.py
* add test for non-string framework

[ Alex Abreu ]
* fix webapp exec with no homepage url or with exec field code (LP:
  #1441185)

[ James Westby ]
* Drop the checks on the package name in the filename.
  The filename doesn't matter, and the store generates it anyway,
  so checking it is a waste, and keeps breaking as we change the
  rules.

25. By Jamie Strandboge on 2015-03-18

* don't fail if DEBIAN/md5sums doesn't exist with snap packages. The snap
  package format uses a different method for integrity checking
* add bin/click-check-systemd
* adjust bin/click-run-checks to call click-check-systemd

24. By Jamie Strandboge on 2015-03-09

fix pep8 warning when building on trusty

23. By Jamie Strandboge on 2015-03-09

[ Alexandre Abreu ]
* Relax the rule that states that webapps with a model search path shouldn't
  have url patterns listed in the command line. In order to avoid confusion,
  we allow this to happen (and it already works fine the command line
  patterns being appended to the locally defined ones). (LP: #1406643)

[ Jamie Strandboge ]
* add testsuite test to verify apparmor-profile can't be specified with
  apparmor
* add apparmor-profile hook tests
* fix test_check_optional_domain_suffix_without_protocol2() to actually test
  with 'nonexistent' key
* debian/control:
  - add python3-yaml to Build-Depends and Depends
  - update Vcs-Bzr to point to lp:click-reviewers-tools
* add snappy-systemd hook tests and update the testsuite accordingly
* apparmor-profile hook may be used anywhere apparmor can be, but not with
  apparmor itself (apparmor-profile is still redflagged)
* implement snappy package.yaml lint tests
* implement snappy package.yaml services tests
* implement snappy readme.md lint tests
* implement snappy package.yaml binaries tests
* one more snappy workaround for check_package_filename()

22. By Daniel Holbach on 2015-03-03

[ Pete Woods ]
* Add childscopes field to recognised list.
* Add documentation link of the scope config files:
  CONFIGFILES in lp:unity-scopes-api.

[ Michael Vogt ]
* snappy: add two new optional fields: source, type.

[ Jamie Strandboge ]
* also use <email address hidden> to signify a core-app
* calculate arch correctly in check_package_filename()
* add ubuntu-core-15.04 to self.major_framework_policy
* add checks for self.major_framework_policy to policy_vendor checks
* bin-path should no longer require snappy-systemd hook
* warn, don't error, on 'Could not find compiled binaries for architecture'
  since it might be ok to, for example, ship a shell script but you only
  want it on ARM devices
* apparmor-profile is an allowed hook, but a redflagged one
* don't error that apparmor is missing if apparmor-profile is present

[ Daniel Holbach ]
* Deal with multi-arch clicks properly. (LP: #1395204)

21. By Daniel Holbach on 2015-01-14

[ Martin Albisetti ]
Remove checks that validate namespaces and email addresses, those are
better suited for the store, which knows the information about the
uploading user. (LP: #1408644)

20. By Daniel Holbach on 2014-12-16

[ Ricardo Kirkner ]
* fetch framework data before running framework related checks
* use mtime instead of ctime to check remote file freshness
* allow specifying overrides for framework checks
* handle case when overrides data is malformed

[ Alexandre Abreu ]
* add support for local html5 app launch mode for webapp-container
  (LP: #1388988)

[ Jamie Strandboge ]
* open scopes .ini file as utf8 (LP: #1371692)
* allow for translatable fields in the scopes .ini file (LP: #1392133)
* don't require desktop hook with systemd or framework
* com.ubuntu.snappy can use <email address hidden>
  (LP: #1395007)
* add bin-path click hook checks and tests (LP: #1395001)
* add preliminary framework hook checks and tests (LP: #1395004)
* refactor hooks checks into parent class (LP: #1395005)
* sort click-review results in print_findings
* add preliminary systemd hook checks and tests
* update apparmor policy json and adjust security checks to properly handle
  different policy vendors
* update data/apparmor-easyprof-ubuntu.json for 1.3
* don't warn if specifying 'default' with ubuntu-snappy vendor
* systemd hook renamed to snappy-systemd
* allow filenames to end with .snap
* allow flat namesapces in check_maintainer_email()

[ Daniel Holbach ]
* Add askubuntu explanation for policy_version_is_highest.
* Add askubuntu explanation for debug builds. (LP: #1390163)

19. By Daniel Holbach on 2014-10-15

Let setup.py handle non-ascii characters in d/changelog.

18. By Jamie Strandboge on 2014-10-14

* webapps may use content_exchange_source (LP: #1380694)
* online accounts shouldn't specify id and should warn when they do.
  (LP: #1380534)
* click-show-files: cleanup unpack directory at end

17. By Jamie Strandboge on 2014-10-09

add i386 and amd64 to self.valid_control_architectures