Merge lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742 into lp:ubuntu/raring/juju

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742
Merge into: lp:ubuntu/raring/juju
Diff against target: 115 lines (+32/-3) (has conflicts)
6 files modified
.pc/applied-patches (+3/-0)
debian/changelog (+11/-0)
debian/patches/series (+3/-0)
juju/charm/tests/test_directory.py (+8/-0)
juju/providers/maas/provider.py (+2/-3)
juju/providers/maas/tests/test_provider.py (+5/-0)
Text conflict in .pc/applied-patches
Text conflict in debian/changelog
Text conflict in debian/patches/series
Text conflict in juju/charm/tests/test_directory.py
Text conflict in juju/providers/maas/tests/test_provider.py
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+160167@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/raring/juju reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

28. By Clint Byrum

d/juju.docs: Remove examples as they have been dropped upstream.

27. By Clint Byrum

d/p/maas-tag-conversion.patch: Dropped, patch applied upstream.

26. By Clint Byrum

d/p/fix-tests-do-not-use-etc-lsb-release: Dropped, patch applied upstream.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2013-04-10 13:57:21 +0000
+++ .pc/applied-patches 2013-04-22 17:51:22 +0000
@@ -1,2 +1,5 @@
1disable-failing-zookeeper-test.patch1disable-failing-zookeeper-test.patch
2<<<<<<< TREE
2workaround-lxc-python-env.patch3workaround-lxc-python-env.patch
4=======
5>>>>>>> MERGE-SOURCE
36
=== modified file 'debian/changelog'
--- debian/changelog 2013-04-10 13:57:21 +0000
+++ debian/changelog 2013-04-22 17:51:22 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
1juju (0.7-0ubuntu1) raring; urgency=low2juju (0.7-0ubuntu1) raring; urgency=low
23
3 [ Clint Byrum ]4 [ Clint Byrum ]
@@ -17,6 +18,16 @@
1718
18 -- Martin Packman <martin.packman@canonical.com> Wed, 10 Apr 2013 13:57:21 +000019 -- Martin Packman <martin.packman@canonical.com> Wed, 10 Apr 2013 13:57:21 +0000
1920
21=======
22juju (0.6-1ubuntu2) UNRELEASED; urgency=low
23
24 * d/p/fix-tests-do-not-use-etc-lsb-release: Dropped, patch applied upstream.
25 * d/p/maas-tag-conversion.patch: Dropped, patch applied upstream.
26 * d/juju.docs: Remove examples as they have been dropped upstream.
27
28 -- Clint Byrum <clint@ubuntu.com> Tue, 06 Nov 2012 12:14:23 -0800
29
30>>>>>>> MERGE-SOURCE
20juju (0.6-1ubuntu1) quantal; urgency=low31juju (0.6-1ubuntu1) quantal; urgency=low
2132
22 * d/patches/maas-tag-conversion.patch: Fix maas provider api usage33 * d/patches/maas-tag-conversion.patch: Fix maas provider api usage
2334
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-04-10 13:57:21 +0000
+++ debian/patches/series 2013-04-22 17:51:22 +0000
@@ -1,2 +1,5 @@
1disable-failing-zookeeper-test.patch1disable-failing-zookeeper-test.patch
2<<<<<<< TREE
2workaround-lxc-python-env.patch3workaround-lxc-python-env.patch
4=======
5>>>>>>> MERGE-SOURCE
36
=== modified file 'juju/charm/tests/test_directory.py'
--- juju/charm/tests/test_directory.py 2013-04-10 13:57:21 +0000
+++ juju/charm/tests/test_directory.py 2013-04-22 17:51:22 +0000
@@ -211,8 +211,12 @@
211211
212 def test_internal_symlink(self):212 def test_internal_symlink(self):
213 charm_path = self.copy_charm()213 charm_path = self.copy_charm()
214<<<<<<< TREE
214 external_file = self.makeFile(content='baz')215 external_file = self.makeFile(content='baz')
215 os.symlink(external_file, os.path.join(charm_path, "foobar"))216 os.symlink(external_file, os.path.join(charm_path, "foobar"))
217=======
218 os.symlink("/etc/lsb-release", os.path.join(charm_path, "foobar"))
219>>>>>>> MERGE-SOURCE
216220
217 directory = CharmDirectory(charm_path)221 directory = CharmDirectory(charm_path)
218 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)222 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)
@@ -220,8 +224,12 @@
220224
221 def test_extract_symlink(self):225 def test_extract_symlink(self):
222 charm_path = self.copy_charm()226 charm_path = self.copy_charm()
227<<<<<<< TREE
223 external_file = self.makeFile(content='lorem ipsum')228 external_file = self.makeFile(content='lorem ipsum')
224 os.symlink(external_file, os.path.join(charm_path, "foobar"))229 os.symlink(external_file, os.path.join(charm_path, "foobar"))
230=======
231 os.symlink("/etc/lsb-release", os.path.join(charm_path, "foobar"))
232>>>>>>> MERGE-SOURCE
225233
226 directory = CharmDirectory(charm_path)234 directory = CharmDirectory(charm_path)
227 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)235 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)
228236
=== modified file 'juju/providers/maas/provider.py'
--- juju/providers/maas/provider.py 2013-04-10 13:57:21 +0000
+++ juju/providers/maas/provider.py 2013-04-22 17:51:22 +0000
@@ -37,10 +37,9 @@
37 def convert(self, tag_expression):37 def convert(self, tag_expression):
38 """Extract set of names in tag_expression checking they all exist"""38 """Extract set of names in tag_expression checking they all exist"""
39 tags = set()39 tags = set()
40 stripped_expression = tag_expression
41 for c in (",", "&", "|", "!"):40 for c in (",", "&", "|", "!"):
42 stripped_expression = stripped_expression.replace(c, " ")41 tag_expression = tag_expression.replace(c, " ")
43 for word in stripped_expression.strip().split():42 for word in tag_expression.strip().split():
44 tag = word.lower()43 tag = word.lower()
45 if tag not in self.tag_names:44 if tag not in self.tag_names:
46 raise ValueError("tag %r does not exist" % (tag,))45 raise ValueError("tag %r does not exist" % (tag,))
4746
=== modified file 'juju/providers/maas/tests/test_provider.py'
--- juju/providers/maas/tests/test_provider.py 2013-04-10 13:57:21 +0000
+++ juju/providers/maas/tests/test_provider.py 2013-04-22 17:51:22 +0000
@@ -191,6 +191,7 @@
191 provider.maas_client = mock_client191 provider.maas_client = mock_client
192 cs = yield provider.get_constraint_set()192 cs = yield provider.get_constraint_set()
193 bear = cs.parse(["maas-tags=clawed, furry"])193 bear = cs.parse(["maas-tags=clawed, furry"])
194<<<<<<< TREE
194195
195 # Incomplete constraints (no series) can't satisify196 # Incomplete constraints (no series) can't satisify
196 self.assertFalse(bear.can_satisfy(bear))197 self.assertFalse(bear.can_satisfy(bear))
@@ -199,6 +200,10 @@
199200
200 err = self.assertRaises(201 err = self.assertRaises(
201 ConstraintError,202 ConstraintError,
203=======
204 bear.can_satisfy(bear)
205 err = self.assertRaises(ConstraintError,
206>>>>>>> MERGE-SOURCE
202 cs.parse, ["maas-tags=furry, bouncy"])207 cs.parse, ["maas-tags=furry, bouncy"])
203208
204 self.assertEqual(209 self.assertEqual(

Subscribers

People subscribed via source and target branches

to all changes: