Merge lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742 into lp:ubuntu/raring/juju

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742
Merge into: lp:ubuntu/raring/juju
Diff against target: 115 lines (+32/-3) (has conflicts)
6 files modified
.pc/applied-patches (+3/-0)
debian/changelog (+11/-0)
debian/patches/series (+3/-0)
juju/charm/tests/test_directory.py (+8/-0)
juju/providers/maas/provider.py (+2/-3)
juju/providers/maas/tests/test_provider.py (+5/-0)
Text conflict in .pc/applied-patches
Text conflict in debian/changelog
Text conflict in debian/patches/series
Text conflict in juju/charm/tests/test_directory.py
Text conflict in juju/providers/maas/tests/test_provider.py
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+160167@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/raring/juju reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/raring/juju/raring-201304221742. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

28. By Clint Byrum

d/juju.docs: Remove examples as they have been dropped upstream.

27. By Clint Byrum

d/p/maas-tag-conversion.patch: Dropped, patch applied upstream.

26. By Clint Byrum

d/p/fix-tests-do-not-use-etc-lsb-release: Dropped, patch applied upstream.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/applied-patches'
2--- .pc/applied-patches 2013-04-10 13:57:21 +0000
3+++ .pc/applied-patches 2013-04-22 17:51:22 +0000
4@@ -1,2 +1,5 @@
5 disable-failing-zookeeper-test.patch
6+<<<<<<< TREE
7 workaround-lxc-python-env.patch
8+=======
9+>>>>>>> MERGE-SOURCE
10
11=== modified file 'debian/changelog'
12--- debian/changelog 2013-04-10 13:57:21 +0000
13+++ debian/changelog 2013-04-22 17:51:22 +0000
14@@ -1,3 +1,4 @@
15+<<<<<<< TREE
16 juju (0.7-0ubuntu1) raring; urgency=low
17
18 [ Clint Byrum ]
19@@ -17,6 +18,16 @@
20
21 -- Martin Packman <martin.packman@canonical.com> Wed, 10 Apr 2013 13:57:21 +0000
22
23+=======
24+juju (0.6-1ubuntu2) UNRELEASED; urgency=low
25+
26+ * d/p/fix-tests-do-not-use-etc-lsb-release: Dropped, patch applied upstream.
27+ * d/p/maas-tag-conversion.patch: Dropped, patch applied upstream.
28+ * d/juju.docs: Remove examples as they have been dropped upstream.
29+
30+ -- Clint Byrum <clint@ubuntu.com> Tue, 06 Nov 2012 12:14:23 -0800
31+
32+>>>>>>> MERGE-SOURCE
33 juju (0.6-1ubuntu1) quantal; urgency=low
34
35 * d/patches/maas-tag-conversion.patch: Fix maas provider api usage
36
37=== modified file 'debian/patches/series'
38--- debian/patches/series 2013-04-10 13:57:21 +0000
39+++ debian/patches/series 2013-04-22 17:51:22 +0000
40@@ -1,2 +1,5 @@
41 disable-failing-zookeeper-test.patch
42+<<<<<<< TREE
43 workaround-lxc-python-env.patch
44+=======
45+>>>>>>> MERGE-SOURCE
46
47=== modified file 'juju/charm/tests/test_directory.py'
48--- juju/charm/tests/test_directory.py 2013-04-10 13:57:21 +0000
49+++ juju/charm/tests/test_directory.py 2013-04-22 17:51:22 +0000
50@@ -211,8 +211,12 @@
51
52 def test_internal_symlink(self):
53 charm_path = self.copy_charm()
54+<<<<<<< TREE
55 external_file = self.makeFile(content='baz')
56 os.symlink(external_file, os.path.join(charm_path, "foobar"))
57+=======
58+ os.symlink("/etc/lsb-release", os.path.join(charm_path, "foobar"))
59+>>>>>>> MERGE-SOURCE
60
61 directory = CharmDirectory(charm_path)
62 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)
63@@ -220,8 +224,12 @@
64
65 def test_extract_symlink(self):
66 charm_path = self.copy_charm()
67+<<<<<<< TREE
68 external_file = self.makeFile(content='lorem ipsum')
69 os.symlink(external_file, os.path.join(charm_path, "foobar"))
70+=======
71+ os.symlink("/etc/lsb-release", os.path.join(charm_path, "foobar"))
72+>>>>>>> MERGE-SOURCE
73
74 directory = CharmDirectory(charm_path)
75 e = self.assertRaises(InvalidCharmFile, directory.as_bundle)
76
77=== modified file 'juju/providers/maas/provider.py'
78--- juju/providers/maas/provider.py 2013-04-10 13:57:21 +0000
79+++ juju/providers/maas/provider.py 2013-04-22 17:51:22 +0000
80@@ -37,10 +37,9 @@
81 def convert(self, tag_expression):
82 """Extract set of names in tag_expression checking they all exist"""
83 tags = set()
84- stripped_expression = tag_expression
85 for c in (",", "&", "|", "!"):
86- stripped_expression = stripped_expression.replace(c, " ")
87- for word in stripped_expression.strip().split():
88+ tag_expression = tag_expression.replace(c, " ")
89+ for word in tag_expression.strip().split():
90 tag = word.lower()
91 if tag not in self.tag_names:
92 raise ValueError("tag %r does not exist" % (tag,))
93
94=== modified file 'juju/providers/maas/tests/test_provider.py'
95--- juju/providers/maas/tests/test_provider.py 2013-04-10 13:57:21 +0000
96+++ juju/providers/maas/tests/test_provider.py 2013-04-22 17:51:22 +0000
97@@ -191,6 +191,7 @@
98 provider.maas_client = mock_client
99 cs = yield provider.get_constraint_set()
100 bear = cs.parse(["maas-tags=clawed, furry"])
101+<<<<<<< TREE
102
103 # Incomplete constraints (no series) can't satisify
104 self.assertFalse(bear.can_satisfy(bear))
105@@ -199,6 +200,10 @@
106
107 err = self.assertRaises(
108 ConstraintError,
109+=======
110+ bear.can_satisfy(bear)
111+ err = self.assertRaises(ConstraintError,
112+>>>>>>> MERGE-SOURCE
113 cs.parse, ["maas-tags=furry, bouncy"])
114
115 self.assertEqual(

Subscribers

People subscribed via source and target branches

to all changes: