Merge lp:~ubuntu-branches/ubuntu/quantal/rhythmbox/quantal-201205140516 into lp:ubuntu/quantal/rhythmbox

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/quantal/rhythmbox/quantal-201205140516
Merge into: lp:ubuntu/quantal/rhythmbox
Diff against target: 91 lines (+39/-16) (has conflicts)
3 files modified
debian/changelog (+18/-0)
debian/rhythmbox.install (+1/-1)
debian/source_rhythmbox.py (+20/-15)
Text conflict in debian/changelog
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/quantal/rhythmbox/quantal-201205140516
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+105608@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/quantal/rhythmbox reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/quantal/rhythmbox/quantal-201205140516. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

210. By Bryce Harrington

* debian/source_rhythmbox.py:
  - Only prompt user to specify type of bug if it isn't a crash.
    (I.e., if there is no stacktrace present.)
    (LP: #737598)

209. By Bryce Harrington

debian/source_rhythmbox.py: Improve categorization wording.
(LP: #543948)

208. By Bryce Harrington

debian/rhythmbox.install: Fix installation of apport hook to correct
directory. Otherwise, the hook won't be used when running ubuntu-bug
rhythmbox.
(LP: #992355)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-05-14 16:11:13 +0000
+++ debian/changelog 2012-05-14 05:21:19 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
1rhythmbox (2.96-0ubuntu5) quantal; urgency=low2rhythmbox (2.96-0ubuntu5) quantal; urgency=low
23
3 * debian/control:4 * debian/control:
@@ -8,6 +9,23 @@
89
9 -- Robert Ancell <robert.ancell@canonical.com> Mon, 14 May 2012 16:11:13 +120010 -- Robert Ancell <robert.ancell@canonical.com> Mon, 14 May 2012 16:11:13 +1200
1011
12=======
13rhythmbox (2.96-0ubuntu5) UNRELEASED; urgency=low
14
15 * debian/rhythmbox.install: Fix installation of apport hook to correct
16 directory. Otherwise, the hook won't be used when running ubuntu-bug
17 rhythmbox.
18 (LP: #992355)
19 * debian/source_rhythmbox.py:
20 - Improve categorization wording.
21 (LP: #543948)
22 - Only prompt user to specify type of bug if it isn't a crash.
23 (I.e., if there is no stacktrace present.)
24 (LP: #737598)
25
26 -- Bryce Harrington <bryce@ubuntu.com> Mon, 30 Apr 2012 19:56:25 -0700
27
28>>>>>>> MERGE-SOURCE
11rhythmbox (2.96-0ubuntu4) precise; urgency=low29rhythmbox (2.96-0ubuntu4) precise; urgency=low
1230
13 * debian/patches/git_mpris_playlists.patch:31 * debian/patches/git_mpris_playlists.patch:
1432
=== modified file 'debian/rhythmbox.install'
--- debian/rhythmbox.install 2012-03-09 07:24:47 +0000
+++ debian/rhythmbox.install 2012-05-14 05:21:19 +0000
@@ -1,4 +1,4 @@
1debian/source_rhythmbox.py usr/share/apport/package_hooks1debian/source_rhythmbox.py usr/share/apport/package-hooks
2debian/rhythmbox-small.xpm usr/share/pixmaps2debian/rhythmbox-small.xpm usr/share/pixmaps
3usr/bin3usr/bin
4usr/lib/rhythmbox/rhythmbox-metadata4usr/lib/rhythmbox/rhythmbox-metadata
55
=== modified file 'debian/source_rhythmbox.py'
--- debian/source_rhythmbox.py 2011-12-16 13:45:33 +0000
+++ debian/source_rhythmbox.py 2012-05-14 05:21:19 +0000
@@ -27,24 +27,29 @@
27 if "ubuntuone" in stacktrace or "webkit" in stacktrace:27 if "ubuntuone" in stacktrace or "webkit" in stacktrace:
28 report.add_package_info("rhythmbox-ubuntuone-music-store")28 report.add_package_info("rhythmbox-ubuntuone-music-store")
29 return29 return
30 30 else:
3131 response = ui.choice("How would you describe the issue?", [
32 response = ui.choice("How would you describe the issue?", ["The rhythmbox interface is not working correctly", "No sound is being played", "Some audio files are not being played correctly", "The Ubuntu One Music Store is not working correctly"], False)32 "problem with the interface",
3333 "problem with sound",
34 if response == None: # user cancelled34 "problem with playback of audio files",
35 raise StopIteration35 "problem with Ubuntu One Music Store",
36# TODO: port to gsettings 36 "other problem",
37 ], False)
38
39 if response == None: # user cancelled
40 raise StopIteration
41# TODO: port to gsettings
37# if response[0] == 0: # an issue about rhythmbox interface42# if response[0] == 0: # an issue about rhythmbox interface
38# apport.hookutils.attach_gconf(report, 'rhythmbox')43# apport.hookutils.attach_gconf(report, 'rhythmbox')
39# report['GConfNonDefault'] = mask_values(report['GConfNonDefault'])44# report['GConfNonDefault'] = mask_values(report['GConfNonDefault'])
40 if response[0] == 1: # the issue is a sound one45 if response[0] == 1: # the issue is a sound one
41 os.execlp('apport-bug', 'apport-bug', 'audio')46 os.execlp('apport-bug', 'apport-bug', 'audio')
42 if response[0] == 2: # the issue is a codec one47 if response[0] == 2: # the issue is a codec one
43 report.add_package_info("libgstreamer0.10-0")48 report.add_package_info("libgstreamer0.10-0")
44 return49 return
45 if response[0] == 3: # problem with the music store50 if response[0] == 3: # problem with the music store
46 report.add_package_info("rhythmbox-ubuntuone-music-store")51 report.add_package_info("rhythmbox-ubuntuone-music-store")
47 return52 return
4853
49 report["LogAlsaMixer"] = apport.hookutils.command_output(["/usr/bin/amixer"])54 report["LogAlsaMixer"] = apport.hookutils.command_output(["/usr/bin/amixer"])
50 report["GstreamerVersions"] = apport.hookutils.package_versions("gstreamer*")55 report["GstreamerVersions"] = apport.hookutils.package_versions("gstreamer*")

Subscribers

People subscribed via source and target branches

to all changes: