Merge lp:~ubuntu-branches/ubuntu/quantal/nfs-utils/quantal-201209281842 into lp:ubuntu/quantal/nfs-utils

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/quantal/nfs-utils/quantal-201209281842
Merge into: lp:ubuntu/quantal/nfs-utils
Diff against target: 173 lines (+155/-0) (has conflicts)
3 files modified
debian/nfs-common.gssd-mounting.upstart (+57/-0)
debian/nfs-common.idmapd-mounting.upstart (+27/-0)
debian/patches/20-ticket-expired-error.patch (+71/-0)
Conflict adding file debian/nfs-common.gssd-mounting.upstart.  Moved existing file to debian/nfs-common.gssd-mounting.upstart.moved.
Conflict adding file debian/nfs-common.idmapd-mounting.upstart.  Moved existing file to debian/nfs-common.idmapd-mounting.upstart.moved.
Conflict adding file debian/patches/20-ticket-expired-error.patch.  Moved existing file to debian/patches/20-ticket-expired-error.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/quantal/nfs-utils/quantal-201209281842
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+127046@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/quantal/nfs-utils reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/quantal/nfs-utils/quantal-201209281842. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

70. By Stéphane Graber

releasing version 1:1.2.6-3ubuntu2

69. By Stéphane Graber

Apply patch for bug #794112

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'debian/nfs-common.gssd-mounting.upstart'
--- debian/nfs-common.gssd-mounting.upstart 1970-01-01 00:00:00 +0000
+++ debian/nfs-common.gssd-mounting.upstart 2012-09-28 18:51:21 +0000
@@ -0,0 +1,57 @@
1# gssd-mounting
2
3description "Block the mounting event for NFS4 filesytems until gssd is running"
4author "Steve Langasek <steve.langasek@canonical.com>"
5
6instance $MOUNTPOINT
7
8start on mounting TYPE=nfs* OPTIONS=*sec*krb5*
9stop on started gssd or stopped gssd
10task
11
12# This is required so that the task is still considered
13# successful when it gets killed
14normal exit TERM
15
16script
17
18 DEFAULTFILE=/etc/default/nfs-common
19
20 if [ -f "$DEFAULTFILE" ]; then
21 . "$DEFAULTFILE"
22 fi
23
24 if [ -f /etc/fstab ]; then
25 exec 9<&0 </etc/fstab
26
27 while read DEV MTPT FSTYPE OPTS REST
28 do
29 case "$OPTS" in
30 sec=krb5|*,sec=krb5|sec=krb5,*|*,sec=krb5,*|sec=krb5i|*,sec=krb5i|sec=krb5i,*|*,sec=krb5i,*|sec=krb5p|*,sec=krb5p|sec=krb5p,*|*,sec=krb5p,*)
31 AUTO_NEED_GSSD=yes
32 ;;
33 esac
34 done
35
36 exec 0<&9 9<&-
37 fi
38
39 case "$NEED_GSSD" in
40 yes|no)
41 ;;
42 *)
43 NEED_GSSD=$AUTO_NEED_GSSD
44 ;;
45 esac
46 [ "x$NEED_GSSD" = xyes ] || { stop; exit 0; }
47
48 status gssd | grep -q "start/running" && exit 0
49
50 # If it's already starting we'll get killed by the impending 'stop on
51 # started gssd'
52 # If it wasn't already starting, we'll either get killed by the stop
53 # on started or stopped.
54 # So, its safe to sleep forever here and rely on upstart to kill us,
55
56 while sleep 3600; do :; done
57end script
058
=== renamed file 'debian/nfs-common.gssd-mounting.upstart' => 'debian/nfs-common.gssd-mounting.upstart.moved'
=== added file 'debian/nfs-common.idmapd-mounting.upstart'
--- debian/nfs-common.idmapd-mounting.upstart 1970-01-01 00:00:00 +0000
+++ debian/nfs-common.idmapd-mounting.upstart 2012-09-28 18:51:21 +0000
@@ -0,0 +1,27 @@
1# idmapd-mounting
2
3description "Block the mounting event for NFS4 filesytems until idmapd is running"
4author "Steve Langasek <steve.langasek@canonical.com>"
5
6instance $MOUNTPOINT
7
8start on mounting TYPE=nfs*
9stop on started idmapd or stopped idmapd
10task
11
12# This is required so that the task is still considered
13# successful when it gets killed
14normal exit TERM
15
16script
17
18 status idmapd | grep -q "start/running" && exit 0
19
20 # If it's already starting we'll get killed by the impending 'stop on
21 # started idmapd'
22 # If it wasn't already starting, we'll either get killed by the stop
23 # on started or stopped.
24 # So, its safe to sleep forever here and rely on upstart to kill us,
25
26 while sleep 3600; do :; done
27end script
028
=== renamed file 'debian/nfs-common.idmapd-mounting.upstart' => 'debian/nfs-common.idmapd-mounting.upstart.moved'
=== added file 'debian/patches/20-ticket-expired-error.patch'
--- debian/patches/20-ticket-expired-error.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/20-ticket-expired-error.patch 2012-09-28 18:51:21 +0000
@@ -0,0 +1,71 @@
1## Description: add some description
2## Origin/Author: add some origin or author
3## Bug: bug URL
4--- a/utils/gssd/gssd.c
5+++ b/utils/gssd/gssd.c
6@@ -63,6 +63,7 @@
7 int root_uses_machine_creds = 1;
8 unsigned int context_timeout = 0;
9 char *preferred_realm = NULL;
10+int ticket_expiry_is_error = 0;
11
12 void
13 sig_die(int signal)
14@@ -85,7 +86,7 @@
15 static void
16 usage(char *progname)
17 {
18- fprintf(stderr, "usage: %s [-f] [-l] [-M] [-n] [-v] [-r] [-p pipefsdir] [-k keytab] [-d ccachedir] [-t timeout] [-R preferred realm]\n",
19+ fprintf(stderr, "usage: %s [-e] [-f] [-l] [-M] [-n] [-v] [-r] [-p pipefsdir] [-k keytab] [-d ccachedir] [-t timeout] [-R preferred realm]\n",
20 progname);
21 exit(1);
22 }
23@@ -102,8 +103,11 @@
24 char *progname;
25
26 memset(ccachesearch, 0, sizeof(ccachesearch));
27- while ((opt = getopt(argc, argv, "fvrlmnMp:k:d:t:R")) != -1) {
28+ while ((opt = getopt(argc, argv, "efvrlmnMp:k:d:t:R")) != -1) {
29 switch (opt) {
30+ case 'e':
31+ ticket_expiry_is_error = 1;
32+ break;
33 case 'f':
34 fg = 1;
35 break;
36--- a/utils/gssd/gssd.h
37+++ b/utils/gssd/gssd.h
38@@ -67,6 +67,7 @@
39 extern int root_uses_machine_creds;
40 extern unsigned int context_timeout;
41 extern char *preferred_realm;
42+extern int ticket_expiry_is_error;
43
44 TAILQ_HEAD(clnt_list_head, clnt_info) clnt_list;
45
46--- a/utils/gssd/gssd.man
47+++ b/utils/gssd/gssd.man
48@@ -130,6 +130,12 @@
49 seconds, which allows changing Kerberos tickets and identities frequently.
50 The default is no explicit timeout, which means the kernel context will live
51 the lifetime of the Kerberos service ticket used in its creation.
52+.TP
53+.B -e
54+Return EACCESS instead of EKEYEXPIRED when a user's credentials expire.
55+Returning EKEYEXPIRED was introduced around kernel 2.6.34 and causes all nfs4
56+I/O to block when a user's credentials expire. This option reverts to old
57+bevavior.
58 .SH SEE ALSO
59 .BR rpc.svcgssd(8)
60 .SH AUTHORS
61--- a/utils/gssd/gssd_proc.c
62+++ b/utils/gssd/gssd_proc.c
63@@ -1008,7 +1008,7 @@
64 free(userdir);
65 userdir = NULL;
66 }
67- if (err == -EKEYEXPIRED)
68+ if (err == -EKEYEXPIRED && !ticket_expiry_is_error)
69 downcall_err = -EKEYEXPIRED;
70 else if (!err)
71 create_resp = create_auth_rpc_client(clp, &rpc_clnt, &auth, uid,
072
=== renamed file 'debian/patches/20-ticket-expired-error.patch' => 'debian/patches/20-ticket-expired-error.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: