Merge lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626 into lp:ubuntu/quantal/lxc

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626
Merge into: lp:ubuntu/quantal/lxc
Diff against target: 93 lines (+76/-0) (has conflicts)
2 files modified
debian/local/lxc-aa-custom-profile (+71/-0)
debian/lxc.install (+5/-0)
Conflict adding file debian/local/lxc-aa-custom-profile.  Moved existing file to debian/local/lxc-aa-custom-profile.moved.
Text conflict in debian/lxc.install
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+111782@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/quantal/lxc reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

114. By Stéphane Graber

releasing version 0.8.0~rc1-4ubuntu15

113. By Stéphane Graber

Update apparmor profiles to fix nesting

112. By Stéphane Graber

No bashism in lxc-aa-custom-profile so make it use /bin/sh

111. By Stéphane Graber

Make the remaining scripts executable

110. By Stéphane Graber

Merge new lxc-aa-custom-profile tool from Serge Hallyn

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'debian/local/lxc-aa-custom-profile'
--- debian/local/lxc-aa-custom-profile 1970-01-01 00:00:00 +0000
+++ debian/local/lxc-aa-custom-profile 2012-06-25 06:34:25 +0000
@@ -0,0 +1,71 @@
1#!/bin/sh
2
3set -e
4
5_OPTIONS="$(getopt -o n: -l name: -- "${@}")"
6
7if [ "${?}" -ne 0 ]
8then
9 echo "Usage: $(basename ${0}) -n|--name CONTAINER" >&2
10 echo " creates a custom profile (copied from the default) for CONTAINER"
11 exit 1
12fi
13
14eval set -- "${_OPTIONS}"
15
16while true
17do
18 case "${1}" in
19 -n|--name)
20 _CONTAINER="${2}"
21 shift 2
22 ;;
23
24 --)
25 shift
26 break
27 ;;
28
29 *)
30 echo "E: $(basename ${0}): internal error ${0}" >&2
31 exit 1
32 ;;
33 esac
34done
35
36if [ `id -u` -ne 0 ]; then
37 echo "E: $(basename ${0}): must run with privilege"
38 exit 1
39fi
40
41if [ -z "${_CONTAINER}" ]
42then
43 echo "E: $(basename ${0}): missing container name, use --name option" >&2
44 exit 1
45fi
46
47if [ ! -f /var/lib/lxc/${_CONTAINER}/config ]; then
48 echo "E: $(basename ${0}): /var/lib/lxc/${_CONTAINER}/config - no such file"
49 exit 1
50fi
51
52profile="lxc-${_CONTAINER}"
53if [ -f /etc/apparmor.d/lxc/${profile} ]; then
54 echo "E: $(basename ${0}): custom profile already exists"
55 exit 1
56fi
57
58if [ ! -f /etc/apparmor.d/lxc/lxc-default ]; then
59 echo "E: $(basename ${0}): default profile does not exist!"
60 exit 1
61fi
62
63cp -f /etc/apparmor.d/lxc/lxc-default /etc/apparmor.d/lxc/${profile}
64sed -i "s/profile lxc-container-default/profile ${profile}/" /etc/apparmor.d/lxc/${profile}
65
66sed -i '/lxc.aa_profile/d' /var/lib/lxc/${_CONTAINER}/config
67echo "lxc.aa_profile = ${profile}" >> /var/lib/lxc/${_CONTAINER}/config
68
69/lib/init/apparmor-profile-load lxc-containers
70
71echo "Profile for ${_CONTAINER} updated. Edit /etc/apparmor.d/lxc/${profile} to customize."
072
=== renamed file 'debian/local/lxc-aa-custom-profile' => 'debian/local/lxc-aa-custom-profile.moved'
=== modified file 'debian/lxc.install'
--- debian/lxc.install 2012-06-25 01:34:12 +0000
+++ debian/lxc.install 2012-06-25 06:34:25 +0000
@@ -14,7 +14,12 @@
14debian/local/lxc-list /usr/bin14debian/local/lxc-list /usr/bin
15debian/local/lxc-restore /usr/bin15debian/local/lxc-restore /usr/bin
16debian/local/lxc.sh /etc/bash_completion.d16debian/local/lxc.sh /etc/bash_completion.d
17<<<<<<< TREE
17debian/local/lxc-start-ephemeral /usr/bin18debian/local/lxc-start-ephemeral /usr/bin
18debian/local/lxc-aa-custom-profile /usr/bin19debian/local/lxc-aa-custom-profile /usr/bin
20=======
21debian/local/lxc-start-ephemeral /usr/bin
22debian/local/lxc-aa-custom-profile /usr/bin
23>>>>>>> MERGE-SOURCE
1924
20debian/lxc.conf etc/lxc/25debian/lxc.conf etc/lxc/

Subscribers

People subscribed via source and target branches