Merge lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626 into lp:ubuntu/quantal/lxc

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626
Merge into: lp:ubuntu/quantal/lxc
Diff against target: 93 lines (+76/-0) (has conflicts)
2 files modified
debian/local/lxc-aa-custom-profile (+71/-0)
debian/lxc.install (+5/-0)
Conflict adding file debian/local/lxc-aa-custom-profile.  Moved existing file to debian/local/lxc-aa-custom-profile.moved.
Text conflict in debian/lxc.install
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+111782@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/quantal/lxc reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/quantal/lxc/quantal-201206250626. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

114. By Stéphane Graber

releasing version 0.8.0~rc1-4ubuntu15

113. By Stéphane Graber

Update apparmor profiles to fix nesting

112. By Stéphane Graber

No bashism in lxc-aa-custom-profile so make it use /bin/sh

111. By Stéphane Graber

Make the remaining scripts executable

110. By Stéphane Graber

Merge new lxc-aa-custom-profile tool from Serge Hallyn

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/local/lxc-aa-custom-profile'
2--- debian/local/lxc-aa-custom-profile 1970-01-01 00:00:00 +0000
3+++ debian/local/lxc-aa-custom-profile 2012-06-25 06:34:25 +0000
4@@ -0,0 +1,71 @@
5+#!/bin/sh
6+
7+set -e
8+
9+_OPTIONS="$(getopt -o n: -l name: -- "${@}")"
10+
11+if [ "${?}" -ne 0 ]
12+then
13+ echo "Usage: $(basename ${0}) -n|--name CONTAINER" >&2
14+ echo " creates a custom profile (copied from the default) for CONTAINER"
15+ exit 1
16+fi
17+
18+eval set -- "${_OPTIONS}"
19+
20+while true
21+do
22+ case "${1}" in
23+ -n|--name)
24+ _CONTAINER="${2}"
25+ shift 2
26+ ;;
27+
28+ --)
29+ shift
30+ break
31+ ;;
32+
33+ *)
34+ echo "E: $(basename ${0}): internal error ${0}" >&2
35+ exit 1
36+ ;;
37+ esac
38+done
39+
40+if [ `id -u` -ne 0 ]; then
41+ echo "E: $(basename ${0}): must run with privilege"
42+ exit 1
43+fi
44+
45+if [ -z "${_CONTAINER}" ]
46+then
47+ echo "E: $(basename ${0}): missing container name, use --name option" >&2
48+ exit 1
49+fi
50+
51+if [ ! -f /var/lib/lxc/${_CONTAINER}/config ]; then
52+ echo "E: $(basename ${0}): /var/lib/lxc/${_CONTAINER}/config - no such file"
53+ exit 1
54+fi
55+
56+profile="lxc-${_CONTAINER}"
57+if [ -f /etc/apparmor.d/lxc/${profile} ]; then
58+ echo "E: $(basename ${0}): custom profile already exists"
59+ exit 1
60+fi
61+
62+if [ ! -f /etc/apparmor.d/lxc/lxc-default ]; then
63+ echo "E: $(basename ${0}): default profile does not exist!"
64+ exit 1
65+fi
66+
67+cp -f /etc/apparmor.d/lxc/lxc-default /etc/apparmor.d/lxc/${profile}
68+sed -i "s/profile lxc-container-default/profile ${profile}/" /etc/apparmor.d/lxc/${profile}
69+
70+sed -i '/lxc.aa_profile/d' /var/lib/lxc/${_CONTAINER}/config
71+echo "lxc.aa_profile = ${profile}" >> /var/lib/lxc/${_CONTAINER}/config
72+
73+/lib/init/apparmor-profile-load lxc-containers
74+
75+echo "Profile for ${_CONTAINER} updated. Edit /etc/apparmor.d/lxc/${profile} to customize."
76
77=== renamed file 'debian/local/lxc-aa-custom-profile' => 'debian/local/lxc-aa-custom-profile.moved'
78=== modified file 'debian/lxc.install'
79--- debian/lxc.install 2012-06-25 01:34:12 +0000
80+++ debian/lxc.install 2012-06-25 06:34:25 +0000
81@@ -14,7 +14,12 @@
82 debian/local/lxc-list /usr/bin
83 debian/local/lxc-restore /usr/bin
84 debian/local/lxc.sh /etc/bash_completion.d
85+<<<<<<< TREE
86 debian/local/lxc-start-ephemeral /usr/bin
87 debian/local/lxc-aa-custom-profile /usr/bin
88+=======
89+debian/local/lxc-start-ephemeral /usr/bin
90+debian/local/lxc-aa-custom-profile /usr/bin
91+>>>>>>> MERGE-SOURCE
92
93 debian/lxc.conf etc/lxc/

Subscribers

People subscribed via source and target branches