Merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009 into lp:ubuntu/precise/gwibber-service-sohu

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009
Merge into: lp:ubuntu/precise/gwibber-service-sohu
Diff against target: 100 lines (+67/-0) (has conflicts)
4 files modified
debian/changelog (+12/-0)
debian/patches/logger.patch (+53/-0)
debian/patches/series (+1/-0)
debian/source/format (+1/-0)
Text conflict in debian/changelog
Conflict adding file debian/patches.  Moved existing file to debian/patches.moved.
Conflict adding file debian/source.  Moved existing file to debian/source.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+98382@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/precise/gwibber-service-sohu reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

5. By Ken VanDine

releasing version 0.8.1-0ubuntu4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-03-19 15:27:20 +0000
+++ debian/changelog 2012-03-20 10:15:23 +0000
@@ -1,3 +1,4 @@
1<<<<<<< TREE
1gwibber-service-sohu (0.8.1-0ubuntu5) precise; urgency=low2gwibber-service-sohu (0.8.1-0ubuntu5) precise; urgency=low
23
3 * debian/patches/gtk3.patch4 * debian/patches/gtk3.patch
@@ -14,6 +15,17 @@
1415
15 -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:02:23 -040016 -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:02:23 -0400
1617
18=======
19gwibber-service-sohu (0.8.1-0ubuntu4) precise; urgency=low
20
21 * debian/patches/logger.patch
22 - Updated to use the new logger in gwibber-service (LP: #947471)
23 * debian/control
24 - require gwibber-service >= 3.3.92 for the logger changes
25
26 -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:02:23 -0400
27
28>>>>>>> MERGE-SOURCE
17gwibber-service-sohu (0.8.1-0ubuntu3) precise; urgency=low29gwibber-service-sohu (0.8.1-0ubuntu3) precise; urgency=low
1830
19 * Rebuild to drop dependencies on python2.6.31 * Rebuild to drop dependencies on python2.6.
2032
=== added directory 'debian/patches'
=== renamed directory 'debian/patches' => 'debian/patches.moved'
=== added file 'debian/patches/logger.patch'
--- debian/patches/logger.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/logger.patch 2012-03-20 10:15:23 +0000
@@ -0,0 +1,53 @@
1=== modified file '__init__.py'
2--- old/__init__.py 2011-06-10 09:36:20 +0000
3+++ new/__init__.py 2012-03-19 18:00:05 +0000
4@@ -3,10 +3,14 @@
5 import re
6 import gnomekeyring
7 from oauth import oauth
8-from gwibber.microblog.util import log, resources
9+from gwibber.microblog.util import resources
10+
11 from gettext import lgettext as _
12 import sohu.utils
13-log.logger.name = "Sohu"
14+
15+import logging
16+logger = logging.getLogger("Sohu")
17+logger.debug("Initializing.")
18
19 PROTOCOL_INFO = {
20 "name": "Sohu",
21@@ -107,7 +111,7 @@
22 m["images"] = images
23 m["type"] = "photo"
24 except:
25- log.logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
26+ logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
27 return {}
28
29 return m
30@@ -219,7 +223,7 @@
31 if isinstance(data, dict) and data.get("errors", 0):
32 if "authenticate" in data["errors"][0]["message"]:
33 logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Authentication failed"), error["message"])
34- log.logger.error("%s", logstr)
35+ logger.error("%s", logstr)
36 return [{"error": {"type": "auth", "account": self.account, "message": data["errors"][0]["message"]}}]
37 else:
38 for error in data["errors"]:
39@@ -228,11 +232,11 @@
40 elif isinstance(data, dict) and data.get("error", 0):
41 if "Incorrect signature" in data["error"]:
42 logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data["error"])
43- log.logger.error("%s", logstr)
44+ logger.error("%s", logstr)
45 return [{"error": {"type": "auth", "account": self.account, "message": data["error"]}}]
46 elif isinstance(data, str):
47 logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data)
48- log.logger.error("%s", logstr)
49+ logger.error("%s", logstr)
50 return [{"error": {"type": "request", "account": self.account, "message": data}}]
51
52 if parse == "list":
53
054
=== added file 'debian/patches/series'
--- debian/patches/series 1970-01-01 00:00:00 +0000
+++ debian/patches/series 2012-03-20 10:15:23 +0000
@@ -0,0 +1,1 @@
1logger.patch
02
=== added directory 'debian/source'
=== renamed directory 'debian/source' => 'debian/source.moved'
=== added file 'debian/source/format'
--- debian/source/format 1970-01-01 00:00:00 +0000
+++ debian/source/format 2012-03-20 10:15:23 +0000
@@ -0,0 +1,1 @@
13.0 (quilt)

Subscribers

People subscribed via source and target branches

to all changes: