Merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009 into lp:ubuntu/precise/gwibber-service-sohu

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009
Merge into: lp:ubuntu/precise/gwibber-service-sohu
Diff against target: 100 lines (+67/-0) (has conflicts)
4 files modified
debian/changelog (+12/-0)
debian/patches/logger.patch (+53/-0)
debian/patches/series (+1/-0)
debian/source/format (+1/-0)
Text conflict in debian/changelog
Conflict adding file debian/patches.  Moved existing file to debian/patches.moved.
Conflict adding file debian/source.  Moved existing file to debian/source.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+98382@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/precise/gwibber-service-sohu reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sohu/precise-201203201009. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

5. By Ken VanDine

releasing version 0.8.1-0ubuntu4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-19 15:27:20 +0000
3+++ debian/changelog 2012-03-20 10:15:23 +0000
4@@ -1,3 +1,4 @@
5+<<<<<<< TREE
6 gwibber-service-sohu (0.8.1-0ubuntu5) precise; urgency=low
7
8 * debian/patches/gtk3.patch
9@@ -14,6 +15,17 @@
10
11 -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:02:23 -0400
12
13+=======
14+gwibber-service-sohu (0.8.1-0ubuntu4) precise; urgency=low
15+
16+ * debian/patches/logger.patch
17+ - Updated to use the new logger in gwibber-service (LP: #947471)
18+ * debian/control
19+ - require gwibber-service >= 3.3.92 for the logger changes
20+
21+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:02:23 -0400
22+
23+>>>>>>> MERGE-SOURCE
24 gwibber-service-sohu (0.8.1-0ubuntu3) precise; urgency=low
25
26 * Rebuild to drop dependencies on python2.6.
27
28=== added directory 'debian/patches'
29=== renamed directory 'debian/patches' => 'debian/patches.moved'
30=== added file 'debian/patches/logger.patch'
31--- debian/patches/logger.patch 1970-01-01 00:00:00 +0000
32+++ debian/patches/logger.patch 2012-03-20 10:15:23 +0000
33@@ -0,0 +1,53 @@
34+=== modified file '__init__.py'
35+--- old/__init__.py 2011-06-10 09:36:20 +0000
36++++ new/__init__.py 2012-03-19 18:00:05 +0000
37+@@ -3,10 +3,14 @@
38+ import re
39+ import gnomekeyring
40+ from oauth import oauth
41+-from gwibber.microblog.util import log, resources
42++from gwibber.microblog.util import resources
43++
44+ from gettext import lgettext as _
45+ import sohu.utils
46+-log.logger.name = "Sohu"
47++
48++import logging
49++logger = logging.getLogger("Sohu")
50++logger.debug("Initializing.")
51+
52+ PROTOCOL_INFO = {
53+ "name": "Sohu",
54+@@ -107,7 +111,7 @@
55+ m["images"] = images
56+ m["type"] = "photo"
57+ except:
58+- log.logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
59++ logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
60+ return {}
61+
62+ return m
63+@@ -219,7 +223,7 @@
64+ if isinstance(data, dict) and data.get("errors", 0):
65+ if "authenticate" in data["errors"][0]["message"]:
66+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Authentication failed"), error["message"])
67+- log.logger.error("%s", logstr)
68++ logger.error("%s", logstr)
69+ return [{"error": {"type": "auth", "account": self.account, "message": data["errors"][0]["message"]}}]
70+ else:
71+ for error in data["errors"]:
72+@@ -228,11 +232,11 @@
73+ elif isinstance(data, dict) and data.get("error", 0):
74+ if "Incorrect signature" in data["error"]:
75+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data["error"])
76+- log.logger.error("%s", logstr)
77++ logger.error("%s", logstr)
78+ return [{"error": {"type": "auth", "account": self.account, "message": data["error"]}}]
79+ elif isinstance(data, str):
80+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data)
81+- log.logger.error("%s", logstr)
82++ logger.error("%s", logstr)
83+ return [{"error": {"type": "request", "account": self.account, "message": data}}]
84+
85+ if parse == "list":
86+
87
88=== added file 'debian/patches/series'
89--- debian/patches/series 1970-01-01 00:00:00 +0000
90+++ debian/patches/series 2012-03-20 10:15:23 +0000
91@@ -0,0 +1,1 @@
92+logger.patch
93
94=== added directory 'debian/source'
95=== renamed directory 'debian/source' => 'debian/source.moved'
96=== added file 'debian/source/format'
97--- debian/source/format 1970-01-01 00:00:00 +0000
98+++ debian/source/format 2012-03-20 10:15:23 +0000
99@@ -0,0 +1,1 @@
100+3.0 (quilt)

Subscribers

People subscribed via source and target branches

to all changes: