Merge lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812 into lp:ubuntu/natty/gvfs

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812
Merge into: lp:ubuntu/natty/gvfs
Diff against target: 491 lines (+449/-6) (has conflicts)
7 files modified
debian/gvfs-backends.debhelper.log (+0/-1)
debian/gvfs-bin.debhelper.log (+0/-1)
debian/gvfs-fuse.debhelper.log (+0/-1)
debian/gvfs.debhelper.log (+0/-1)
debian/libgvfscommon-dev.debhelper.log (+0/-1)
debian/libgvfscommon0.debhelper.log (+0/-1)
debian/patches/90_git_leaks_fixes.patch (+449/-0)
Conflict adding file debian/patches/90_git_leaks_fixes.patch.  Moved existing file to debian/patches/90_git_leaks_fixes.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+72482@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archve and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/natty/gvfs reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

156. By Sebastien Bacher

releasing version 1.8.0-0ubuntu2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== removed file 'debian/gvfs-backends.debhelper.log'
--- debian/gvfs-backends.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/gvfs-backends.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== removed file 'debian/gvfs-bin.debhelper.log'
--- debian/gvfs-bin.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/gvfs-bin.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== removed file 'debian/gvfs-fuse.debhelper.log'
--- debian/gvfs-fuse.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/gvfs-fuse.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== removed file 'debian/gvfs.debhelper.log'
--- debian/gvfs.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/gvfs.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== removed file 'debian/libgvfscommon-dev.debhelper.log'
--- debian/libgvfscommon-dev.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/libgvfscommon-dev.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== removed file 'debian/libgvfscommon0.debhelper.log'
--- debian/libgvfscommon0.debhelper.log 2010-10-25 19:30:18 +0000
+++ debian/libgvfscommon0.debhelper.log 1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
1dh_autoreconf_clean
20
=== added file 'debian/patches/90_git_leaks_fixes.patch'
--- debian/patches/90_git_leaks_fixes.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/90_git_leaks_fixes.patch 2011-08-22 18:25:34 +0000
@@ -0,0 +1,449 @@
1From caf8ba57f5c20c588bf685c648d842e8d46bf769 Mon Sep 17 00:00:00 2001
2From: Alexander Larsson <alexl@redhat.com>
3Date: Fri, 15 Apr 2011 11:05:30 +0000
4Subject: Don't leak dbus messages
5
6We're missing a lot of dbus_message_unref after sending messages, add them.
7---
8diff --git a/daemon/daemon-main.c b/daemon/daemon-main.c
9index 22cebe6..13e4780 100644
10--- a/daemon/daemon-main.c
11+++ b/daemon/daemon-main.c
12@@ -127,6 +127,7 @@ send_spawned (DBusConnection *connection, gboolean succeeded, char *error_messag
13 _g_dbus_oom ();
14
15 dbus_connection_send (connection, message, NULL);
16+ dbus_message_unref (message);
17 /* Make sure the message is sent */
18 dbus_connection_flush (connection);
19 }
20diff --git a/daemon/gvfsjobcopy.c b/daemon/gvfsjobcopy.c
21index 730e1e2..e833168 100644
22--- a/daemon/gvfsjobcopy.c
23+++ b/daemon/gvfsjobcopy.c
24@@ -104,6 +104,8 @@ g_vfs_job_copy_new (DBusConnection *connection,
25 dbus_error_free (&derror);
26
27 dbus_connection_send (connection, reply, NULL);
28+ dbus_message_unref (reply);
29+
30 return NULL;
31 }
32
33diff --git a/daemon/gvfsjobcreatemonitor.c b/daemon/gvfsjobcreatemonitor.c
34index 074a866..e825de3 100644
35--- a/daemon/gvfsjobcreatemonitor.c
36+++ b/daemon/gvfsjobcreatemonitor.c
37@@ -104,6 +104,7 @@ g_vfs_job_create_monitor_new (DBusConnection *connection,
38 dbus_error_free (&derror);
39
40 dbus_connection_send (connection, reply, NULL);
41+ dbus_message_unref (reply);
42 return NULL;
43 }
44
45diff --git a/daemon/gvfsjobdelete.c b/daemon/gvfsjobdelete.c
46index 688e604..bbc3891 100644
47--- a/daemon/gvfsjobdelete.c
48+++ b/daemon/gvfsjobdelete.c
49@@ -96,6 +96,7 @@ g_vfs_job_delete_new (DBusConnection *connection,
50 dbus_error_free (&derror);
51
52 dbus_connection_send (connection, reply, NULL);
53+ dbus_message_unref (reply);
54 return NULL;
55 }
56
57diff --git a/daemon/gvfsjobenumerate.c b/daemon/gvfsjobenumerate.c
58index 90ff452..208f0ba 100644
59--- a/daemon/gvfsjobenumerate.c
60+++ b/daemon/gvfsjobenumerate.c
61@@ -110,6 +110,7 @@ g_vfs_job_enumerate_new (DBusConnection *connection,
62 dbus_error_free (&derror);
63
64 dbus_connection_send (connection, reply, NULL);
65+ dbus_message_unref (reply);
66 return NULL;
67 }
68
69diff --git a/daemon/gvfsjobmakedirectory.c b/daemon/gvfsjobmakedirectory.c
70index 2e9c7e2..61257d9 100644
71--- a/daemon/gvfsjobmakedirectory.c
72+++ b/daemon/gvfsjobmakedirectory.c
73@@ -96,6 +96,7 @@ g_vfs_job_make_directory_new (DBusConnection *connection,
74 dbus_error_free (&derror);
75
76 dbus_connection_send (connection, reply, NULL);
77+ dbus_message_unref (reply);
78 return NULL;
79 }
80
81diff --git a/daemon/gvfsjobmakesymlink.c b/daemon/gvfsjobmakesymlink.c
82index 157e70f..0ea22fa 100644
83--- a/daemon/gvfsjobmakesymlink.c
84+++ b/daemon/gvfsjobmakesymlink.c
85@@ -99,6 +99,7 @@ g_vfs_job_make_symlink_new (DBusConnection *connection,
86 dbus_error_free (&derror);
87
88 dbus_connection_send (connection, reply, NULL);
89+ dbus_message_unref (reply);
90 return NULL;
91 }
92
93diff --git a/daemon/gvfsjobmountmountable.c b/daemon/gvfsjobmountmountable.c
94index 1d60836..6cc2ea2 100644
95--- a/daemon/gvfsjobmountmountable.c
96+++ b/daemon/gvfsjobmountmountable.c
97@@ -109,6 +109,7 @@ g_vfs_job_mount_mountable_new (DBusConnection *connection,
98 dbus_error_free (&derror);
99
100 dbus_connection_send (connection, reply, NULL);
101+ dbus_message_unref (reply);
102 return NULL;
103 }
104
105diff --git a/daemon/gvfsjobmove.c b/daemon/gvfsjobmove.c
106index 0f3b7a2..9a6bd89 100644
107--- a/daemon/gvfsjobmove.c
108+++ b/daemon/gvfsjobmove.c
109@@ -104,6 +104,7 @@ g_vfs_job_move_new (DBusConnection *connection,
110 dbus_error_free (&derror);
111
112 dbus_connection_send (connection, reply, NULL);
113+ dbus_message_unref (reply);
114 return NULL;
115 }
116
117diff --git a/daemon/gvfsjobopenforread.c b/daemon/gvfsjobopenforread.c
118index 31265db..d217c27 100644
119--- a/daemon/gvfsjobopenforread.c
120+++ b/daemon/gvfsjobopenforread.c
121@@ -106,6 +106,7 @@ g_vfs_job_open_for_read_new (DBusConnection *connection,
122 dbus_error_free (&derror);
123
124 dbus_connection_send (connection, reply, NULL);
125+ dbus_message_unref (reply);
126 return NULL;
127 }
128
129diff --git a/daemon/gvfsjobopenforwrite.c b/daemon/gvfsjobopenforwrite.c
130index 6d368f8..6e7396c 100644
131--- a/daemon/gvfsjobopenforwrite.c
132+++ b/daemon/gvfsjobopenforwrite.c
133@@ -116,6 +116,7 @@ g_vfs_job_open_for_write_new (DBusConnection *connection,
134 dbus_error_free (&derror);
135
136 dbus_connection_send (connection, reply, NULL);
137+ dbus_message_unref (reply);
138 g_free (path);
139 return NULL;
140 }
141diff --git a/daemon/gvfsjobopeniconforread.c b/daemon/gvfsjobopeniconforread.c
142index 1e36a24..59e813a 100644
143--- a/daemon/gvfsjobopeniconforread.c
144+++ b/daemon/gvfsjobopeniconforread.c
145@@ -87,6 +87,7 @@ g_vfs_job_open_icon_for_read_new (DBusConnection *connection,
146 dbus_error_free (&derror);
147
148 dbus_connection_send (connection, reply, NULL);
149+ dbus_message_unref (reply);
150 return NULL;
151 }
152
153diff --git a/daemon/gvfsjobpollmountable.c b/daemon/gvfsjobpollmountable.c
154index 4fa67b1..ac59da2 100644
155--- a/daemon/gvfsjobpollmountable.c
156+++ b/daemon/gvfsjobpollmountable.c
157@@ -99,6 +99,7 @@ g_vfs_job_poll_mountable_new (DBusConnection *connection,
158 dbus_error_free (&derror);
159
160 dbus_connection_send (connection, reply, NULL);
161+ dbus_message_unref (reply);
162 return NULL;
163 }
164
165diff --git a/daemon/gvfsjobpull.c b/daemon/gvfsjobpull.c
166index 4d66bf0..1d4bc78 100644
167--- a/daemon/gvfsjobpull.c
168+++ b/daemon/gvfsjobpull.c
169@@ -107,6 +107,7 @@ g_vfs_job_pull_new (DBusConnection *connection,
170 dbus_error_free (&derror);
171
172 dbus_connection_send (connection, reply, NULL);
173+ dbus_message_unref (reply);
174 return NULL;
175 }
176
177diff --git a/daemon/gvfsjobpush.c b/daemon/gvfsjobpush.c
178index 49680b3..b4b3874 100644
179--- a/daemon/gvfsjobpush.c
180+++ b/daemon/gvfsjobpush.c
181@@ -107,6 +107,7 @@ g_vfs_job_push_new (DBusConnection *connection,
182 dbus_error_free (&derror);
183
184 dbus_connection_send (connection, reply, NULL);
185+ dbus_message_unref (reply);
186 return NULL;
187 }
188
189diff --git a/daemon/gvfsjobqueryattributes.c b/daemon/gvfsjobqueryattributes.c
190index 426a26b..3307cfa 100644
191--- a/daemon/gvfsjobqueryattributes.c
192+++ b/daemon/gvfsjobqueryattributes.c
193@@ -100,6 +100,7 @@ g_vfs_job_query_attributes_new (DBusConnection *connection,
194 dbus_error_free (&derror);
195
196 dbus_connection_send (connection, reply, NULL);
197+ dbus_message_unref (reply);
198 return NULL;
199 }
200
201diff --git a/daemon/gvfsjobqueryfsinfo.c b/daemon/gvfsjobqueryfsinfo.c
202index cce7ded..e464590 100644
203--- a/daemon/gvfsjobqueryfsinfo.c
204+++ b/daemon/gvfsjobqueryfsinfo.c
205@@ -101,6 +101,7 @@ g_vfs_job_query_fs_info_new (DBusConnection *connection,
206 dbus_error_free (&derror);
207
208 dbus_connection_send (connection, reply, NULL);
209+ dbus_message_unref (reply);
210 return NULL;
211 }
212
213diff --git a/daemon/gvfsjobqueryinfo.c b/daemon/gvfsjobqueryinfo.c
214index 3a52539..27c8edc 100644
215--- a/daemon/gvfsjobqueryinfo.c
216+++ b/daemon/gvfsjobqueryinfo.c
217@@ -110,6 +110,7 @@ g_vfs_job_query_info_new (DBusConnection *connection,
218 dbus_error_free (&derror);
219
220 dbus_connection_send (connection, reply, NULL);
221+ dbus_message_unref (reply);
222 return NULL;
223 }
224
225diff --git a/daemon/gvfsjobsetattribute.c b/daemon/gvfsjobsetattribute.c
226index c908216..ad2a8a2 100644
227--- a/daemon/gvfsjobsetattribute.c
228+++ b/daemon/gvfsjobsetattribute.c
229@@ -120,6 +120,7 @@ g_vfs_job_set_attribute_new (DBusConnection *connection,
230 _("Invalid dbus message"));
231
232 dbus_connection_send (connection, reply, NULL);
233+ dbus_message_unref (reply);
234 return NULL;
235 }
236
237diff --git a/daemon/gvfsjobsetdisplayname.c b/daemon/gvfsjobsetdisplayname.c
238index 9ac10a3..0816c8b 100644
239--- a/daemon/gvfsjobsetdisplayname.c
240+++ b/daemon/gvfsjobsetdisplayname.c
241@@ -100,6 +100,7 @@ g_vfs_job_set_display_name_new (DBusConnection *connection,
242 dbus_error_free (&derror);
243
244 dbus_connection_send (connection, reply, NULL);
245+ dbus_message_unref (reply);
246 return NULL;
247 }
248
249diff --git a/daemon/gvfsjobstartmountable.c b/daemon/gvfsjobstartmountable.c
250index e862846..b4492db 100644
251--- a/daemon/gvfsjobstartmountable.c
252+++ b/daemon/gvfsjobstartmountable.c
253@@ -105,6 +105,7 @@ g_vfs_job_start_mountable_new (DBusConnection *connection,
254 dbus_error_free (&derror);
255
256 dbus_connection_send (connection, reply, NULL);
257+ dbus_message_unref (reply);
258 return NULL;
259 }
260
261diff --git a/daemon/gvfsjobstopmountable.c b/daemon/gvfsjobstopmountable.c
262index 31f480a..c291d38 100644
263--- a/daemon/gvfsjobstopmountable.c
264+++ b/daemon/gvfsjobstopmountable.c
265@@ -107,6 +107,7 @@ g_vfs_job_stop_mountable_new (DBusConnection *connection,
266 dbus_error_free (&derror);
267
268 dbus_connection_send (connection, reply, NULL);
269+ dbus_message_unref (reply);
270 return NULL;
271 }
272
273diff --git a/daemon/gvfsjobtrash.c b/daemon/gvfsjobtrash.c
274index e6f6388..338bf0d 100644
275--- a/daemon/gvfsjobtrash.c
276+++ b/daemon/gvfsjobtrash.c
277@@ -96,6 +96,7 @@ g_vfs_job_trash_new (DBusConnection *connection,
278 dbus_error_free (&derror);
279
280 dbus_connection_send (connection, reply, NULL);
281+ dbus_message_unref (reply);
282 return NULL;
283 }
284
285diff --git a/daemon/gvfsjobunmount.c b/daemon/gvfsjobunmount.c
286index ee2cb7e..17e364f 100644
287--- a/daemon/gvfsjobunmount.c
288+++ b/daemon/gvfsjobunmount.c
289@@ -106,6 +106,7 @@ g_vfs_job_unmount_new (DBusConnection *connection,
290 dbus_error_free (&derror);
291
292 dbus_connection_send (connection, reply, NULL);
293+ dbus_message_unref (reply);
294 return NULL;
295 }
296
297diff --git a/daemon/gvfsjobunmountmountable.c b/daemon/gvfsjobunmountmountable.c
298index ed648ca..9cf9c2d 100644
299--- a/daemon/gvfsjobunmountmountable.c
300+++ b/daemon/gvfsjobunmountmountable.c
301@@ -108,6 +108,7 @@ g_vfs_job_unmount_mountable_new (DBusConnection *connection,
302 dbus_error_free (&derror);
303
304 dbus_connection_send (connection, reply, NULL);
305+ dbus_message_unref (reply);
306 return NULL;
307 }
308
309diff --git a/daemon/gvfsmonitor.c b/daemon/gvfsmonitor.c
310index 4b91ece..8947099 100644
311--- a/daemon/gvfsmonitor.c
312+++ b/daemon/gvfsmonitor.c
313@@ -184,8 +184,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
314 derror.name,
315 derror.message);
316 dbus_error_free (&derror);
317-
318+
319 dbus_connection_send (connection, reply, NULL);
320+ dbus_message_unref (reply);
321 }
322 else
323 {
324@@ -199,8 +200,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
325
326 reply = dbus_message_new_method_return (message);
327 dbus_connection_send (connection, reply, NULL);
328+ dbus_message_unref (reply);
329 }
330-
331+
332 return DBUS_HANDLER_RESULT_HANDLED;
333 }
334 else if (dbus_message_is_method_call (message,
335@@ -216,8 +218,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
336 derror.name,
337 derror.message);
338 dbus_error_free (&derror);
339-
340+
341 dbus_connection_send (connection, reply, NULL);
342+ dbus_message_unref (reply);
343 }
344 else
345 {
346@@ -235,9 +238,10 @@ vfs_monitor_message_callback (DBusConnection *connection,
347 break;
348 }
349 }
350-
351+
352 reply = dbus_message_new_method_return (message);
353 dbus_connection_send (connection, reply, NULL);
354+ dbus_message_unref (reply);
355
356 g_object_unref (monitor);
357 }
358diff --git a/daemon/mount.c b/daemon/mount.c
359index 2331559..6eb07d3 100644
360--- a/daemon/mount.c
361+++ b/daemon/mount.c
362@@ -757,6 +757,7 @@ register_mount (DBusConnection *connection,
363 _g_dbus_oom ();
364
365 dbus_connection_send (connection, reply, NULL);
366+ dbus_message_unref (reply);
367 }
368
369 typedef struct {
370@@ -778,6 +779,7 @@ automount_done (VfsMountable *mountable,
371 G_IO_ERROR, G_IO_ERROR_NOT_MOUNTED,
372 _("Automount failed: %s"), error->message);
373 dbus_connection_send (data->connection, reply, NULL);
374+ dbus_message_unref (reply);
375 }
376 else
377 lookup_mount (data->connection,
378@@ -870,7 +872,10 @@ lookup_mount (DBusConnection *connection,
379
380 g_mount_spec_unref (spec);
381 if (reply != NULL)
382- dbus_connection_send (connection, reply, NULL);
383+ {
384+ dbus_connection_send (connection, reply, NULL);
385+ dbus_message_unref (reply);
386+ }
387 }
388
389 static void
390@@ -910,9 +915,12 @@ lookup_mount_by_fuse_path (DBusConnection *connection,
391 reply = dbus_message_new_error (message,
392 DBUS_ERROR_INVALID_ARGS,
393 "Invalid arguments");
394-
395+
396 if (reply != NULL)
397- dbus_connection_send (connection, reply, NULL);
398+ {
399+ dbus_connection_send (connection, reply, NULL);
400+ dbus_message_unref (reply);
401+ }
402 }
403
404 static void
405@@ -958,8 +966,9 @@ list_mounts (DBusConnection *connection,
406
407 if (!dbus_message_iter_close_container (&iter, &array_iter))
408 _g_dbus_oom ();
409-
410+
411 dbus_connection_send (connection, reply, NULL);
412+ dbus_message_unref (reply);
413 }
414
415 static void
416@@ -1047,7 +1056,10 @@ mount_location (DBusConnection *connection,
417 }
418
419 if (reply)
420- dbus_connection_send (connection, reply, NULL);
421+ {
422+ dbus_connection_send (connection, reply, NULL);
423+ dbus_message_unref (reply);
424+ }
425 else
426 {
427 GMountSource *source;
428@@ -1099,8 +1111,9 @@ list_mount_types (DBusConnection *connection,
429
430 if (!dbus_message_iter_close_container (&iter, &array_iter))
431 _g_dbus_oom ();
432-
433+
434 dbus_connection_send (connection, reply, NULL);
435+ dbus_message_unref (reply);
436 }
437
438 static void
439@@ -1140,8 +1153,9 @@ list_mountable_info (DBusConnection *connection,
440
441 if (!dbus_message_iter_close_container (&iter, &array_iter))
442 _g_dbus_oom ();
443-
444+
445 dbus_connection_send (connection, reply, NULL);
446+ dbus_message_unref (reply);
447 }
448
449 static DBusHandlerResult
0450
=== renamed file 'debian/patches/90_git_leaks_fixes.patch' => 'debian/patches/90_git_leaks_fixes.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: