Merge lp:~ubuntu-branches/ubuntu/natty/evolution-mapi/natty-201103250158 into lp:ubuntu/natty/evolution-mapi

Proposed by James Westby
Status: Work in progress
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/evolution-mapi/natty-201103250158
Merge into: lp:ubuntu/natty/evolution-mapi
Diff against target: 66 lines (+60/-0) (has conflicts)
1 file modified
debian/patches/02_recurring_events (+60/-0)
Conflict adding file debian/patches/02_recurring_events.  Moved existing file to debian/patches/02_recurring_events.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/evolution-mapi/natty-201103250158
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+55057@code.launchpad.net

Description of the change

The package history in the archive and the history in the bzr branch differ. As the archive is authoritative the history of lp:ubuntu/natty/evolution-mapi now reflects that and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/natty/evolution-mapi/natty-201103250158. A merge should be performed if necessary.

To post a comment you must log in.

Unmerged revisions

15. By Chuck Short

* Add patch 02_recurring_events: fix recurring events not showing from
  Exchange 2007. LP: #513394
* Add 'Enhances: evolution' for evolution-mapi.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'debian/patches/02_recurring_events'
--- debian/patches/02_recurring_events 1970-01-01 00:00:00 +0000
+++ debian/patches/02_recurring_events 2011-03-28 07:08:48 +0000
@@ -0,0 +1,60 @@
1Description: Cherry-pick of fix for recurring events, Ubuntu bug 513394
2Origin: upstream, commit: f36cca5d32ce87a53684d950d53da75e266553ff,
3 commit:fc48cc0ae6f74f9ca292969fa034da6c48f1e6ef
4Bug: https://bugzilla.gnome.org/show_bug.cgi?id=604029
5Author: Milan Crha <mcrha@redhat.com>, Sean Finney <seanius@seanius.net>
6
7=== modified file 'src/libexchangemapi/exchange-mapi-cal-recur-utils.c'
8--- old/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2010-10-19 15:03:33 +0000
9+++ new/src/libexchangemapi/exchange-mapi-cal-recur-utils.c 2011-02-11 23:36:57 +0000
10@@ -656,8 +656,10 @@
11 /* some constant */
12 flag32 = *((guint32 *)ptr);
13 ptr += sizeof (guint32);
14+ /* It should be set, but not must. It can be, technically, any value.
15+ Seen were 0x3006, 0x3008, 0x3009. It affects format of extended exception info
16 if (flag32 != WRITER_VERSION2)
17- return FALSE;
18+ return FALSE; */
19
20 /* start time in mins */
21 flag32 = *((guint32 *)ptr);
22@@ -670,20 +672,11 @@
23 /* modified exceptions */
24 flag16 = *((guint16 *)ptr);
25 ptr += sizeof (guint16);
26- if (flag16 != 0x0)
27- return FALSE;
28-
29- /* reserved block1 size - has to be 0 */
30- flag32 = *((guint32 *)ptr);
31- ptr += sizeof (guint32);
32- if (flag32 != 0x0)
33- return FALSE;
34-
35- /* reserved block2 size - has to be 0 */
36- flag32 = *((guint32 *)ptr);
37- ptr += sizeof (guint32);
38- if (flag32 != 0x0)
39- return FALSE;
40+ /* FIXME: there are flag16 count modified exceptions here, which
41+ are variable in size, followed by a ReservedBlock1{Size,}
42+ and ReservedBlock2{Size,}. However, since we have nothing
43+ else to do until we are able to parse these modified
44+ instances, we just stop now. */
45
46 /* Set the recurrence */
47 {
48@@ -698,11 +691,6 @@
49 /* FIXME: this also has modified instances */
50 e_cal_component_set_exdate_list (comp, exdate_list);
51
52- g_print ("\n== MAPI to ICAL == The recurrence blob data is as follows:\n");
53- for (i = 0; i < ba->len; ++i)
54- g_print ("0x%02X ", ba->data[i]);
55- g_print("\n== End of stream ==\n");
56-
57 return TRUE;
58 }
59
60
061
=== renamed file 'debian/patches/02_recurring_events' => 'debian/patches/02_recurring_events.moved'

Subscribers

People subscribed via source and target branches

to all changes: